kvas-it / cli-mock Goto Github PK

Since we're mocking subprocess.Popen when popen_controller fixture is used, we could easily well record all calls to it (with arguments) and make it available for inspection by the test. This information could be quite useful to make sure the code is doing what we expect it to be doing.

Sometimes we don't want the code under test to be able to call anything that we are not expecting it to call. For example if we want it to execute some commands that affect the file system, we usually don't want the erroneous commands (which we haven't mocked because we don't expect them) to reach the actual file system.

The strict mode would ensure that any command not in the replay log would just cause a failure of subprocess.Popen instead of being executed.

popen_controller.set_replay_log should get an optional parameter strict. When it's set to True, only commands in the log can be executed (and they will be replayed from the log) and anything else will cause an assertion error to be thrown. When it's False, other commands can also be executed (they will be passed to subprocess.Popen without modifications).

The default value for the strict parameter is TBD.