kwangchin / githubhook Goto Github PK

If the payload is missing, it won't be logged with the way the class is setup, even if debug is enabled. This is because, in the constructor, _notFound is called before enableDebug can be. I fixed this by changing the constructor:

    function __construct($debug = FALSE) {
        $this->_debug = $debug;

I left the enableDebug method - it might be useful in some cases.

When using the class, it is as simple as:

$hook = new GitHubHook($debug = TRUE);

($debug = included for clarity in an example case, but is unnecessary)

I think it would be better to use syslog for logging. The default setting of having log directory directly on the project root could pose security issue for users who are unaware of the vulnerability. Using syslog also solves the problem of logrotate

Your syntax (https://github.com/kwangchin/GitHubHook/blob/master/class.GitHubHook.php#L173) is:

$cmd='git pull --git-dir='. escapeshellarg($branch['path']) .' options '. escapeshellarg($branch['name']); 

it should be:

$cmd='git --git-dir='. escapeshellarg($branch['path'] . '/.git') .' --work-tree='. escapeshellarg($branch['path']) .' pull origin '. escapeshellarg($branch['name']); 

Also, the '/.git' should probably check for a slash at the end of the path and use '.git' if a slash already exists.