kxsystems / ml Goto Github PK

.ml.fresh.significantfeatures is broken.

the function is trying to pull columns from a table using #(take) notation, this is incorrect and will fail, you can do this from a dictionary, but I would recommend using applicative notation.

Here is original and suggested changes after making these changes the function started working,
0riginal:
fresh.significantfeatures:{[table;targets]
table:(where 0=var each flip table)_table;
bintest:{2=count distinct x};
bintarget:bintest targets;
bincols:where bintest each flip table;
realcols:cols[table]except bincols;
bintab:bincols#table;
realtab:realcols#table;
pvals:raze$[bintarget;
{y[x;]each flip z}[targets]'[fresh.ks2samp,fresh.fishertest;(realtab;bintab)];
{y[x;]each flip z}[targets]'[fresh.ktaupy,fresh.ks2samp;(realtab;bintab)]];
insignificant:fresh.benjhochfind[pvals;0.05];
cols[table]except insignificant
}

suggested changes:
fresh.significantfeatures:{[table;targets]
table:(where 0=var each flip table)_table;
bintest:{2=count distinct x};
bintarget:bintest targets;
bincols:where bintest each flip table;
realcols:cols[table]except bincols;
bintab:table[bincols];
realtab:table[realcols];
pvals:raze$[bintarget;
{y[x;]each z}[targets]'[fresh.ks2samp,fresh.fishertest;(realtab;bintab)];
{y[x;]each z}[targets]'[fresh.ktaupy,fresh.ks2samp;(realtab;bintab)]];
insignificant:fresh.benjhochfind[pvals;0.05];
cols[table]except cols[table]insignificant
}

deal [email protected];

I find a problem: Invalid function document （https://code.kx.com/q/ml/）.
I want to ask what happened? Will the website still be maintained?
What if I want to query the function?
Thank you!

2023.03.21
student zhao

For k-fold cross validation, a check could be included to ensure that 0<k<len(data)

Incorporate C code build into future release for toolkit