kyleamathews / react-sparkline Goto Github PK

every 1/10 second calculate speed by measuring before and after coordinate and distance traveled in that time.

Because d3 is only called in componentDidMount, it's not possible to pass a new data prop to have the graph transform to suit the new values. - see https://github.com/KyleAMathews/react-sparkline/blob/master/src/index.cjsx#L18

It may be as simple as just adding a componentDidUpdate handler that just calls the same renderSparkline method.

I see you have your own enhancement request for animated updates but I think handling updates at all will be a good first step.

If data == array of ints, then render as is now, else if object, assume there's a date + value key

Hello, cool little library just having a play around with it.

It would be nice to support empty datasets without crashing, right now there is an svg error due to an attempted calculation on an empty array.

This is line is the particular issue on the surface though I'm sure more will have to change to support the empty data prop - https://github.com/KyleAMathews/react-sparkline/blob/master/src/index.cjsx#L58

Personally I would expect just an empty/transparent block when data is an empty array.

Found this component linked from https://github.com/brillout/awesome-react-components - was going to use it in a demo to show how you can easily leverage community effort but had to abort because you've used React.createClass which got deprecated.

Would you be up for a PR to modernise this to work on React 16+? I'll do the PR if you'd be happy to merge it.

amazing work!
is this component support react-native?