l0um15 / spotisharp Goto Github PK

Describe the bug
Getting the following exception:

Connecting To Spotify...
Making requests to Spotify...
Downloading ::::: Moderat - Intruder
Unhandled exception. YoutubeExplode.Exceptions.TransientFailureException: Video watch page is broken.
In most cases, this error indicates that the problem is on YouTube's side and this is not a bug in the library.
To resolve this error, please wait some time and try again.
If this issue persists, please report it on the project's GitHub page.
   at YoutubeExplode.ReverseEngineering.Responses.WatchPage.<>c__DisplayClass11_0.<<GetAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at YoutubeExplode.Internal.Retry.WrapAsync[T](Func`1 executeAsync)
   at YoutubeExplode.Internal.Retry.WrapAsync[T](Func`1 executeAsync)
   at YoutubeExplode.ReverseEngineering.Responses.WatchPage.GetAsync(YoutubeHttpClient httpClient, String videoId)
   at YoutubeExplode.Videos.Streams.StreamClient.GetStreamContextFromWatchPageAsync(VideoId videoId)
   at YoutubeExplode.Videos.Streams.StreamClient.GetManifestAsync(VideoId videoId)
   at SpotiSharp.DownloadHelpers.DownloadAndConvertTrack(YoutubeClient youtube, TrackInfo trackInfo) in D:\Projects\C#\SpotiSharp\DownloadHelpers.cs:line 14
   at SpotiSharp.Program.Main(String[] args) in D:\Projects\C#\SpotiSharp\Program.cs:line 127

How To Reproduce
Getting the above exception when attempting to download either a single track or entire playlist - song URL from above sample: https://open.spotify.com/track/6dS7rWtP9G7R1o2FSeomQe?si=f7a54af057ef4d4c

Reproduced in PowerShell v5.1, both with the self-contained version of SpotiSharp and with framework-dependent version with .Net 3.1.13 Runtime installed.

Desktop (please complete the following information):

• OS: Windows 10 Pro x64
• OS Version: v20H2 (10.0.19042)

Newest FFmpeg makes our parser fail while reading data, resulting in exception.

Describe the bug
App not running

How To Reproduce
Open up the exe

Screenshots

Include latest log file
log-20221128182635.txt

Desktop (please complete the following information):

• OS: [Windows]
• OS Version: OS Build 19044.2251 Version 21H2

From sdk

Hi,

is there any way to chose which output format should be used? It would be cool to be able to tell ffmpeg to e.g. output .m4a or .ogg files, which often means tracks pulled from Youtube don't need to be converted. I tried going through the code to find where Spotisharp is telling ffmpeg explicitly to create mp3 files, but could not pinpoint where that happens - does the conversion happen because the output file path given to ffmpeg end with .mp3?

Hi
Sometimes gets songs downloaded from Spotify wrong, or calculates the duration incorrectly.
Sometimes it's 11 minutes, sometimes 20 seconds.
This happens especially with large playlists.
Thanks

Describe the bug
Getting this error by youtube when trying to download some songs.

How To Reproduce
(in cmd) SpotiSharp.exe https://open.spotify.com/track/274tSPavv09i163nBnYrCU?si=2I7lhKahSlGWC7gKdQr-ww

Desktop (please complete the following information):

• OS: Windows 10 Pro

I know this could be hard to be fixed but it is more or less necessary because you can't download playlists completely if there is a song like this inside.
(sorry for my poor english :D)

Describe the bug
Trying to download a playlist it would crash at the same song each time. Trying to download the song by itself, it crashed as well.

How To Reproduce
Use this song:
https://open.spotify.com/track/3iINfVB6kucFrmMRWdLMWS?si=93a9f68c06ea40bd

Include latest log file
log-20231018085552.txt

Desktop (please complete the following information):

• OS: Windows 10

Subscribe to this event to keep track of incomming changes

Pending.

Finished

• Rewrite
• Configuration Rework
• Linux Support
• Albums Support
• Playlist Support
• Lyrics Support
• Spotify URL Support
• Metadata (Artist's, Album Art, Lyrics, etc.)
• Check Version

Describe the bug
The application crashes after all tasks are finished.

I use pihole adblocker I am blocking youtube ad servers. Here is a link to the domains I am blocking: https://raw.githubusercontent.com/Lewis-Fam/pihole_adlists/main/youtube_ads_blocklist.txt

--- Message ---
The requested name is valid, but no data of the requested type was found. (rr3---sn-qxoedne7.googlevideo.com:443)

How To Reproduce
Crashes on playlists and albums. I didn't test tracks.

Include latest log file
..
....
......
[2022.09.09 19:40:32] [Debug]: W #2 ::: Finished current task ::: Case Point - Savage
[2022.09.09 19:40:32] [Info]: W #2 ::: Skipping: Tut Tut Child - Fat Cat Adventures
[2022.09.09 19:40:33] [Info]: W #2 ::: Skipping: Noisia - Mundus Theme
[2022.09.09 19:40:33] [Info]: W #2 ::: Skipping: Adventure Club - Gold (feat. Yuna)
[2022.09.09 19:40:33] [Info]: W #2 ::: Skipping: Knife Party - Kaleidoscope
[2022.09.09 19:40:34] [Info]: W #2 ::: Finished all tasks
[2022.09.09 19:40:34] [Debug]: W #1 ::: Downloading ::: Linkin Park - LOST IN THE ECHO - KillSonik Remix
[2022.09.09 19:40:37] [Debug]: W #1 ::: Converting ::: Linkin Park - LOST IN THE ECHO - KillSonik Remix
[2022.09.09 19:40:42] [Debug]: W #1 ::: Adding metadata ::: Linkin Park - LOST IN THE ECHO - KillSonik Remix
[2022.09.09 19:40:42] [Debug]: W #1 ::: Finished current task ::: Linkin Park - LOST IN THE ECHO - KillSonik Remix
[2022.09.09 19:40:42] [Info]: W #1 ::: Finished all tasks
[2022.09.09 19:40:42] [Error]: Application crashed!

--- Message ---
The requested name is valid, but no data of the requested type was found. (rr3---sn-qxoedne7.googlevideo.com:443)

--- Helplink ---

--- Source ---
System.Net.Http

--- StackTrace ---
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(HttpRequestMessage request)
at System.Threading.Tasks.TaskCompletionSourceWithCancellation1.WaitWithCancellationAsync(CancellationToken cancellationToken) at System.Net.Http.HttpConnectionPool.GetHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken) at Spotisharp.Client.Services.YoutubeService.GetSize(String url) in W:\Daddy\Documents\dev\Spotisharp\Spotisharp.Client\Services\YoutubeService.cs:line 109 at Spotisharp.Client.Services.YoutubeService.GetStreamAsync(String url, IProgress1 progress) in W:\Daddy\Documents\dev\Spotisharp\Spotisharp.Client\Services\YoutubeService.cs:line 62
at Program.<>c__DisplayClass0_0.<<

--- TargetSide ---
Void MoveNext()

Windows 10 and 11.

I am able to resolve the crash by disabling pihole adblocker.

Describe the bug
I get the following crash report when trying to use Spotisharp. I have tried using individual song links, entering the song via string, and playlist links from Spotify and they all fail.
See the log below:

How To Reproduce

1. run Spotisharp
2. enter anything:

• "PNAU - Go Bang"
• https://open.spotify.com/track/57p8CBvPOxrvyCbn6ttl5r?si=b9ed5e4c8c254050

3. Press enter

Screenshots

Include latest log file
log-20240204112252.txt

Desktop (please complete the following information):

• OS: Windows 10
• OS Version: 10.0.19045 Build 19045

Youtube throttled download speed again. Working on a fix

Describe the bug
SpotiSharp will retrieve only first 100 tracks from a playlist which might have more than 100. The reason is Spotify API pagination and I think it should be added (maybe using PaginateAll from SpotifyAPI.Web)

How To Reproduce
Any playlist with more than 100 tracks

Desktop (please complete the following information):

• Windows 10
• build 10.0.19042

The '&' symbol is being removed from folders, and filenames.

Describe the bug
Trying to download a large playlist (>1000 tracks). Program throws the following exception:
"String is empty or null (Parameter 'albumId')"

for stacktrace see log file

How To Reproduce
playlist url:
https://open.spotify.com/playlist/0cBxH4OqNPVCWLjoRKGk16?si=0ecf1b4ea60544ff

Screenshots
Add screenshots to help explain your problem.

Include latest log file
log-20220620215436.txt

Desktop (please complete the following information):

• OS: Windows 10 21H2
• OS Version 19044.1766

Describe the bug
Slow download speed during track download.

How To Reproduce
Request any track.

Before
https://open.spotify.com/track/1V3mUG5cCiE8OwDFJLulwW (GOOD)

After
https://open.spotify.com/intl-pl/track/1V3mUG5cCiE8OwDFJLulwW?si=89160222a5a34db1&nd=1 (BAD)

Passing a direct url still works, however URL needs manual formatting to the previous design.

Describe the bug
This bug is caused by Spotisharp library.
This issue will be probably fixed soon.
Meanwhile i will try to play with other library to get it fixed right away.

Screenshots

Describe the bug
A clear and concise description of what the bug is.

Recently I have been getting wrong results with spotisharp or manually downloading songs from youtube
The title of the song is correct but the content is wrong.

How To Reproduce
Include song/playlist you was looking for.
E.g. [https://open.spotify.com/track/28HX0PibeXSL6cfAsvwSgD]

https://open.spotify.com/playlist/37i9dQZF1DXa41CMuUARjl
Song name : Shermanology - Motown Philly
Downloaded song : meyra - gözlerinde kim var

Screenshots
Add screenshots to help explain your problem.

Include latest log file
Log file can be found inside app directory. It should be named like: log-{Year}{Month}{Day}{Hour}{Minute}{Second}.txt

Desktop (please complete the following information):

• OS: [e.g. Linux, Windows] : windows
• Kernel [e.g. 4.15.0-39-generic] (Linux only)
• OS Version [e.g. 1809 build 17763.1577] (Windows only)

Describe the bug
Encoding is broken.

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu 22.04.3 LTS
• Kernel 5.15.0

On windows with dotnet 6, after the first downloads:

at Program.<>c__DisplayClass0_3.<

Describe the bug
Currently spotisharp doesn't work. Spotify updated the variable types and it's causing chaos on the SpotifyAPI side.
They fixed it, but we need to update to 7.1.1 here
https://github.com/L0um15/Spotisharp/blob/dev/Spotisharp.Client/Spotisharp.Client.csproj

The version:
https://github.com/JohnnyCrazy/SpotifyAPI-NET/releases/tag/7.1.1

The issue resolved:
JohnnyCrazy/SpotifyAPI-NET#942

How To Reproduce
try to download ANY song or playlist
https://open.spotify.com/track/6M7oa01tpOccJXkb9rUoH8?si=3963e586598643df

log-20240308223014.txt

where 320 kbps? i have premium on my account!

Originally posted by @evgeniy702 in #1 (comment)

Hi,
i have a Exception during downloading a playlist

playlist : https://open.spotify.com/playlist/37i9dQZF1E4yHPIesfGpbT
Song : Muhammad Al Muqit - The Way of the Tears

• OS: [Windows]
• OS Version [Win 10] (Windows)

tested these changes on my local branch and was able to download files (originally this would crash on any file attempt)
Note: noticed that the following error output exists (happens at the end of the download, so the file still exists and works fine):

Unhandled exception. System.Net.Http.HttpRequestException: Response status code does not indicate success: 404 (Not Found).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at System.Net.Http.HttpClient.GetStringAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
   at Spotisharp.Client.Services.MusixmatchService.SearchLyricsFromText(String query) in E:\Coding\Repos\Spotisharp.Client\Services\MusixmatchService.cs:line 14
   at Program.<>c__DisplayClass0_0.<<<Main>$>b__0>d.MoveNext() in E:\Coding\Repos\Spotisharp.Client\Program.cs:line 280
--- End of stack trace from previous location ---
   at Program.<Main>$(String[] args) in E:\Coding\Repos\Spotisharp.Client\Program.cs:line 132
   at Program.<Main>(String[] args)

Originally posted by @narutoshocker in #45 (comment)