Hello,

I just saw that Microsoft end his support for IE11 on 2022.
What is happening if an user doesn't have IE on his computer ?

Regards,

The HTML pages loaded into rpatchur's WebView will of course need to at some point use Javascript in button click handlers or whatever else to perform actions, and that means calling external.invoke() as per your own examples (e.g. /examples/basic_launcher/index.html found in this repository).

I believe this WebView integration is broken on non-Windows OS's.

On my Gentoo Linux PC, I was having issues running an rpatchur installation with no visible error. Debugging it via CLion, I saw this error pop up:

https://koko.z13.web.core.windows.net/js/jquery-3.4.1.slim.min.js:2:31216: CONSOLE WARN jQuery.Deferred exception: Can't find variable: external @https://koko.z13.web.core.windows.net/live/index.html:35:21
e@https://koko.z13.web.core.windows.net/js/jquery-3.4.1.slim.min.js:2:29662
@https://koko.z13.web.core.windows.net/js/jquery-3.4.1.slim.min.js:2:29960 undefined

With the most important bit being obviously the Can't find variable: external bit which it encountered when running this line found in the mentioned index.html

external.invoke('start_update');

I was able to fix this by replacing all calls to external.invoke() with window.webkit.messageHandlers.external.postMessage() instead. This obviously will not work when the WebView is being backed by IE on Windows, so a suitable cross-platform solution would be nice here!

adding logging, it hangs at line 240 of core.rs

let mut shared_state = shared_state.lock().await;

if a patch fail, it can try another patch server.

Description: The SSO Login on rpatchur makes the client crash, and it needs to be fixed and tested in newer clients to confirm if this still happens.
Client Version: 2015-09-16aRagexe
What rpatchur does: "-1rag1" "-t:password" "username" (results on a client crash)
What rpatchur should do -t:password username server -1rag1 (it works for me)
Additional Info: Where i found the correct param order

And is important to know that the commas are sent to the emulator too. So it fails because the server receives "username" and tries to find an account including the commas, tested on a 2018 hercules emulator.

I think patcher should be able to handle error when unable to connect to targeted url.

Either by

1. Default Error HTML page in patcher directory
2. Caching the last page

• Verify that web-view properly support this on all platforms
• Think of a way to replace the native title bar's functionalities (dragging, minimizing, etc.)

let's say if in plist.txt the latest is 2021 and the client last patch is 2020 it will show 2020/2021 and add config where user can set the last patch in client so can select to re-patch from specific number like jikari patcher didn't need to re-download entire plist.txt

GPF is actually just the GRF format IIRC, so using GrfArchiveBuilder::import_raw_entry_from_grf should work.

1. (updated) Ah nvm, I'm assuming it's so that after a lot of patches you don't need to store them all in a single plist.txt ? i.e. you can remove old patches and just start from the number where you left off.

(original question)

I was wondering why you chose to format plist as {idx} {file name} rather than infer the index based off the line number ? Basically I'm not understanding why you'd want an out of order plist e.g.

2 some-file.thor
1 other-file.thor

2. also do you mind explaining why you return none in the case of a failure instead of letting the error bubble up ?

Thanks

Through the configuration file.

Is it possible to patch GRF in subfolders?
For example:
I have grf in: system/data/data.grf
and thor patch with target grf: system/data/data.grf
When patcher try to apply, it show error
"Failed to apply patch 'xxx': Can`t find path."

rpatchur.yml
patch_url: http://myservername.com/patch/

plist.txt
1 luas/update.thor

with those config the patcher will result in Error
Failure: Failed to download patches: Failed to create temporary file: The system cannot find the path specified. (os error 3)

can we add a support for downloading inside a subfolder ?

Some users experience a patching (.thor file to .grf) error with the following message: "Failed to parse archive: Archive is malformed."
When they keep pushing refresh button it corrects itself. Can you please help what might be wrong?

I think patcher should able to open a url in default browser.
This is pretty basic feature, some may need.

external.invoke(JSON.stringify({
  function: 'open_url',
  url: 'https://ratemyserver.net'
}))

When windowconfig set to
resizable: false # Make the main window resizable

I think it should disable/hide maximize button.

libssl.so.1.0.0 is no longer standard in MacOS/LinuxOS, so we'll need to bump the rpatchur libssl version to a newer version.

Basically title

Using ShellExecuteEx instead of ShellExecute.

The builder can only generate GRF files in version 0x200 at the moment.

GRF files are re-created every time a patch is applied, which is not optimal in term of performance.

I've been having a rough time acclimating to rust since this project is my introduction to it

Anyhoo, I'm trying to view logs to debug an issue with the patches not being read in, but I can't get the logs to show. I can get logs to show in a separate little "hello world"ish rust program but this one the logs don't show up.

I've tried installing the exact same versions of log and simple_logger into your project as well as removing the max level feature declaration in cargo.toml and any level filters in your code. Still, in rpatchur/src/main.rs, when I just do

fn main() {
    SimpleLogger::new().init().unwrap();
    log::warn!("This is an example message.");
    ...

the logs don't show up in the command line

λ cargo build && cargo run -- -w C:\my-programs\buzzy-ro
   Compiling rpatchur v0.2.0 (C:\git-repos\cloned\rpatchur\rpatchur)
    Finished dev [unoptimized + debuginfo] target(s) in 3.00s
    Finished dev [unoptimized + debuginfo] target(s) in 0.16s
     Running `c:\git-repos\cloned\rpatchur\target\debug\rpatchur.exe -w C:\my-programs\buzzy-ro`

I would appreciate any direction you can give me.

Thanks for the tool

Allows for linear progress bars

Handle updating the patcher itself without needing to change its name and replacing it manually.

As like the title said, if possible to add a feature that we can patch multiple grf in one patcher,
so we might need multiple plist_url, and patch_url to identify each grf.

This just a suggestion, thank you for your hard work

It is desirable to expand patcher functionality to be able to source data assets from an azure data blob. This is desirable for these reasons:

• reduces bandwidth requirements/congestion on primary web server
• azure data blob is more suited to large / rapid file transfer than a web server

Unfortunately, due to the relative infancy of the Rust:Azure SDK, it would be recommended to postpone work in this area until the SDK becomes more stable to avoid future re-work.