l4u / nsdata-base64 Goto Github PK

I added your code to my project but I found this error:
PATH/NSData+Base64.m:293:6: ARC forbids explicit message send of 'autorelease'
I tried to refactor it but no way.

You can use -[NSData initWithBytesNoCopy: length: freeWhenDone:] method to avoid an unneeded memory copy and free(), like the following.

- (id)initWithBase64String:(NSString *)aString
{
    NSData *data = [aString dataUsingEncoding:NSASCIIStringEncoding];
    size_t outputLength;
    void *outputBuffer = NewBase64Decode([data bytes], [data length], &outputLength);
    return [self initWithBytesNoCopy:outputBuffer length:outputLength freeWhenDone:YES];
}

NSString *dataBaseString = [[@"qwertyuiopqwertyuiopqwertyuiopqwertyuiopqwertyuiop" dataUsingEncoding:NSASCIIStringEncoding] base64EncodedString];

log:
dataBaseString :cXdlcnR5dWlvcHF3ZXJ0eXVpb3Bxd2VydHl1aW9wcXdlcnR5dWlvcHF3ZXJ0eXVp
b3A=

i think it happens because the length of the origin string.

If the input string contains no valid base64 data, this routine will crash. For instance: if the input is a string containing just spaces (and thus no valid base64 data), then NewBase64Decode() returns a valid pointer but an invalid (-1) length. dataFromBase64String() subsequently tries to allocate a NSData block of size (-1), which crashes. This situation should be checked for and handled appropriately.