ladjs / dayjs-with-plugins Goto Github PK

Not working because
node_modules/.pnpm/[email protected][email protected]/node_modules/dayjs-with-plugins/lib/index.js

You defined process here

There are no types available in this package and @types/dayjs-with-plugins is also not available.

Do you not consider TS relevant, or are you expecting people to somehow reuse the original types from dayjs?

This project is great and worked out of the box.

However, please consider removing BadMutable from the list of plugins.

It breaks the immutability of dayjs objects:

// node.js
const dayjs = require('dayjs-with-plugins') // introduces mutability
//const dayjs = require('dayjs') // uncomment to compare

const now = dayjs();
const tomorrow = now.add(1, 'day');

console.log(now); // << might not be expect

I assume BadMutable is just one of the plugins and it's just there but as it changes such a fundamental concept of dayjs that it would be nice to get at least a little hint.

Personally I would vote to drop the plugin.

• iamkun/dayjs#1041
• iamkun/dayjs#1039