i was using 0.0.1 with node, it suddenly does not npm install anymore.

i trust your work, so that's what i picked superagent ... however what you recommend, to port my code to work with 0.1.1 or to use another library, if the latter which one you suggest

b3abd64

i was getting TypeError: Object # has no method 'data'

how hard would it be for superagent to run on node ?

make it less ugly

opt-in

Hi,

Trying to send this to neo4j, and it breaks some BadInput rest format (I cant understand from the log). Doing a cURL in their webadmin console get the results correctly, so i it might be something with the library/superagent ? Can i use ? in the url and i guess the properties json is ok as well ?

request
.post('http://localhost:7474/db/data/index/node/users?unique')
.set('Content-Type', 'application/json')
.set('Accept', 'application/json')
.send({"key": "name", "value": "myname", "properties": {"name": "myname", "pass": "dd7f89ad79f"}})
.end(function(res){
if (res.ok) {
console.log('yay got ' + JSON.stringify(res.body));
} else {
console.log('Oh no! error ' + res.text);
}
});

It should be noted that i can send other json requests to the server, more simple key values not nested ones.

Thanks for a great nodejs extension!

for now to keep things simple we'll just add everything in to increase adoption however even the internals could/should utilize some form of plugin system, interacting with various events

agent
.ssl()
.host('localhost')
.port(3000)
.post('/action');

Using this it would be reuse same agent with another action of same host:

var base = agent.ssl(). host('localhost').port(3000);

base.post('/action1');
base.post('/action2'); // reuse same agent with another action of same host

Error when trying to run 'npm install superagent' with node 0.5.0-pre installed.

node# npm install superagent
npm ERR! Unsupported
npm ERR! Not compatible with your version of node/npm: [email protected]
npm ERR! Required: {"node":"0.4.x"}
npm ERR! Actual: {"npm":"1.0.6","node":"v0.5.0-pre"}
npm ERR!
npm ERR! System Linux 2.6.38-8-virtual
npm ERR! command "node" "/usr/local/bin/npm" "install" "superagent"
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR! /root/node/npm-debug.log
npm not ok

Any way for me to fix this or do I just need to wait for the next version of superagent?

Thanks for the great module, by the way!

Shawn

You are missing a } in the doc example:

request
  .get('/search', { query: 'tobi the ferret', function(res){

});

And a ' in:

request.post('/user')
  .set('Content-Type', 'application/json')
  .data('{"name":"tj","pet":"tobi"})
  .end(callback)

something like request(app).get('/').... this would make it trivial for testing apps with superagent, and then use SA for Express tests :) when the app is not listening just bind to an ephemeral port and defer. perhaps this should be an extension somewhere else

Seems I pushed you into a new release too soon and now the the redirect following is broken :/
It will just do nothing when it finds a redirect page, callback never fires.

@guille found this bug:

request('localhost'...

for example will fail, default it to http

When using

.send({...})

superagent is converting it into json but when using

.send([{...}, {...}])

superagent is not converting it into json. I have to do:

.send(JSON.stringify([{...}, {...}]))

A missing feature?

self-explanatory

RW stream

to match node

Superagent cannot handle Array as data parameter. In node.js, it throws this error:

TypeError: Second argument should be a buffer
  at Socket._writeImpl (net.js:159:14)
  at Socket._writeOut (net.js:444:25)
  at Socket.flush (net.js:523:24)
  at Socket._onWritable (net.js:603:12)
  at Socket._onConnect (net.js:591:12)
  at IOWatcher.onWritable [as callback] (net.js:186:12)

In the browser there is a problem with the JSON serialization: if the data parameter is [1,2,3], the data sent is "1,2,3" instead of "[1,2,3]"

If I use superagent with node the EventEmitter is not defined in lib/superagent.js. Obvious because it's in events.js and index.js only requires lib/superagent.js. Perhaps the index.js should require the superagent.js in the toplevel? Apart from that if i try to require superagent.js at the toplevel nothing gets exported.

Would be nice if you could fix the node part. Looks very promising! Thx for your work.

According to http://visionmedia.github.com/superagent/ and https://github.com/visionmedia/superagent/blob/master/Readme.md you can use the method data in conjunction with method post. According to the actual code and tests the method is send. The method send worked for me. Otherwise, much better than jQuery Ajax!

res.res is super lame

agent.get('http://google.com', { search: 'foobar' }, function(err, res, body){
// whatever
});

agent.get('http://google.com', function(err, res, body){
// whatever
}).query({ search: 'foobar'}) ;

Also what about parametrized urls?

agent.get('http://google.com/method/:id').query({id:3})

Could basic auth support be added so I could do something like:

request
  .get(...)
  .username()
  .password()
  .end(...);

to match connect.bodyParser(), in fact we should just use connect's implementations

on econnrefused etc, exponential falloff or similar

some way to stub out common settings etc that you've chosen for your app, opt-in

Hey TJ, I love Superagent because for the most part it's the same API in the browser as it is Node. Less of a mental context switch. However, the Node version and the Browser version are different.

I'd be happy to try to help clean some of this up with pull-requests. (with tests of course) So, let's start with a simple one first. Encoding of forms. In the browser you use form-data in Node it's form. As seen by:
https://github.com/visionmedia/superagent/blob/master/lib/node/index.js#L76 vs
https://github.com/visionmedia/superagent/blob/master/lib/superagent.js#L145

Since form-data was a more recent change, I assume you like this more?

Thanks,

JP

Running make doesn't do anything. How do I build this darn'd thing? O.o

[JD-i7-iMac:superagent JD]$ make -f Makefile
make: Nothing to be done for `all'.

Just so we're on the same page... this IS a script for making ajax calls in the browser, right? i.e., not just in node?

Any way to make the request synchronous as opposed to asynchronous ?

As in I want the request to fully complete, and callback executed before it runs the next command...

request.get 'http://myurl/', (req, res)->
  text = res.text
console.log text

Also off-topic, but is req suppose to return 'null' ? it is for me. (using this on Node.)

Thanks.

When I run:

request = require "superagent"
request
  .get("http://localhost:81")
  .end((res) ->
    console.log res
  )

I get a "res" that is null

Am I missing something?

UPDATE: Oh, the first one is for error. Time to update the doc :)

something like:

request.post('/video')
  .type('mixed/related; boundary=---')
  .part()
    .set('Content-Type', 'application/xml')
    .data(metadata)
  .part()
    .set('Content-Type', 'video/webm')
    .set('Content-Length', stat.size)
    .data(fs.createReadStream(path))
  .end(callback)

auto-assign boundary when mixed/*:

request.post('/video')
  .type('mixed/related')
  .part()
    .set('Content-Type', 'application/xml')
    .data(metadata)
  .part()
    .set('Content-Type', 'video/webm')
    .set('Content-Length', stat.size)
    .data(fs.createReadStream(path))
  .end(callback)

support nesting

What the title says. Is this on purpose? If so it should be mentioned in the readme because it is confusing.

I get the following error when I use the post method. Not sure what I am doing wrong:

node.js:134
throw e; // process.nextTick error, or 'error' event on first tick
^
Error: socket hang up
at Socket. (http.js:1271:45)
at Socket.emit (events.js:64:17)
at Array. (net.js:825:12)
at EventEmitter._tickCallback (node.js:126:26)

var sender = agent.post('http://localhost:8080/mockService');
sender.form({
channelID: channelID,
tileText: tileContent
});
sender.end();

Any ideas?

no point duplicating this all the time

Hi!

Please, consider taking care of those who behind proxies ;) Say, https://github.com/dvv/F/blob/master/lib/wget.js

TIA,
--Vladimir

dont think i ported it

re-use as much as possible or at least make them look the same so it's simple to maintain. maybe ?grep=@browser

I encountered a couple of an odd behavior when dealing with special parameters and form-data. Here is the source code:

var superagent = require("superagent");
var fs = require('fs');

var req = superagent.get("http://example.com/test?abc=def");
req.request().assignSocket(fs.createWriteStream("./rwparams.txt"));
req.end();


var req = superagent.post("http://example.com/test?abc=def");
req.type('form-data')
req.data({"a":"1","b":2})
req.request().assignSocket(fs.createWriteStream("./rwparams2.txt"));
req.end();

Output of rwparams.txt:

GET /test HTTP/1.1
Host: example.com
Connection: close

The parameter "abc=def" is just gone.

Output of rwparams2.txt:

POST /test HTTP/1.1
Host: example.com
Content-Type: application/x-www-form-urlencoded
Content-Length: 5
Connection: close

a=1&b

the variable "b" no longer has a value. At least it could throw an error that it has invalid input.

GET defaults .send() to this method