laidig / gtfs-validator Goto Github PK

While trying to build the laidig_webapp, using command 'component build', it is giving an error saying that there is no remote dependency found for latest version of jashkenas/backbone

Hi

Seems like the check for multiple timezones does not work properly. Im getting this output:

Exception in thread "main" java.lang.IllegalArgumentException: File contains two time zones, which is not allowed by the GTFS spec
    at com.conveyal.gtfs.service.CalendarDateVerificationService.<init>(CalendarDateVerificationService.java:82)
    at com.conveyal.gtfs.validator.ValidatorMain.main(ValidatorMain.java:70)

The agency.txt file contains multiple agencies but they are all in the same timezone as seen here:

Used feed: http://gtfs.ovapi.nl/new/archive/NL-20170119.gtfs.zip

Kind regards
Simon

Hi

I've found another small problem.

Right now the validator exits with status code 0 when the specified GTFS feed is not found.
Same for when you do not specify the file at all.
In both situations a non-zero value should be returned as exit code.

Command:

java -jar gtfs-validator.jar /data/non-existing-feed.zip

Error message:

Reading GTFS from /data/non-existing-feed.zip
Could not read file /data/non-existing-feed.zip; does it exist and is it readable?

Returned statuscode: 0

Command:

java -jar gtfs-validator.jar

Error message:

Usage: gtfs-validator /path/to/gtfs.zip

Returned statuscode: 0

Kind regards
Simon

We are actually trying to use gtfs-validator-webapp in the project https://github.com/CUTR-at-USF/gtfs-realtime-validator and we encountered with this problem while trying to view output json file from a web server for example, 'localhost:8080/laidig_webapp/index.html?report=http://localhost:8080/out.json'.

This throws an error ''Only local reports may be viewed, message: Please specify a local report to view''.
As gtfs-validator-webapp does not allow json reports containing '://' in the report parameter value (as shown in above example i.e., http://localhost:8080/out.json), Is that fine to reconsider the decision to allow the report parameter to contain '://'

Here is the condition in validation.js file that does not allow paths with '://'

if (params.report.indexOf('//') == 0 || params.report.indexOf('://') != -1) {
new ErrorView({
model: new ErrorModel({title: 'Only local reports may be viewed', message: 'Please specify a local report to view'})
}).render().$el.appendTo('#content');
return;
}

Hi

I've noticed the validator crashes when the calendar.txt file is empty (just containing the headers).

Stacktrace:

Exception in thread "main" java.lang.NullPointerException
    at java.util.Calendar.setTime(Calendar.java:1770)
    at org.onebusaway.gtfs.model.calendar.ServiceDate.getCalendarForDate(ServiceDate.java:298)
    at org.onebusaway.gtfs.model.calendar.ServiceDate.<init>(ServiceDate.java:89)
    at com.conveyal.gtfs.service.CalendarDateVerificationService.<init>(CalendarDateVerificationService.java:55)
    at com.conveyal.gtfs.validator.ValidatorMain.main(ValidatorMain.java:70)

File used:
http://gtfs.irail.be/nmbs/nmbs-2016-12-1.zip

I don't know whether this is a valid GTFS format or not, but the validator shouldn't crash on this I suppose.
Could you check this out please?

Kind regards
Simon