laminas / laminas-pimple-config Goto Github PK

Feature Request

Summary

To be prepared for the december release of PHP 8.0, this repository has some additional TODOs to be tested against the new major version.

In order to make this repository compatible, one has to follow these steps:

• Modify composer.json to provide support for PHP 8.0 by adding the constraint ~8.0.0
• Modify composer.json to drop support for PHP less than 7.3
• Modify composer.json to implement phpunit 9.3 which supports PHP 7.3+
• Modify .travis.yml to ignore platform requirements when installing composer dependencies (simply add --ignore-platform-reqs to COMPOSER_ARGS env variable)
• Modify .travis.yml to add PHP 8.0 to the matrix (NOTE: Do not allow failures as PHP 8.0 has a feature freeze since 2020-08-04!)
• Modify source code in case there are incompatibilities with PHP 8.0

Good morning,

I've the following configuration:

    // Container configuration
    'dependencies'      => [
        'invokables' => [
            CommandBus::class => SimpleCommandBus::class,
        ],
        'factories'  => [
            EventBus::class                  => EventBusFactory::class,
            EventStore::class                => EventStoreFactory::class,
            PhpVersionRepository::class      => PhpVersionEventStoreRepositoryFactory::class,
            PhpVersionCommandHandlers::class => PhpVersionCommandHandlersFactory::class,
        ],
        'delegators' => [
            CommandBus::class => [
                PhpVersionCommandBusDelegatorFactory::class
            ]
        ]
    ]

Problem is that when I get the Command::Bus service, the PhpVersionCommandBusDelegatorFactory isn't invoked.

However, the following works:

    // Container configuration
    'dependencies'      => [
        'invokables' => [
            CommandBus::class => SimpleCommandBus::class
        ],
        'factories'  => [
            EventBus::class                  => EventBusFactory::class,
            EventStore::class                => EventStoreFactory::class,
            PhpVersionRepository::class      => PhpVersionEventStoreRepositoryFactory::class,
            PhpVersionCommandHandlers::class => PhpVersionCommandHandlersFactory::class,
        ],
        'delegators' => [
            SimpleCommandBus::class => [
                PhpVersionCommandBusDelegatorFactory::class
            ]
        ]
    ]

Why there is no alias matching there?

Originally posted by @nuxwin at zendframework/zend-pimple-config#12

Feature Request

Summary

As decided during the Technical-Steering-Committee Meeting on August 3rd, 2020, Laminas wants to implement vimeo/psalm in all packages.

Implementing psalm is quite easy.

Required

• Create a .psalm.xml.dist in the project root
• Copy and paste the contents from this psalm.xml.dist
• Run $ composer require vimeo/psalm
• Run $ vendor/bin/psalm --set-baseline=psalm-baseline.xml
• Add a composer script static-analysis with the command psalm --shepherd --stats
• Add a new line to script: in .travis.yml: - if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
• Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

Optional

• Fix as many psalm errors as possible.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency phpunit/phpunit to v10
• Lock file maintenance

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Bug Report

Summary

In my opinion this clone for aliased non shares services is dangerous:
the return type can be any type not only clone able objects.

https://github.com/laminas/laminas-pimple-config/blob/master/src/Config.php#L206

https://www.php.net/manual/en/reflectionclass.iscloneable.php

Hello, I noticed that a new PsrContainer is created for every factory, extension and delegator. Wouldn't it make more sense to have configureContainer use an unique PsrContainer injected as 2nd argument?

        //...
        $container = new Container();
        $psrContainer = new PsrContainer($container);

        $config->configureContainer($container, $psrContainer);

        return $psrContainer;
        //...

kind regards