laniksj / slack-dark-mode Goto Github PK

Include functionality to revert back to light mode.

To Reproduce
Click 'Direct Messages' to search for someone to message
Click on anyone to message

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu 19.04
• Slack Version: 4.0

Whenever I restart my computer the local-settings.json file reverts the bootsonic from "never" back to "once", which breaks the dark mode theme. As soon as I update it to "never" and then restart slack, the dark mode theme begins working again.

Is your feature request related to a problem? Please describe.
I came across this; http://osxdaily.com/2018/11/15/automatic-dark-mode-macos-schedule/ and think it may be nice to switch to light mode at day time, and dark mode at night time. However that's not so easy with this Slack hack.

Describe the solution you'd like
I would like to be able to easily switch between Light/Dark mode via some command

As for a trigger we could maybe watch a file, but the question is then how to load/unload the theme :)

Describe the bug
I can't figure out how to toggle dark mode. I'd like light mode during day and dark mode at night. Either needs more docs or the feature itself.

To Reproduce
Try to toggle dark mode.

Expected behavior
Clear option for toggling dark mode.

Running the script on macOS gives the following error

sed: 1: "/Users/mikeyb/Library/A ...": invalid command code m

execution continues and it looks like the theme is applied correctly, but I guess something isn't getting replaced here?

Describe the bug
When you search a new to send a new Direct Message, and then mouse over a list entry, the backgorund color is still light.

To Reproduce
Steps to reproduce the behavior:
1. Go to 'Direct Message (+)' to start a new DM
2. Type in a name of someone to message
3. Mouse over any list entries and observe the incorrect color

Expected behavior
It should be a dark background color

Screenshots

Desktop (please complete the following information):

• OS: macOS
• Slack Version: 4.0.1

Additional context
N/A

I tried to use command prompt and git bash but I am getting bash: .slack-dark-mode.ps1: command not found in git bash and when I do the same in command prompt it opens the file in notepad.

Anything I'm missing?

Describe the bug
The top bar of Slack isn't styled when the script is run.

To Reproduce
Steps to reproduce the behavior:
1. Clone the repo.
2. Run the script.
3. Restart Slack.
4. See that the header and message box aren't styled as dark.

Expected behavior
The header and message box should also be styled.

Screenshots

Desktop (please complete the following information):

• OS: 10.14.4
• Slack Version: 4.0.0

Is your feature request related to a problem? Please describe.
The sidebar and chat window are the same color. In the picture you provide in the readme, they are not and it looks much better that way as it is far easier to distinguish between fields

Describe the solution you'd like
Make the sidebar a different color from the chat

Describe alternatives you've considered
manually altering the CSS file by looking at older versions and putting those changes back in

Additional context
see the screenshot in the readme

Describe the bug
If Slack is experiencing an outage it tells you in the app. Unlikely, that is not really working when you have this applied.

To Reproduce
1. Wait for Slack to have an outage. 🤷‍♂

Expected behavior
Background should be black.

Screenshots

Desktop (please complete the following information):

• OS: Mojave 10.14.6
• Slack Version: 4.0.0

Describe the bug
Formatting broken after #10

To Reproduce
Steps to reproduce the behavior:
1. Open dark-theme.css in Text Editor
2. It's not sorted and separated by spaces

Expected behavior
No line breaks and sorted alphabetically

Desktop (please complete the following information):

• OS: macOS
• Version 10.14.3

Describe the bug
I found a couple areas where the black text is slightly hard to read due to black text on a dark background.

To Reproduce
At the top left, open the dropdown for your workspace profile

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Ubuntu 19.04
• Slack Version: 4.0

Describe the bug
Slack no longer starts after installing dark mode.

To Reproduce
Steps to reproduce the behavior:

1. checkout slack-4.0 branch
2. install
3. restart Slack
4. only see Slack Quote at startup, then stuck

Expected behavior
Dark theme loads and slack loads

Desktop (please complete the following information):

• OS: macos 10.14.5

Installed Brew and Node (from within Brew), edited bootSonic to never, and ran 'sudo ./slack-dark-mode.sh -u' and it runs to completion with no errors but when I open Slack it still has white conversations :( (Running Slack 4.0.1 on MacOS 10.14.6) Thanks for any pointers.

Is your feature request related to a problem? Please describe.

Currently, the only version of Slack available for download from https://slack.com/downloads/mac is version 3.4.2. Some people have not yet been able to upgrade to version 4.0.0. This version of the slack-dark-mode.sh theme installation script does not support previous versions.

Describe the solution you'd like

I would like to check for the installed version of the Slack application, and apply a programmatic decision branch for which installation procedure to use.

Describe alternatives you've considered

It is possible that Slack will not distribute 3.4.2 at all for very much longer. Nevertheless, I think it is important to include backwards compatibility for those users who have been unable to upgrade for some reason. For instance, some enterprises tightly control what software is used on their systems. On the other hand, running this installation script on such systems may not work at all, since sudo/root privileges are required.

don't work at v-4.0.0 (macOS mojave)

Describe the bug
Dark on dark is hard to read

To Reproduce
Steps to reproduce the behavior:

1. copy a github link into the conversation
2. find that the text 'github' is too dark to read. (the icon is also not great to read)

Expected behavior
The text is properly readable

Screenshots

Desktop (please complete the following information):

• OS: MacOS 10.14.5

Describe the bug
All drop-down boxes in the app are still in the light theme.

To Reproduce
Steps to reproduce the behavior:
1. Go to 'Settings'
2. Click on 'Language and Region'
3. Open the drop-down box for the 'language selection'

Expected behavior
It should have a matching dark theme.

Screenshots

Desktop (please complete the following information):

• OS: macOS
• Slack Version: 4.0.1

Additional context
N/A

Code snippets do not take up the full width of the screen.
In fact they take up a little less than half in width even if the code itself is wider - causing text wrapping.

Describe the bug
Dark Mode is gone in Slack 3.3.8-beta1

To Reproduce
Steps to reproduce the behavior:
1. Open Slack
2. No Dark Mode

Expected behavior
Slack should turn Dark.

Screenshots
N/A

Desktop (please complete the following information):

• OS: MacOS Mojave
• Version 10.14.3

Sorry for my english, brazilian typing hehe.

Describe the bug
When you share(or mentions) a message, the name of the author of the message is displayed with font in dark color), and with dark background too is not easy to see the name of the author.

To Reproduce
Steps to reproduce the behavior:
1. Send a message
2. Mentions this message (Share)
3. The author of the mentioned message is displayed, but it's hard to see his name

Expected behavior
Is expected that the name of the author of the messages will be easier to see.

Screenshots

Desktop (please complete the following information):

• OS: (e.g. macOS) - Ubuntu 19.04
• Slack Version (e.g. 3.0) - Produção 4.0.0 64-bit

Is your feature request related to a problem? Please describe.

I think that the warning about root comes too late in the slack-dark-mode.sh script, and results in the attempt to modify protected files. Under ideal conditions, this is harmless. But I feel it is programmatically a best practice to include an automatic root check for a script that will require admin privileges in order to modify write-protected files, very early on in the program's execution.

Describe the solution you'd like
I'd like to check for root privileges early in the execution of the program, and abort execution if the executing user does not have root privileges.

Describe alternatives you've considered
An alternative would be to refuse to operate on a system-wide installation of Slack either in a MacOS or Linux environment, and instead insist that the Slack application be installed in the user home $HOME/Applications directory, instead. This way, this theme installation script can be ran without requiring escalated/admin privileges.

Is your feature request related to a problem? Please describe.
When typing an Emoji (start typing a :) & when tagging people (start typing @) and the box that opens has a white background. Anyway to get that to be dark?

Describe the solution you'd like
Emoji & tagging people have a dark background.

I was on a Slack call today and needed to change my audio settings to get my mic working. Noticed the following:

• The mic icon to get to audio settings was all 1 color, rather than 2 tone
• The dropdowns within audio settings (mic, speaker, etc.) were light gray text on white background. So pretty hard to read.

Other than that, this project is awesome! Thank you!

Is your feature request related to a problem? Please describe.
I am a part of multiple workspaces (as I'm sure most slack users are) and like to use different sidebar color schemes, to easily distinguish them. The dark mode CSS overrides the sidebar colors, so that only the header part and the workspace switcher use the chosen colors.

Describe the solution you'd like
Having a command line argument to choose if the sidebar colors should be overwritten or not would be great, to allow for more customization!

Describe the bug
Running ./slack-dark-mode.sh does the usual stuff but there's no effect on the Slack window at all - it's still white.

Desktop (please complete the following information):

• OS: macOS Mojave 10.14.5
• Slack Version: v4.0.0 (from the App Store)

Describe the bug
Here are a couple of minor profile styling issues I found

To Reproduce
Click on someones name in chat, to open the preview
mouse over their name.

Then open their profile by clicking their name, and look at the ... on the right of the edit profile button

Desktop (please complete the following information):

• OS: Ubuntu 19.02
• Slack Version: 4.0

Describe the bug
Channel Previews are Still Showing Up White

To Reproduce
Steps to reproduce the behavior:
1. Go to channel you're not a member off
2. Open the channel with a preview

Expected behavior
Should be dark to match the theme.

Desktop (please complete the following information):

• OS: macOS
• Version: 10.14.3

Describe the bug
CSS is very messy and needs cleanup.

To Reproduce
Steps to reproduce the behavior:
1. Open dark-theme.css in Text Editor
2. It's not sorted and separated by spaces

Expected behavior
No line breaks and sorted alphabetically

Desktop (please complete the following information):

• OS: macOS
• Version 10.14.3

Describe the bug
Text of the labels in the create channel screen is unreadable because they are styled in black.

To Reproduce
Steps to reproduce the behavior:
1. Click on the create channel button

Screenshots

Desktop (please complete the following information):

• OS: macOS)
• Slack Version 4.0.1

Describe the bug
Script does not properly find or fix local-settings files to update bootSonic setting.

To Reproduce
run script, note that the file was not changed.

Expected behavior
bootSonic is set to "never"

Desktop (please complete the following information):

• OS: OS X 10.13.6 (probably the same on many)
• Slack Version 4.0.0

Additional context
Two causes for this;

1. OS X handles the expansion of ~ differently in places, and the space in "Application Support" complicates things. Separating the vars storing paths with these into 2 vars fixes it.
2. sed -i needs an arg.

PR forthcoming.

This is the error: Invoke-WebRequest : The underlying connection was closed: An unexpected error occurred on a receive.

But this is what the whole error is:
`Invoke-WebRequest : The underlying connection was closed: An unexpected error occurred on a receive. At C:\Users\kgonzales\Documents\slack-dark-mode\slack-dark-mode.ps1:46 char:1

• Invoke-WebRequest -UseBasicParsing -Method GET -Uri $CSSUrl | Select- ...

•   + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebExc
   eption
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand`
  
  
  
  

Although in unpacks and installs just fine, upon launching Slack it is still on light mode.

EDIT: It seems the code doesn't format well, the whole message is seen in the screenshot

Describe the bug
I run script done and restart slack but it's not effective

• OS: 10.14.5
• Slack Version: 4.0.0

To Reproduce
Open main threads page

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu 19.04
• Slack Version: 4.0

Describe the bug
When you open the About Slack page, it's completely unusable.

I've uninstalled slack and reinstalled, then I added the dark mode, and it breaks only with dark mode enabled.

To Reproduce
(On Ubuntu 19.04 at least) - With dark mode enabled, go to Help -> About Slack

Expected behavior
This:

Screenshots
This is what happens:

Desktop (please complete the following information):

• OS: Ubuntu 19.04
• Slack Version: 4.0

Additional context
After additional testing before I submitted this issue, I found out that simply rebooting slack all together (as opposed to just using ctrl + r) fixed the issue. I'm going to submit this and close incase someone else has the same issue.

To Reproduce
In any chat channel, click on someone's username and view a preview of their profile.

minor
Also, when you open their profile on the side bar the ... to the right of 'Edit Profile' is hard to see.

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu 19.04
• Slack Version: 4.0

Describe the bug
The dark theme doesn't load when slack client launches. Javascript console shows that $ is undefined. I guess they used to ship jQuery with the slack app but don't anymore?

To Reproduce
Running this script for the first time, I find that it doesn't work.
I closed and reopened the slack app setting SLACK_DEVELOPER_MENU environment variable to access dev tools

export SLACK_DEVELOPER_MENU=true; open -a /Applications/Slack.app

right click anywhere on the (still light colored) screen, and select "inspect element" to bring up debug tools.
Javascript error console says $ is undefined, pointing to the following line:

    if (!err) {
      $("<style></style>").appendTo('head').html(css + tt__customCss);
    }

we're therefore unable to add the dark theme to the DOM.

Desktop (please complete the following information):

• OS: macOS
• Slack Version 4.0.0 (app store)

Describe the bug
Pins styling is not correct.

To Reproduce
Steps to reproduce the behavior:
Open 'pins' in any channel

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu 19.04
• Slack Version: 4.0

Describe the bug
When you open the "All unreads" tab, you cannot see the title of each conversation because it has a white background and a white title.

To Reproduce
Steps to reproduce the behavior:
1. Go to 'All unreads' tab

Expected behavior
Background should also be dark so the text can be read.

Screenshots

Desktop:

• OS: macOS Mojave
• Slack Version 4.0.0

Send text box section color is off. Please fix!

Describe the bug
Prefs Pane is Washed out White and Hard to Read

To Reproduce
Steps to reproduce the behavior:
1. Go to Slack
2. Click on Slack
3. Click on Preferences

Expected behavior
Colors Should be Inline With the Dark Theme

• OS: macOS
• Version: 10.14.4

Describe the bug
Extension actions have light background and text

To Reproduce
Steps to reproduce the behavior:

1. have an extension with actions post to a channel
2. find that the action buttons are light on light

Expected behavior
The text is dark or the button is dark instead.

Screenshots

Desktop (please complete the following information):

• OS: MacOS 10.14.5

When running slack-dark-mode.sh I get the following output:

sudo: npx: command not found

document.addEventListener('DOMContentLoaded', function() {
  const fs = require('fs');
  const filePath = "SLACK_DARK_THEME_PATH";
  const tt__customCss = '.menu ul li a:not(.inline_menu_link) {color: #fff !important;}'
  fs.readFile(filePath, {
    encoding: 'utf-8'
  }, function(err, css) {
    if (!err) {
      $("<style></style>").appendTo('head').html(css + tt__customCss);
    }
  });
});
sudo: npx: command not found

hi

in my mind, the window with channels pretty to do at black not on the silver

i tried to change to black at settings but i can't

or maybe u know to do this?

I think this one is obvious.

Any chance for getting an outline to perform these steps manually instead of executing a script? For instance, if some work organizations don't grant admin powershell execution rights then the script method won't work.

Screenshots