lapple / react-transitive-number Goto Github PK

Hey there, Aziz!

Would you consider adding optional prop alike numberClassName that will be added to each span tag containing number?

It's needed for applying css rules with text-gradient using this technique
as for now I have to specify it like > span > span > span which is non-optimal
considering how browsers parse css rules

It's easy to implement and shouldn't increase the file size significantly

Thanks! Great lib BTW

I have initial mounting to not animate, so when I later hit an additional digit, it just appears. :(

Would be great to have support of these formatters https://github.com/yahoo/react-intl as children

This component may cause all the following siblings to repaint, the live demo also suffers this issue.

Support React 15.0.1

With React 0.14.0 as a peer dependency, the package install will fail when React 0.13.x is installed. This is all ok but since it's been pushed to npm as a minor release, it's going to break the installs of people that use npm's default version operator (^).

For example, if the package.json says "react-transitive-number": "^1.1.0", 1.2.0 is going to be fetched but will break on install because of changes in peerDependency requirements. It's a big breakage for a minor release.

Options to solve this:

• do nothing and let people upgrade to 0.14 / pin their versions
• Release a 1.3 on React 0.13, and a 2.0 with React 0.14

0.14 was release yesterday but it seems like you didn't anticipate it.

npm ERR! peerinvalid Peer [email protected] wants react@^0.13.0

First off, this is a really cool effect! I'm new to react so I'm not really sure what the issue is; using React 16.2.

index.js:21 Uncaught TypeError: Cannot read property 'span' of undefined