Hi!
There is a each() deprecated function in the file MenuBuilder.php
It breaks the app partially because of no children menus are appended.

This is a request.

Prerequisites

• [ +] Are you running the latest version?
• [+ ] Are you reporting to the correct repository?
• [ +] Did you check the documentation?
• [+ ] Did you perform a cursory search?

Description

In documentation I've read that icons are in this path resources/assets/js/pages/layout/icons/app.js, but there is no "layout" folder inside /pages and don't know where can I add new icons for menu.

Thank you for your help!

Steps to Reproduce

Expected behavior

Actual behavior

We should add a publishable config

it's not necessary

Hi,
I try to follow the doc and include some new icons in new menu items, but unfortunately my tries are failed.

So, steps:

• I added new menu items
• I added icon name for the menu item, called boxes (variants I tried: boxes, Boxes, faBoxes, coffee, Coffee, faCoffee)
• I also added the icon name into the resources/assets/js/pages/layout/sidebar/icons/app.js (some variants, too):

import fontawesome from '@fortawesome/fontawesome';
import {
    coffee,
} from '@fortawesome/fontawesome-free-solid/shakable.es';
fontawesome.library.add([
    coffee,
]);

• as I can see, Enso uses fontawesome 4.7, right? (in this case, boxes will be missing as not part of 4.7)
• I try to find the icon name in the sourcecode, but I did not really figured out, how to add new icons (I guess, the name I try to use is not suitable somehow)

My question, where can I find a straightforward description, how to add new icons, what names I should use? Thanks!

This is a bug.

Prerequisites

yes

Description

Menu checking somehow shows menu entries that the user doesn't have permission for now

Steps to Reproduce

1. Have a menu structure with a child that a role doesn't have access to (f.e. foo.bar.index), being a child of a has_children foo menu
2. Log in as that user, the api/core/home request still returns this menu, even if the user doesn't have the permissions for that route

Expected behavior

TreeBuilder to only return menu items that the user(role) has access to

Actual behavior

Seemingly returning all menu items (from a brief glance system & admin is also returned)

Note: I have an overridden AppState (residing under App\Http\Responses) however I took over the updated AppState from the 3.3 upgrade and haven't changed any BE code related to the menutree; so that should be unrelated

This is a feature request.

Prerequisites

• Are you running the latest version?
• Are you reporting to the correct repository?
• Did you check the documentation?
• Did you perform a cursory search?

Description

How to setup a link in the menu.

Steps to Reproduce

I tried to add a new menu, and only allow me setup internal and predefined routes. I can't see any place to setup an URL.

Expected behavior

Setup a link, relative to same domain or external site.

Actual behavior

I can't do it.

Thanks!

This is a bug feature request.

Prerequisites

• Are you running the latest version?
• Are you reporting to the correct repository?
• Did you check the documentation?
• Did you perform a cursory search?

Description

resources/js/core/structure/menu/icons/app.js implies that all icon types can be used in the menu; however when inspecting the code there seems to be no way to actually define which prefix to use in the db entries.

Steps to Reproduce

1. include a non-fas prefixed icon (f.e. a brand icon)
2. add the corresponding fa... to the resources
3. Receive error during render, noting the fas prefix is used

Expected behavior

Icon to shop up // way to define prefix in the class entry, see Shorthand assumes "fas"

Actual behavior

Could not find one or more icon(s) 
{prefix: "fas", iconName: "<iconname>"}
 
{}

Suggested fix

Either split the Icon class key by spaces (I'm unaware of icons that take spaces); taking the first word as prefix if a space is detected (if not keep current behaviour)

Or Support json in the icon class field

I'd personally prefer the first option, making it look cleaner.

Hi,
when I try to insert a new menu voice, icon is missing in datatable and sidebar menu. I tried lots of fontawesome icons such as cloud, facebook, etc but only already known icons (such as cloud-upload-alt) are rendered in the Menu table and sidebar. What could I do to solve this? Thanks!