laravel-notification-channels / authy Goto Github PK

Laravel 8 has been released today and we need to update this repo to support it.
See https://laravel.com/docs/8.x/upgrade & laravel-notification-channels/channels#107

Hi @Omranic,

Nice work! I did a quick code review on this repo and made the following changes so this package works more or less the same as the others ones in our organization:

• added a static methodmissingCredentials in the InvalidConfiguration class
• the styleci preset has been set to laravel

In general think in general passing booleans to methods makes for less readable code. I've also changed the force method so that it doesn't take a bool anymore and added a dedicated method doNotForce that sets the force property to false.

Because of that change I've also removed the current 1.0.0 tags and added 0.0.1. Why? Because tagging something with a version less than 1.0.0 breaking changes are still allowed (and the force method change is breaking. Feel free to tag it as 1.0.0 if you feel it's ready now.

Your package is now registered on packagist, I've also added you as a member to the laravel-notification-channels.

If I've done anything you don't like or if there's anything I can do for you, reopen this issue.

Thanks again for your package. I'm pretty sure a lot of people will like it. 👍