Giter VIP home page Giter VIP logo

Comments (7)

drinkingkazu avatar drinkingkazu commented on July 30, 2024

Thanks for this report!

Just to be sure: we previously had an issue of this function not showing up in the dictionary (i.e. throws NameError for ProductName function as it does not exist). I just wanna make sure it is not related. When it doesn't work for you, is it a seg-fault?

from larcv.

coreyjadams avatar coreyjadams commented on July 30, 2024

It's not a seg fault. This is the error message I get when the return value is const std::string:

IncrementalExecutor::executeFunction: symbol '_ZN5larcv11ProductNameENS_13ProductType_tE' unresolved while linking symbol '__cf_10'!
You are probably missing the definition of larcv::ProductName(larcv::ProductType_t)
Maybe you need to load the corresponding shared library?
Error in <TClingCallFunc::make_wrapper>: Failed to compile
  ==== SOURCE BEGIN ====
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wformat-security"
__attribute__((used)) extern "C" void __cf_10(void* obj, int nargs, void** args, void* ret)
{
   if (ret) {
      new (ret) (const string) (larcv::ProductName(*(larcv::ProductType_t*)args[0]));
      return;
   }
   else {
      larcv::ProductName(*(larcv::ProductType_t*)args[0]);
      return;
   }
}
#pragma clang diagnostic pop
  ==== SOURCE END ====
Error in <TClingCallFunc::Exec(address, interpVal)>: Called with no wrapper, not implemented!
IncrementalExecutor::executeFunction: symbol '_ZN5larcv11ProductNameENS_13ProductType_tE' unresolved while linking symbol '__cf_14'!
You are probably missing the definition of larcv::ProductName(larcv::ProductType_t)
Maybe you need to load the corresponding shared library?
Error in <TClingCallFunc::make_wrapper>: Failed to compile
  ==== SOURCE BEGIN ====
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wformat-security"
__attribute__((used)) extern "C" void __cf_14(void* obj, int nargs, void** args, void* ret)
{
   if (ret) {
      new (ret) (const string) (larcv::ProductName(*(larcv::ProductType_t*)args[0]));
      return;
   }
   else {
      larcv::ProductName(*(larcv::ProductType_t*)args[0]);
      return;
   }
}
#pragma clang diagnostic pop
  ==== SOURCE END ====
Error in <TClingCallFunc::Exec(address, interpVal)>: Called with no wrapper, not implemented!
IncrementalExecutor::executeFunction: symbol '_ZN5larcv11ProductNameENS_13ProductType_tE' unresolved while linking symbol '__cf_15'!
You are probably missing the definition of larcv::ProductName(larcv::ProductType_t)
Maybe you need to load the corresponding shared library?
Error in <TClingCallFunc::make_wrapper>: Failed to compile
  ==== SOURCE BEGIN ====
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wformat-security"
__attribute__((used)) extern "C" void __cf_15(void* obj, int nargs, void** args, void* ret)
{
   if (ret) {
      new (ret) (const string) (larcv::ProductName(*(larcv::ProductType_t*)args[0]));
      return;
   }
   else {
      larcv::ProductName(*(larcv::ProductType_t*)args[0]);
      return;
   }
}
#pragma clang diagnostic pop
  ==== SOURCE END ====
Error in <TClingCallFunc::Exec(address, interpVal)>: Called with no wrapper, not implemented!
IncrementalExecutor::executeFunction: symbol '_ZN5larcv11ProductNameENS_13ProductType_tE' unresolved while linking symbol '__cf_16'!
You are probably missing the definition of larcv::ProductName(larcv::ProductType_t)
Maybe you need to load the corresponding shared library?
Error in <TClingCallFunc::make_wrapper>: Failed to compile
  ==== SOURCE BEGIN ====
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wformat-security"
__attribute__((used)) extern "C" void __cf_16(void* obj, int nargs, void** args, void* ret)
{
   if (ret) {
      new (ret) (const string) (larcv::ProductName(*(larcv::ProductType_t*)args[0]));
      return;
   }
   else {
      larcv::ProductName(*(larcv::ProductType_t*)args[0]);
      return;
   }
}
#pragma clang diagnostic pop
  ==== SOURCE END ====
Error in <TClingCallFunc::Exec(address, interpVal)>: Called with no wrapper, not implemented!
Traceback (most recent call last):
  File "mac/view_rgb.py", line 14, in <module>
    rgbdisplay = rgbd.RGBDisplay(sys.argv[1:])
  File "/home/cadams/LArCV/mac/pyrgb/display/rgbdisplay.py", line 158, in __init__
    for prod in self.dm.keys['image2d']:
KeyError: 'image2d'

I think we have both seen this before, Kazu, in a few places. By the way, the proposed modification also requires this change in IOManager:
std::string tree_name = std::string(ProductName(type)) + "_" + name + "tree";
std::string tree_desc = name + " tree";
std::string br_name = std::string(ProductName(type)) + "
" + name + "_branch";

from larcv.

coreyjadams avatar coreyjadams commented on July 30, 2024

What a useless last comment, unless I include the line numbers for thos changed lines:
Lines 182 and 184 of IOManager.cxx need to be modified to make the value of ProductName(type) a string to allow the '+' operation, I think.

from larcv.

drinkingkazu avatar drinkingkazu commented on July 30, 2024

Sounds great. Thanks for answering my question as well. It would be great if you can push.
Thanks!

from larcv.

twongjirad avatar twongjirad commented on July 30, 2024

Was this fixed recently?

from larcv.

coreyjadams avatar coreyjadams commented on July 30, 2024

Yes: 47ae9cc

from larcv.

twongjirad avatar twongjirad commented on July 30, 2024

Thanks! Closing.

from larcv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.