lars-sh / parent Goto Github PK

As prepared at https://github.com/lars-sh/lombok-annotations/blob/master/.travis.yml

Please configure the save action that they remove unnecessary semicolons.

• Maybe the tools should be integrated into the generate-resources phase to have them ready for every project.
• Alternatively offering the tools via a Maven profile.
• What about UNIX support?

Maybe m2e-code-quality is a good choice to simplify setting up Checkstyle, SpotBugs and PMD plugins?!

see https://github.com/rzwitserloot/lombok/wiki/WHY-NOT:-serialVersionUID

• Checkstyle check that fails in case serialVersionUID fields are present
• Suppress warnings about that field
  • Eclipse
  • Checkstyle
  • PMD
  • Spotbugs

Add resource functionality to get path to existing and non-existing resources

I'm really not a fan of the ++ operators, though it's a highly requested change. Therefore one might think about allowing one of the two ++ operators (either i++ or ++i) to be allowed as far as its return value is not used.

• XercesFeatures ( http://xerces.apache.org/xerces2-j/features.html )
• XercesProperties ( http://xerces.apache.org/xerces2-j/properties.html )
  • DocumentBuilderFactory
  • XMLReader
  • SAXParser
• XsltTransformerOutputProperties (XSLT 1.0: https://www.w3.org/TR/1999/REC-xslt-19991116#output , OutputKeys)
  • XSLT 2.0: https://www.w3.org/TR/2009/PER-xslt20-20090421/#serialization
  • XSLT 3.0: https://www.w3.org/TR/2017/REC-xslt-30-20170608/#serialization
• XalanTransformerOutputProperties (https://xml.apache.org/xalan-j/usagepatterns.html)
  • {http://xml.apache.org/xslt}:content-handler (type: class name, default varies between xml, html, text)
  • {http://xml.apache.org/xslt}:indent-amount (type: integer, default: 0, only xml and html)
  • {http://xml.apache.org/xslt}:entities (type: string, only xml and html, default varies)
  • {http://xml.apache.org/xslt}:use-url-escaping (type: boolean, default: yes, only html)
  • {http://xml.apache.org/xslt}:omit-meta-tag (type: boolean, default: no, only html)
• XalanTransformerFactoryFeatures (https://xml.apache.org/xalan-j/features.html#factoryfeature)
• XalanTransformerFactoryAttributes (https://xml.apache.org/xalan-j/features.html#factoryattribute)

And probably add a default config file to the parent POM.

To simplify overwriting settings the parent POM should use properties where possible.

See https://youtu.be/igbIAS6vlU8

Assign IDs to all Maven plugin executions for easier manipulation via children.

@NonNullByDefault has no effect in IDEA IntelliJ. Maybe @TypeQualifierDefault can help?!

Using Stream#indexed() the stream shall be processed indexed - using an Entry<Integer, T>.

• Enforce package info
• Enforce NonNullByDefault annotations
• Enforce no star imports
  checkstyle check AvoidStarImport is present already.

TODO: Integrate https://plugins.jetbrains.com/plugin/6546-eclipse-code-formatter into README.md
AND: https://github.com/dubreuia/intellij-plugin-save-actions

Maybe the eclipse-only profile helps. Then the profiles should be renamed to eclipse-settings and ide or such.

Or is there a way to tell IntelliJ which profiles to select by default?

1. It should be possible to extend / modify the pre-defined set of rules. (same for SpotBugs and PMD)
2. It would be nice to have not only XPathSuppressions, but also XPath rules!

This might be especially useful for parsing rolling log files.

Either should implement an equivalent to Optional.ifPresent

Separate generation and packaging to be able to skip packaging while still verifying JavaDoc.

Instead of the constants Collections.EMPY_* the methods Collections.empty*() shall be used.

A new class should provide the meta information of the currently running artifact, such as name, version, developer ...

Is that possible somehow?

TODO: Fix missing type at https://github.com/lars-sh/parent/blob/master/pom.xml#L2885

Projects should be able to use properties to disable lombok, changelog and readme creation, ...

Try to fix the formatter for the following situations:

new String[] { a,
b,
c}

if (a(b()))
	&& c) {
		d();
	}

Reinclude the JUnit Platform Runner, but exclude the JUnit 4 dependency.

		<dependency>
			<groupId>org.junit.platform</groupId>
			<artifactId>junit-platform-runner</artifactId>
			<version>1.5.2</version>
			<scope>test</scope>
			<exclusions>
				<exclusion>
					<groupId>junit</groupId>
					<artifactId>junit</artifactId>
				</exclusion>
			</exclusions>
		</dependency>

Maybe formatter:validate is a good choice to validate code formatting?!

As loading resources from JAR files is case sensitive, loading resources from disk should be case sensitive, too.

Disallow operators that modify a variable and takes the return value.

Bad code:
a = b += 1;

TODO: Probably add -Xlint:unchecked to the compilerArgs of the maven compiler plugin

Add convenience methods that override Optionals.mapToInt and handle just one optional parameter.

Add <relativePath></relativePath> to parent definition to avoid Maven warnings

• see

  parent/utils/pom.xml

  Line 62 in da40732

  <version>${parent.version}</version>

• are there any more such missing scopes for "internal" dependencies?