larskluge / crypto-balance Goto Github PK

If one API is not reachable, the lib shall not explode, but report this issue.

Current behavior: either explode or catch, print error to errout and continue as nothing happened.

Suggested behavior: catch all issues with services, services not reachable or the service has issues, report that as a hint, all other errors shall be thrown as usual. In case of no hard error, but hints, continue with other services and return result including hint messages.

Bluebird should be used differently in a library:

https://github.com/petkaantonov/bluebird#for-library-authors

And document how to use lib with Promises in README.

Would be nice to have such a possibility — to link to a repo on github. I forked the repo, made some changes but can't use the fork as a temporary replacement for the official module in my app's package.json.

The easiest way to make it possible is by getting rid of coffeescript; using javascript instead. It would also simplify the build process.

@larskluge opinions?

Keywords should be:

• bitcoin
• dogecoin
• litecoin
• counterparty
• dogeparty

What else?

Error:
/usr/bin/env: coffee: No such file or directory

minor issue. will address it myself later but just adding it here in case it should be documented for others.

i.e. the token XDP/DOGEPARTY is created with the option "Divisible". The balance for this token is reported wrong, multiplied by 100000000:

The balance 1 is reported like this:
100,000,000.00000000 XDP/DOGEPARTY

Correct would be:
1.00000000 XDP/DOGEPARTY