larsoft / larreco Goto Github PK

View Code? Open in Web Editor NEW

This code is part of the Liquid Argon Software (LArSoft) project. It contains simulation and reconstruction algorithms for LAr TPC detectors. If you have a problem, please log a redmine issue: https://cdcvs.fnal.gov/redmine/projects/larsoft/issues/new

License: Other

CMake 1.06% C++ 98.41% Makefile 0.01% C 0.53%

larreco's Introduction

larsoft

See the LArSoft wiki

larsoft is an umbrella product used to setup all larsoft products.

Dependencies

larsoft
|__larana
|  |__larreco
|     |__larsim
|     |  |__larg4
|     |  |  |__larevt
|     |  |  |  |__lardata
|     |  |  |  |  |__larcore
|     |  |  |  |  |  |__larcorealg
|     |  |  |  |  |     |__larcoreobj
|     |  |  |  |  |__lardataalg
|     |  |  |  |  |  |__lardataobj
|     |  |  |  |  |__larvecutils
|__lareventdisplay
|__larexamples
|__larpandora
|  |__larpandoracontent
|__larrecodnn
|__larsimdnn
|__larsimrad
|__larsoftobj
|__larwirecell

larreco's Issues

PeakFitterMrqdt commit somehow reintroduced and old bug with setting NDF

https://github.com/LArSoft/larreco/commits/develop/larreco/HitFinder/HitFinderTools/PeakFitterMrqdt_tool.cc

See the above, it seems when I click on the "clang format" link from May 20 that a bug in the calculation of NDF is reintroduced into the code... specifically at line 125 of https://github.com/LArSoft/larreco/blob/develop/larreco/HitFinder/HitFinderTools/PeakFitterMrqdt_tool.cc you can see that it tries to set the value of a local version of NDF, not the global one...

This was originally fixed by Giuseppe a long time ago... as our tracking is now working with data in ICARUS we are using NDF to separate out "long hits" and did not understand why all hits at the value of 1...

I think this is a simple fix, can it be done for this week's release?

Recommend Projects