lasersrl / laser.orchard.platform Goto Github PK

Dear developers,

Does the GDPR cookie banner used in here even work?

I tried cloning the repo, but it keeps missing methods like Retrieve, Store among others... Interfaces like IOrchardServices, IDependency etc...

Help is appreciated.

Sincerely,
munchkindev

Verify that it has Import/Export methods and that it is correctly placed in the right layer/zone,

Example: {Content.Parameter:TitlePart-Title).Slug}
This syntax is not very clear, because the parenthesis has not been opened in the token anywhere. Also, it may clash with some tokens that take their parameters in parenthesis.

I am not sure whether this issue is in every other definition of tokens. It may be worse if it isn't, because a fix would likely be breaking for existing configurations.

Looks like the culture picker does not correctly find that the localized version for a page corresponding to a controller action exists.
Example:
If I am on a /Users/Account/Register page, in English, the culture picker set to only show localized content will not show that there are other localizations of that page

If site base URL Is in http and ssl is active, calling in http a Page that has a redirect rule, results in a 404

Test done on a tenant with 4 languages, after setting the culture picker settings "Show only languages of translated contents", we did the fe test and we realized that the culture picker did not work correctly, ie in content that they had the translation in Italian and English the culture picker only proposed the language of the displayed content,
After checking the general site settings, we realized that the base url was configured with the http protocol instead of https.
By setting the https protocol, the culture picker started to work correctly.

The call from that line fails if there are more than 2100 territories in the hierarchy.

@ElenaRepository

Note that doing Query() is terrible because it fetches ALL CONTENT ITEMS and then filters, in memory, for those that have the Part attached. Adding TRecord would cause a Join to pre-filter out a bunch of stuff. However, using a TRecord causes the migration to fail if the schema is changed later (e.g. if we add a field/column to that record in a later migration).
A different way to fetch fewer content items then is to filter on the content types that have a TemplatePart.

retro steps:

• register new user with Laser.Orchard.UsersExtensions/AKUserActions/RegisterSSL API

Collection Postman to test
https://lasersrl-my.sharepoint.com/:u:/g/personal/patrick_negretto_laser-group_com/ES0rzswpx0RKu-qqf9_DoCsBIrVfWwQYbjxZijrALXYEQQ?e=0bJoGW

The response is 500 with this error on HTML page

[NullReferenceException: Riferimento a un oggetto non impostato su un'istanza di oggetto.] System.Web.Mvc.DefaultModelBinder.BindProperty(ControllerContext controllerContext, ModelBindingContext bindingContext, PropertyDescriptor propertyDescriptor) +1180 System.Web.Mvc.DefaultModelBinder.BindProperties(ControllerContext controllerContext, ModelBindingContext bindingContext) +143 System.Web.Mvc.DefaultModelBinder.BindComplexElementalModel(ControllerContext controllerContext, ModelBindingContext bindingContext, Object model) +63 System.Web.Mvc.DefaultModelBinder.BindComplexModel(ControllerContext controllerContext, ModelBindingContext bindingContext) +1739 System.Web.Mvc.DefaultModelBinder.UpdateCollection(ControllerContext controllerContext, ModelBindingContext bindingContext, Type elementType) +605 System.Web.Mvc.DefaultModelBinder.BindComplexModel(ControllerContext controllerContext, ModelBindingContext bindingContext) +1716 System.Web.Mvc.DefaultModelBinder.GetPropertyValue(ControllerContext controllerContext, ModelBindingContext bindingContext, PropertyDescriptor propertyDescriptor, IModelBinder propertyBinder) +31 System.Web.Mvc.DefaultModelBinder.BindProperty(ControllerContext controllerContext, ModelBindingContext bindingContext, PropertyDescriptor propertyDescriptor) +483 System.Web.Mvc.DefaultModelBinder.BindProperties(ControllerContext controllerContext, ModelBindingContext bindingContext) +143 System.Web.Mvc.DefaultModelBinder.BindComplexElementalModel(ControllerContext controllerContext, ModelBindingContext bindingContext, Object model) +63 System.Web.Mvc.DefaultModelBinder.BindComplexModel(ControllerContext controllerContext, ModelBindingContext bindingContext) +1739 System.Web.Mvc.ControllerActionInvoker.GetParameterValue(ControllerContext controllerContext, ParameterDescriptor parameterDescriptor) +459 System.Web.Mvc.ControllerActionInvoker.GetParameterValues(ControllerContext controllerContext, ActionDescriptor actionDescriptor) +136 System.Web.Mvc.Async.<>c__DisplayClass21.<BeginInvokeAction>b__19(AsyncCallback asyncCallback, Object asyncState) +1151 System.Web.Mvc.Async.WrappedAsyncResultBase1.Begin(AsyncCallback callback, Object state, Int32 timeout) +166
System.Web.Mvc.Async.AsyncControllerActionInvoker.BeginInvokeAction(ControllerContext controllerContext, String actionName, AsyncCallback callback, Object state) +463
System.Web.Mvc.Controller.<BeginExecuteCore>b__1c(AsyncCallback asyncCallback, Object asyncState, ExecuteCoreState innerState) +42
System.Web.Mvc.Async.WrappedAsyncVoid1.CallBeginDelegate(AsyncCallback callback, Object callbackState) +73 System.Web.Mvc.Async.WrappedAsyncResultBase1.Begin(AsyncCallback callback, Object state, Int32 timeout) +166
System.Web.Mvc.Controller.BeginExecuteCore(AsyncCallback callback, Object state) +906
System.Web.Mvc.Async.WrappedAsyncResultBase1.Begin(AsyncCallback callback, Object state, Int32 timeout) +166 System.Web.Mvc.Controller.BeginExecute(RequestContext requestContext, AsyncCallback callback, Object state) +711 System.Web.Mvc.MvcHandler.<BeginProcessRequest>b__4(AsyncCallback asyncCallback, Object asyncState, ProcessRequestState innerState) +93 System.Web.Mvc.Async.WrappedAsyncVoid1.CallBeginDelegate(AsyncCallback callback, Object callbackState) +73
System.Web.Mvc.Async.WrappedAsyncResultBase1.Begin(AsyncCallback callback, Object state, Int32 timeout) +166 System.Web.Mvc.MvcHandler.BeginProcessRequest(HttpContextBase httpContext, AsyncCallback callback, Object state) +502 System.Threading.Tasks.TaskFactory1.FromAsyncImpl(Func4 beginMethod, Func2 endFunction, Action1 endAction, TArg1 arg1, Object state, TaskCreationOptions creationOptions) +824 Orchard.Mvc.Routes.<<ProcessRequestAsync>b__0>d.MoveNext() +294 System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() +31 System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) +60 Orchard.Owin.<<UseOrchard>b__0_0>d.MoveNext() +323 System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() +31 System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) +60 Orchard.SecureSocketsLayer.Services.<<GetOwinMiddlewares>b__8_1>d.MoveNext() +516 System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() +31 System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) +60 Orchard.Mvc.Routes.<ProcessRequestAsync>d__5.MoveNext() +582 System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() +31 System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) +60 System.Web.TaskAsyncHelper.EndTask(IAsyncResult ar) +64 System.Web.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() +602 System.Web.HttpApplication.ExecuteStepImpl(IExecutionStep step) +195 System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously) +128

In a recent import/export test, the settings for Cookies did not transfer

Probably the attempt to save the content when adding a new widget is trying to "save" the term on the wrong controller?
The result is that no widget is added.

When content required are protected by policies and user have not accepted, the response on "l" key don't contain all content item fields but they are incorrectly filtered with "mfilter" parameters.

https://team00.mykrake.com/Laser.Orchard.WebServices/Json/GetByAlias?lang=it-IT&realformat=true&mfilter=game,gamepart,gallery,activitypart,autoroutepart,titlepart,bodypart&no-cache=625741120.501513&displayAlias=elenco-protected-valid-games&pageSize=0&complexbehaviour=returnnulls&page=0

This problem has already been reported in the past, I think it is a regression!

https://github.com/LaserSrl/Laser.Orchard.Platform/blob/593edf00dd4c47bdd9d45af35681121c8b038a3a/src/Modules/Contrib.Widgets/Services/WidgetManager.cs#LL26C31-L26C31

What I think this is doing:

• SQL query to find the Ids of the widgets (thanks to the join with WidgetExPartRecord, and the fact the default implementation will itself join ContentItemRecord and ContentItemVersionRecord)
• One contentManager.Get for each of those
  • In every Get, during the Loading handlers, we are setting delegates to launch further queries for each record involved in the content (https://github.com/LaserSrl/Orchard/blob/95a5782d725f00dc168e4e7f53bd5a88102eb7f2/src/Orchard/ContentManagement/Handlers/StorageFilter.cs#LL57C27-L57C28), so if the widget has a TitlePart and a BodyPart that's two additional queries ready to be fired.
• Extract the WidgetExPart from each of the resulting ContentItems.

We should test whether any of those additional Loading queries is firing. I suppose so, and some of this may be partly responsible for the slowdowns we are seeing, because we tend to use a lot of these widgets everywhere. In WidgetService (https://github.com/LaserSrl/Orchard/blob/95a5782d725f00dc168e4e7f53bd5a88102eb7f2/src/Orchard.Web/Modules/Orchard.Widgets/Services/WidgetsService.cs#L74) They use QueryHintsto expand theCommonPart`. It may be wort to test whether that helps our cases.

When the API script is rendered, we have to make the map's language consistent with the current page language.
GoogleMaps: the querystring parameter language ("&language={CurrentLanguage}") should be added in order to
OSM: To be verified if it is possible
OpenLayers: To be verified if it is possible

Going in detail, we should decide if we want the parameter to be optional (expanfing the existing site setting).

When I try to logged in with external provider, the user seem to be created with wrong favorite culture. User have the tenant default culture and not the value present on query string.

https://team00.mykrake.com/AKExternal/TokenLogon?Language=it-IT&lang=it-IT&__provider__=xxxxxx

The user edit on back-end doesn't work, when I change the favorite language and I save it, seem never update content.

I can't try with registerssl for the issue #14

Enabling NwazetIntegration the tenant breaks. It could be a missing dependency in module.txt?

None of the constructors found with 'Orchard.Environment.AutofacUtil.DynamicProxy2.ConstructorFinderWrapper' on type 'Laser.Orchard.NwazetIntegration.Drivers.ProductVatConfigurationPartDriver' can be invoked with the available services and parameters:
Cannot resolve parameter 'Nwazet.Commerce.Services.IVatConfigurationService vatConfigurationService' of constructor 'Void .ctor(Nwazet.Commerce.Services.IVatConfigurationService, Nwazet.Commerce.Services.IVatConfigurationProvider, Nwazet.Commerce.Services.IProductPriceService)'.