web_tasks's People
web_tasks's Issues
F0修改建议
完成的很棒,页面精美,风格独特
建议修改:
- 输入框之间应该添加间距
- 页面乱码, 请设置编码
F1修改建议
完成的非常出色!以下是几点优化建议:
登录界面
- 把script标签放到文档末尾有利于优化加载速度
<script src="http://upcdn.b0.upaiyun.com/libs/jquery/jquery-2.0.2.min.js"></script>
<script src="https://cdn.bootcss.com/bootstrap/3.3.7/js/bootstrap.min.js" integrity="sha384-Tc5IQib027qvyjSMfHjOMaLkfuWVxZxUPnCJA7l2mCWNIpG9mGCD8wGNIcPD7Txa" crossorigin="anonymous"></script>
<script src="show.js"></script>
<script type="text/javascript">
$(document).ready(function() {
$("#navsup").click(function() {
$("#signup").fadeIn("slow");
$("#signin").hide();
});
$("#navsin").click(function() {
$("#signin").fadeIn("slow");
$("#signup").hide();
});
});
</script>
学生管理系统
- 以下三元条件判断可以改成短路判断
this.name = name ? name : null;
this.sex = sex ? sex : null;
this.id = id ? id : null;
this.grade = grade ? grade : null;
this.subject = subject ? subject : null;
更改示例
this.name = name || null
- 刷新页面时之前保存的学生信息就不见了,应该在页面加载时也加载本地学生信息
- 建议添加一个页面,可以直接查看现有的所有学生,
存
这个页面显得多余,添加即保存了 - 下列这些需要频繁获取的节点应该在初始化时获取并缓存到一个全局对象里,下次使用时直接访问该对象保存的节点即可,可有效提高性能
function editShow() {
$(".add").hide();
$(".del").hide();
$(".search").hide();
$(".edit").fadeIn("slow");
$(".save").hide();
}
function saveShow() {
$(".add").hide();
$(".del").hide();
$(".search").hide();
$(".edit").hide();
$(".save").fadeIn("slow");
}
F2修改建议
整体完成的不错,基本实现了任务所要求的功能
- JS组织比较散乱,应该把各个功能封装成一个函数,而不是简单的事件监听.例如对于移动端触屏滑动功能的实现应该把相关代码封装成一个函数,直接在一个主函数里调用即可
- JS代码中对元素的获取并没有在文档加载完成后获取,而是直接在JS文件加载之后就获取了,这可能会导致获取不到节点的错误,在你的代码中只需要将JS的引入放入head标签中并会出现找不到节点. 有兴趣可以了解一下浏览器网页渲染的机制.
- 图片切换效果不是很好,切换时出现了白色闪光,而且速度较快,感觉和闪屏差不多,建议换一个温柔一点的效果
F3修改建议
完成得非常棒, 如果可以检验一下用户输入的色彩值是否符合范围就更好了
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.