lazarusa / coherentnoise.jl Goto Github PK

Hi @mfiano ,

Just found this package from the new-packages-feed channel on Slack. Really nice one!

Several days back, I created a Julia wrapper of https://github.com/JuliaReinforcementLearning/FastNoise2.jl . I think both packages share a lot of utilities. But one thing which is missing in that wrapper is native GPU support. Looking into the source code of CoherentNoise.jl, I'm wondering how much extra work would it need to add GPU support for some common noise like OpenSimplex2?

Here's an idea for the social media preview (1280 by 640, add it via Settings > General and also link to it in a README perhaps).

Well, it's all pretty groovy - perhaps a bit too groovy - perhaps way too groovy for you... ? :)

Edit: changed text

First of all, congratulations on this great package! 🎉 I work a lot with generation of random images in geostatistics (GeoStats.jl) and it is nice to see more algorithms available.

May I suggest sampler_type(rng=...) instead of sampler_type(seed=...)? In Julia, whenever we want to guarantee reproducibility with random numbers we pass the generator object instead of the seed, and it goes as the first positional argument instead of a keyword argument. See the rand docstring for example.

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Hey, first thanks for this package. The content is awesome and the docs are super nice!
I would like to use some of the examples you show in your table, but it's hard to know which exact combination was used (as code).
It would be great to have this in the table displayed here (https://mfiano.github.io/CoherentNoise.jl/dev/algorithms/).

Right now the distance is based to the origin. Would that make sense to allow having a different center?