lbellonda / qxmledit Goto Github PK

Implement a visualization that can be used to view only non leafs nodes in a 
XML file.

The version number added to the widget library project in the 0.7.0 version is 
handled under Linux, but on Windows changes the QXmlEditWidget library name.

Workaround: take out the version from the .pro file

Fix: enable the version only under linux like that:

unix:VERSION = 0.7.0

When editing an element, QXMLEdit shows a window where the top part enables 
operation on text nodes, while the bottom one enables operation on attributes. 
This bottom part includes two "up" and "down" buttons meant to change the 
attribute sorting.

Indeed, using the buttons changes the attribute sorting. However, the new 
attribute sorting does not get saved when the XML file is saved.

Furthermore, if you alter the attribute sorting with and editor and then you 
start the QXMLEditor on the file, you quickly see that the order in which 
attributes are sorted in QXMLEdit is different from that in the XML file.

What steps will reproduce the problem?
1. Start QXmlEdit
2. Show the toolbar (if not visible)
3. Hover mouse over third Navigation button until the tooltip appears.

What is the expected output? What do you see instead?
The tooltip should show "Go to Next Brother", instead it shows "Go to Previous 
Brother" (same as for the second Navigation button).

What version of the product are you using? On what operating system?
0.8.3.1

Please provide any additional information below.
The buttons function correctly; it's just the third button tooltip. The 
corresponding menu items are correctly labelled.

Installation path in *.pro files is /opt/qxmledit.
qmake doesn't accept variables.

This is impossible to build packages for distribution.
We need to install QXmlEdit to /usr/bin and all the libraries to /usr/lib 
(/usr/lib64 for x86_64).

QXmlEdit should compile and run using qt4 or qt5 with minimal code changes.

I'm very sorry to say compilation with Qt < 4.7 doesn't work even with 'qmake 
-config use_qt44'.

I don't treat this as a bug, and understand that you don't plan to support 
older Qt versions. So install documentation needs some correction.

I am using Version 0.8.10 on Windows

Thank you for the coding, here is some user-feedback: some tiny changes would 
make it perfect

- evaluate xpathExpression , e.g. count(...) or concat(...)

Great Work
Martin

'UNIX_DOC_DIR' is incorrect.

Patch:

Index: src/qxmleditdata.cpp
===================================================================
--- src/qxmleditdata.cpp.orig
+++ src/qxmleditdata.cpp
@@ -229,7 +229,7 @@ QString QXmlEditData::getDocsDir()
 #else

 #ifdef UNIX_RESOURCES
-    QString toReturn = QString(STRINGIZE(UNIX_DOC_DIR));
+    QString toReturn = QString(STRINGIZE(UNIX_DOC_PATH));
     return toReturn;
 #else
     //All the others

 g++ -c -include ../build/lib/obj/QXmlEditWidget-0.9.4 -pipe -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -g -Wall -Werror -std=c++11 -O2 -Wall -W -D_REENTRANT -fPIC -DLIBQXMLEDIT_LIBRARY -DUNIX_RESOURCES -DUNIX_RESOURCE_PATH=/usr/share/qxmledit/ -DUNIX_DOC_PATH=/usr/share/doc/packages/qxmledit/ -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_XML_LIB -DQT_XMLPATTERNS_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I. -Iglobals/includes -I./globals/framework -Iglobals/includes -Iframework/include -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtSvg -isystem /usr/include/qt5/QtPrintSupport -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtXmlPatterns -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtCore -I../build/lib/moc -I../build/lib/ui -I/usr/lib64/qt5/mkspecs/linux-g++ -o ../build/lib/obj/edittextnode.o edittextnode.cpp
 elementitemdelegate.cpp: In member function 'virtual void ElementItemDelegate::paint(QPainter*, const QStyleOptionViewItem&, const QModelIndex&) const':
 elementitemdelegate.cpp:51:46: error: 'QStyleOptionViewItemV4' is deprecated [-Werror=deprecated-declarations]
          QStyleOptionViewItemV4 option4(option);
                                               ^
 In file included from /usr/include/qt5/QtWidgets/qabstractitemdelegate.h:44:0,
                  from /usr/include/qt5/QtWidgets/qabstractitemview.h:46,
                  from /usr/include/qt5/QtWidgets/qheaderview.h:43,
                  from /usr/include/qt5/QtWidgets/QHeaderView:1,
                  from globals/includes/qtincludes.h:37,
                  from globals/includes/xmlEdit.h:55,
                  from precompiled_lib.h:27:
 /usr/include/qt5/QtWidgets/qstyleoption.h:441:48: note: declared here
  typedef Q_DECL_DEPRECATED QStyleOptionViewItem QStyleOptionViewItemV4;
                                                 ^~~~~~~~~~~~~~~~~~~~~~

What steps will reproduce the problem?
1. Try to download 0.4.2 source tarball
2. Notice it missing

Please fix!

Editing inner XML and triggering OK closes the edit window, but the edit items 
are discarded.

Hi I tried to make the binary and had this issues during compilation, full 
output as attachment. Using Qt 4.7.4

utils.cpp: In static member function ‘static void Utils::error(QWidget*, 
const QString&)’:
utils.cpp:43:39: error: format not a string literal and no format arguments 
[-Werror=format-security]
utils.cpp: In static member function ‘static void Utils::warning(QWidget*, 
const QString&)’:
utils.cpp:57:39: error: format not a string literal and no format arguments 
[-Werror=format-security]
cc1plus: some warnings being treated as errors

make[1]: *** [../build/lib/obj/utils.o] Error 1
make[1]: Leaving directory `/home/guest/tmp/qxmledit-0.8.2/src'
make: *** [sub-src-QXmlEditWidget-pro-make_default-ordered] Error 2

 data_access/sqllitegenericdata.cpp:313:28: error: invalid suffix on literal; C++11 requires a space between literal and string macro [-Werror=literal-suffix]
  #define QRY_READ_TAGS_TYPE "select tr.objectId, t.tag from "TABLE_TAGS_RELATIONS" tr join "TABLE_GENERIC_OBJECTS" o on o.type=:type and o.id=tr.objectId join " TABLE_TAGS " t on t.id=tr.tagId "
                             ^
 data_access/sqllitegenericdata.cpp:313:81: error: invalid suffix on literal; C++11 requires a space between literal and string macro [-Werror=literal-suffix]
  #define QRY_READ_TAGS_TYPE "select tr.objectId, t.tag from "TABLE_TAGS_RELATIONS" tr join "TABLE_GENERIC_OBJECTS" o on o.type=:type and o.id=tr.objectId join " TABLE_TAGS " t on t.id=tr.tagId "
                                                                                  ^
 data_access/sqllitegenericdata.cpp:314:35: error: invalid suffix on literal; C++11 requires a space between literal and string macro [-Werror=literal-suffix]
  #define QRY_READ_TAGS_TYPE_AND_ID "select tr.objectId, t.tag from "TABLE_TAGS_RELATIONS" tr join "TABLE_GENERIC_OBJECTS" o on o.type=:type and o.id=tr.objectId and o.id=:id join " TABLE_TAGS " t on t.id=tr.tagId "
                                    ^
 data_access/sqllitegenericdata.cpp:314:88: error: invalid suffix on literal; C++11 requires a space between literal and string macro [-Werror=literal-suffix]
  #define QRY_READ_TAGS_TYPE_AND_ID "select tr.objectId, t.tag from "TABLE_TAGS_RELATIONS" tr join "TABLE_GENERIC_OBJECTS" o on o.type=:type and o.id=tr.objectId and o.id=:id join " TABLE_TAGS " t on t.id=tr.tagId "
                                                                                         ^

The picture in the left pane of the xsd view (list of types) is not stable when 
mouse is moved over it. I attached the video showing the problem. This was 
observed in all versions I've been uing (0.6.0 und up to the current 0.8.0). Qt 
library version is 4.8.0, system is debian sid.

Please add header files to installation.
QXmlEditWidgets library is useless for development without includes.

<alto 
    xmlns="http://www.loc.gov/standards/alto/ns-v2#" 
    xmlns:xlink="http://www.w3.org/1999/xlink" 
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
    xsi:schemaLocation="http://www.loc.gov/standards/alto/ns-v2# http://www.loc.gov/standards/alto/alto-v2.0.xsd"
>

Can't compile QXmlEdit 0.4.8 in
openSUSE 11.1 and in openSUSE 11.2.

mainwindow.cpp: In member function 'void 
MainWindow::on_actionValidate_triggered()':
mainwindow.cpp:1700: error: 'QXmlSchema' was not declared in this scope
mainwindow.cpp:1700: error: expected `;' before 'schemaHandler'
mainwindow.cpp:1702: error: 'schemaHandler' was not declared in this scope
mainwindow.cpp:1703: error: 'QXmlSchemaValidator' was not declared in this scope

Is there ability to disable Qt 4.6 features automatically, based on Qt build 
environment?

The fact is openSUSE 11.1 provides Qt 4.4.3 and openSUSE 11.2 provides Qt 4.5.3 
in system repositories.

Thanks.

Version: 0.5.3

Due a last minute macro rename, the test subproject no more compile.

As workaround in the file test/testsplit.cpp: at 166:17: "NUMBER_TOKEN_PTRN" 
should be changed to "COUNTER_TOKEN_PTRN".

The main subproject compile without problems.

To reproduce:
Insert a child in an element.
Select it.
Activate "Append" button in the main window.
Edit the new element and save it.

The program tries to insert a new root element instead of placing the item at 
the correct location and stops given that there is a check on the existence of 
a single root element.

Workaround: use the "insert" feature.

What steps will reproduce the problem?
1.Open 'File' menu and trigger 'New'
2.Insert some elements

At this time the 'Save as' menu should be enabled.

The functionality was working before the refactoring done in the 0.7.0 version.

Not really a bug in the excellent software, rather in its distribution.

Note the file name sequence

qxmledit-0.5.1-sources.tgz
qxmledit-0.5.0-src.tgz
QXmlEdit-0.4.9.1-sources.tgz
QXmlEdit-0.4.9-sources.tgz
qxmledit-0.4.8.src.tgz
qxmledit-src-0.4.7.tgz

Since there is no established structure, it is almost impossible to use debian 
watch files.

It finally compiled succesfully and create it on /opt/qxmledit. 

However I get another error when I execute 

$ /opt/qxmledit/QXmlEdit 
/opt/qxmledit/QXmlEdit: error while loading shared libraries: 
libQXmlEditSessions.so.0: cannot open shared object file: No such file or 
directory

The library is on the same folder /opt/qxmledit and tired doing a softlink on 
/usr/lib/ but still same error.

What steps will reproduce the problem?
1. Open consiguration dialog
2. Choose an option for style files location
3. Press "Open Localtion in Browser" button

The selected directory does not appear on Windows and OS/2 systems.

What steps will reproduce the problem?
1. Open an XML file
2. Create an attribute with a space in its name (QXmlEdit happily accepts it)
3. Save the XML file
4. Try to reopen the file
5. See QXmlEdit complain that it is uncapable to open the file because it is 
invalid

What is the expected output? What do you see instead?

QXmlEdit should refuse to add attributes with invalid names.

QXmlEdit does not complain and then saves a file that cannot be re-opened any 
more.


What version of the product are you using? On what operating system?

0.4.9 on linux.
Please provide any additional information below.

Windows XP, V 0.8.10


<DATEN>
  <NODEXXX>xxx</NODEXXX>
</DATEN>

Select NODEXXX -> Copy element path to clipboard


/DATEN/NODEXXX

Insert the path /DATEN/NODEXXX to the search-dialog (XPath enabled)

Hit Search -> No Results

/NODEXXX works, it seems that you have to remove the first path-entry

According to freedesktop.org standard there should be 48x48 icon in application 
installation.
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#ins
tall_icons

Different sizes are better.

The Free Software Foundation address in COPYING is outdated.
Please replace the file with 
http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt

What steps will reproduce the problem?
There are some errors when building qxmledit 0.8.5 with vs2010 win64

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
qxmledit 0.8.5 on Windows 7


Please provide any additional information below.
The attached file contains all the patchs

While starting the program on some Windows XP Systems, in the Welcome Panel the 
SVG icons are completly gray.

I run QXmlEdit in openSUSE 11.1 x586. Qt 4.4.3.

Program interface doesn't display correctly.
Font is small in full length lines. Problem with menu and buttons.

Could you help, please? Thanks.

Screenshots attached.

This is not a bug report, rather a wish.

When building QXmlEdit, it is hard to customize the install location of some of 
its pieces, and specifically of the manual file.

Conversely, this is important to packaging as many distributions have strict 
guidelines about what should go where.

The manual of QXmlEdit is a pdf file.
In debian based systems, this should go in /usr/share/doc/qxmledit/

However, the QXmlEdit build system installs it together with all the other 
program resources in INST_DATA_DIR.

Would be great to have an INST_DOC_DIR for documentation.
Additionally, there should be something like
DEFINES += DOC_DIR=$$INST_DOC_DIR in the pro file, to assure that the doc dir 
information is passed to the program, so that it can find the manual.

Also note that the very name of the HELP_FILE seems to be hardwired in the 
sources, when it should probably be passed to the program by another DEFINE.

Just in case they are useful, I am attaching the two patches that I use to 
build on debian (these are for 0.6.0).  They are ugly and can be very much 
improved.


--- Qxmledit-Git.orig/src/QXmlEdit.pro  2011-12-29 01:12:18.524011618 +0100
+++ Qxmledit-Git/src/QXmlEdit.pro       2012-01-01 13:00:28.271169705 +0100
@@ -22,14 +22,15 @@



-# TO CUSTOMIZE INSTALLATION DIRECTORY SET THESE TWO VARIABLES
+# TO CUSTOMIZE INSTALLATION DIRECTORY SET THESE THREE VARIABLES
 # Note:
 #  WITH SOME MORE WORK WE CAN USE VARIABLES PASSED TO MAKE LIKE THAT
 #  in pro DEFINES += UNIX_RESOURCE_PATH=\"$(QXMLEDIT_DATADIR)\"
 #  and calling make QXMLEDIT_DATADIR=/usr/share/qxmledit

-INST_DATA_DIR = /opt/qxmledit
-INST_DIR = /opt/qxmledit
+INST_DATA_DIR = /usr/share/qxmledit
+INST_DOC_DIR = /usr/share/doc/qxmledit
+INST_DIR = /usr/bin


 TEMPLATE = app
@@ -290,7 +291,7 @@

 ICON = images/mainIcon.icns
 win32:RC_FILE = win.rc
-styles.path = $$INST_DATA_DIR
+styles.path = $$INST_DATA_DIR/styles
 styles.files = data/sample.style
 snippets.path = $$INST_DATA_DIR/snippets
 snippets.files = data/snippets/{6d11b8d1-e285-46b2-8375-79e17cab9862}.xml \
@@ -300,7 +301,7 @@
     data/snippets/{e40792fb-16de-4418-9320-4feaa92c28a3}.xml \
     data/snippets/{edc60671-0ae0-401b-989d-5d0b82976bce}.xml \
     data/snippets/{f6d7ebdd-c505-4a6a-8a16-f7c99581a995}.xml
-manual.path = $$INST_DATA_DIR
+manual.path = $$INST_DOC_DIR
 manual.files = ../doc/QXmlEdit_manual.pdf

 # resources are defined in paths.h



--- Qxmledit-Git.orig/src/applicationdata.h     2012-01-05 13:31:18.905365968 
+0100
+++ Qxmledit-Git/src/applicationdata.h  2012-01-05 13:34:52.000000000 +0100
@@ -83,6 +83,7 @@
     QString snippetsLocalDir();
     QString snippetsProgramDir();
     static QString getResourceDir();
+    static QString getDocDir();

     IQXmlEditPlugIn *xsdPlugin();


--- Qxmledit-Git.orig/src/applicationdata.cpp   2012-01-05 13:31:18.961366246 
+0100
+++ Qxmledit-Git/src/applicationdata.cpp        2012-01-05 14:34:05.416043086 
+0100
@@ -232,6 +232,26 @@
 #endif
 }

+QString ApplicationData::getDocDir()
+{
+#ifdef Q_WS_MAC
+    //All the others
+    QString toReturn ;
+    toReturn = QApplication::applicationDirPath() + QDir::separator() + ".." + 
QDir::separator() + "SharedSupport" ;
+    return toReturn ;
+#else
+
+#ifdef UNIX_RESOURCES
+    QString toReturn = QString(STRINGIZE(DOC_DIR));
+    return toReturn;
+#else
+    //All the others
+    return QApplication::applicationDirPath();
+#endif
+
+#endif
+}
+
 const QMap<QString, IQXmlEditPlugIn*> &ApplicationData::plugins() const
 {
     return _plugins ;



--- Qxmledit-Git.orig/src/mainwindow.cpp        2012-01-05 13:31:18.933366107 
+0100
+++ Qxmledit-Git/src/mainwindow.cpp     2012-01-05 13:34:52.000000000 +0100
@@ -2412,7 +2412,7 @@

 void MainWindow::on_actionHelpOnQXmlEdit_triggered()
 {
-    QString resourceHelp = data->getResourceDir() + "/" + HELP_FILE ;
+    QString resourceHelp = data->getDocDir() + "/" + HELP_FILE ;
     QDesktopServices::openUrl(QUrl::fromLocalFile(resourceHelp));
 }



--- Qxmledit-Git.orig/src/QXmlEdit.pro  2012-01-05 13:34:52.000000000 +0100
+++ Qxmledit-Git/src/QXmlEdit.pro       2012-01-05 14:29:35.674705508 +0100
@@ -49,7 +49,7 @@
 ############ CONFIGURATION SENT TO THE PROGRAM ############
 # translations folder (inside the resources folder).
 DEFINES += TRANLASTION_DIR=translations
-
+DEFINES += DOC_DIR=$$INST_DOC_DIR

 HEADERS = mainwindow.h \
     regola.h \

I build rpm-packages for openSUSE.
Build failed testing compiler warnings:

 ... testing for serious compiler warnings
     (using /usr/lib/build/checks-data/check_gcc_output)
     (using /home/kent/rpmbuild/BUILD-osc/openSUSE_Factory-x86_64/.build.log)

 I: Program returns random data in a function
 E: qxmledit no-return-in-nonvoid-function modules/search/xqueryelementmodel.cpp:148

Compile log:

 g++ -c -m64 -pipe -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -Werror=format-security -Wunused-variable -Wstrict-aliasing -O2 -Wall -W -D_REENTRANT -fPIC -DQT_WEBKIT -DLIBQXMLEDIT_LIBRARY -DUNIX_RESOURCES -DUNIX_RESOURCE_PATH=/usr/share/qxmledit -DUNIX_DOC_PATH=/usr/share/doc/packages/qxmledit-doc -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_XMLPATTERNS_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/default -I. -I/usr/include/QtCore -I/usr/include/QtNetwork -I/usr/include/QtGui -I/usr/include/QtXml -I/usr/include/QtXmlPatterns -I/usr/include/QtSvg -I/usr/include -I. -Iglobals/includes -I../build/lib/moc -I../build/lib/ui -o ../build/lib/obj/xqueryelementmodel.o modules/search/xqueryelementmodel.cpp
 In file included from modules/search/xqueryelementmodel.cpp:24:0:
 modules/search/xqueryelementmodel.h: In constructor 'XQueryElementModel::XQueryElementModel(Regola*, Element*, QXmlNamePool&)':
 modules/search/xqueryelementmodel.h:38:19: warning: 'XQueryElementModel::_namePool' will be initialized after [-Wreorder]
 modules/search/xqueryelementmodel.cpp:37:153: warning:   base 'QSimpleXmlNodeModel' [-Wreorder]
 modules/search/xqueryelementmodel.cpp:37:1: warning:   when initialized here [-Wreorder]
 modules/search/xqueryelementmodel.cpp: In member function 'virtual QVector<QXmlNodeModelIndex> XQueryElementModel::attributes(const QXmlNodeModelIndex&) const':
 modules/search/xqueryelementmodel.cpp:190:239: warning: unused variable 'attribute' [-Wunused-variable]
 modules/search/xqueryelementmodel.cpp: In member function 'virtual QXmlNodeModelIndex::NodeKind XQueryElementModel::kind(const QXmlNodeModelIndex&) const':
 modules/search/xqueryelementmodel.cpp:148:1: warning: control reaches end of non-void function [-Wreturn-type]

Can you help, please, with a patch or so? Thanks.

What steps will reproduce the problem?
1. Launch QXmlEdit binary

What is the expected output? What do you see instead?
Expected programming running. Discovered program is not compiled to work on
amd64 platform.

What version of the product are you using? On what operating system?
Software version 0.4.5. Ubuntu Karmic Koala, KDE4.4 from PPA, installed
18th February.

Please provide any additional information below.
Attaching working version compiled against current system.

What version of the product are you using? On what operating system?
0.7.2

undo redo in edit menu