lbnl-jci-icf / better Goto Github PK

I installed the package with the latest packageready source code with pip install . to a virtual Python environment.
When I import better as and try to run the analysis for a single building, it says "constants" is not defined.

I got the same issue when I try bt.demo.run_batch(1, 5).

If the Source.code.zip file contents are moved to a new directory, the code currently cannot handle directory names with spaces in them. If spaces exist, the following error occurs (in this case, parent directory was named "BETTER Source Code - CERC"):

Traceback (most recent call last):
File "demo.py", line 157, in
main()
File "demo.py", line 151, in main
run_single(bldg_id=18, saving_target=2, cached_weather=False)
File "demo.py", line 104, in run_single
report_building.generate_building_report_beta(report_path)
File "<C:\Users\31335\Desktop\BETTER Source Code - CERC\better\report.py>", line 121, in generate_building_report_beta
with open(report_file, 'w', encoding="utf-8") as report_html:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\Users\31335\Desktop\BETTER_Source_Code_-_CERC/outputs/18
_Beijing_Office_18_report.html'

Renaming directory to "BETTER_Source_Code-CERC" solved the issue. Would be good if code could be modified to accommodate this so other users do not run into same issue.

After installing Anaconda3 and python 3.7.1 on a Windows 10 machine, I downloaded the better-0.4-alpha code. The install.bat failed so I tried "python setup.py install" in Windows cmd. It failed trying to install the ish_parser package with the following message:

e following message.

After consulting with Han Li and Ahmed Bekhit I tried to install the ish_parser using the following command "pip install ish_parser" in Windows cmd. Here is the error message:

After searching for a solution I came across the following thread: pypa/virtualenv#1139. I tried the suggestion to try "pip install ish_parser" in an Anaconda cmd window and was able to successfully load the ish_parser packeage.

In use_NOAA_station_list branch, the station list (isd-history) is filtered to include stations between invoices start and end dates. This makes the tool more flexible in station search rather than fixed df in Constants. However, there are some stations in isd-history that doesn't have weather data in the year directory even when end date ('END') > year.

How would we build a robust station list that we are sure it has data?

I do have existing [email protected]. I use VScode for coding.

I tried to run the code @run.py and it looks like in report.py with function generate_building_report_beta is not able to find "1_Miami,_FL_Office_1_report.html" file.

Hi, I installed and ran the entire portfolio ID 1 to 32 already included in portfolio.xlsx.
I have all the 32 individual reports in the "output" folder but not the "sample portfolio" is incomplete (i get only the first section of the report)
I get the following error message in the console:

Traceback (most recent call last):

File "C:\Users\xxxxxx\xxxxxx\better\demo.py", line 183, in
main()

File "C:\Users\xxxxxx\xxxxxx\better\demo.py", line 180, in main
run_batch(start_id = 1, end_id = 32, saving_target=2, cached_weather=False, batch_report=True)

File "C:\Users\xxxxxx\xxxxxx\better\demo.py", line 169, in run_batch
report_portfolio.generate_portfolio_report(report_path)

File "C:\Users\xxxxxx\xxxxxx\better\report.py", line 806, in generate_portfolio_report
scatter_html = self.add_2d_scatter_plot(self.portfolio.df_bldg_summary)

File "C:\Users\xxxxxx\xxxxxx\better\report.py", line 714, in add_2d_scatter_plot
c_str = v_rgb_str[i]

IndexError: string index out of range

However, if I run a batch from building ID 1 to 31 in seems to work fine (but the last building won't be included in the portfolio report). Also it seems to work from building ID 20 to 32...
I also added a building (building ID 33) and if i run the batch from building ID 1 to 32 it also works fine...

Is it related to the previous issue : "Error in scatter plot in portfolio report #4" ?

Thanks

Is the intent to save the weather data locally on the computer when a simulation is done? Or the weather files have to be produced by the user and saved in the "data" folder?
I so far I ran the entire portfolio. I have been able to locate the reports in the "output" folder but there is no saved weather files in the "data" folder and is I changed the "cached_weather" option to TRUE I get the following (run_single on building ID11: run_single(bldg_id = 11, saving_target=2, cached_weather=True) )

FileNotFoundError: File b'C:\Users\xxxxx\xxxxx\Better/Data/Weather/2017/2017_726464-54834.csv' does not exist

Note: I ran the same command with the cached_weather=False previously.

In portfolio mode, if use_default_benchmark_data=False in run_single(...)[1], the benchmark fails to use weather files again. It looks in Data/Weather/year.

Just spotted a small bug (probably typo) here

Fix: if np.isnan(ccp) and np.isnan(csl)

After installing I changed the working directory in cmd and then tried to run the demo file. I couldn't figure out why I'm getting the error as shown in the picture. Any ideas?