tea-cozy's People
tea-cozy's Issues
Missing space between nav links
The spec calls for space between the nav links in our header. There's no specific pixel value specified, but some is called for. We could use padding/margin to add some space between these items and meet the spec more closely!
https://github.com/lcllarsen/tea-cozy/blob/master/index.html#L13-L17
Nice CSS stylesheet!
Nothing specific here, but good work on your stylesheet. It accomplishes everything needed without any repeated styles or general fluff. It's a readable and clean file! CSS can be tricky so you've done a great job!
Removing .DS_Store from your Git
.DS_Store is an annoying file that pops up often in development projects. One way to remove this from cluttering up your repo is to create a .gitignore file. This file only lives in your local repo and is never shown on your Github. It acts like a text file where we can specify specific files or prefixes to not be included in our commits. Such as .DS_Store.
Here's some more reading on it. Note, this isn't an issue, just something for you to look into!
HTML Indentation (head/body)
Tiny comment, but make sure you indent head and body from your html element as they're children of html. Just something to keep in mind, but a tiny tiny issue :)
https://github.com/lcllarsen/tea-cozy/blob/master/index.html#L2-L8
Location h2 margin
Tiny, tiny spec miss. The spec calls for 15px between the Location h2 and the location boxes. You're using default margin, which on Chrome is ~27px. So we'd just want to add a margin-bottom to the location h2 of 15px to override that.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.