lcsmuller / jsmn-find Goto Github PK

Hi,

during my tests I found a bug in the fix for #20. I had issues with corruption of already declared tokens.

Memset in following code will start at wrong address
memset((tmp) + *(prev_size), 0, (new_size - *(prev_size)) * sizeof *(ptr));

I think correct code should looks like:
memset((tmp) + *(prev_size) * sizeof *(ptr), 0, (new_size - *(prev_size)) * sizeof *(ptr));

Test string: "{"status":"enabled","timestamp":"2023-08-24T07:59:03Z"}\n"
Fails with: JSMN_ERROR_INVAL, unmatched closing bracket

BR,
Diego

Describe the feature

There's not much to gain in making this library depend on jsmn.h to be used. It should be updated as a jsmn fork instead.

Acceptance criteria

• Match jsmn codebase with this lib's syntax rules
• Get rid of unneeded jsmn features
• Rename this lib to json-lookup
• (bonus) Can we get rid of chash dependency aswell? Is it viable?