The ld-emoji from ld-x

ld-emoji's People

Contributors

Watchers

ld-emoji's Issues

Cannot read property 'length' of undefined when pick emoji

So this is quite interesting bug! Sometimes when you click the emoji, this bug appear:

Uncaught TypeError: Cannot read property 'length' of undefined
    at insertTextIntoContentState (insertTextIntoContentState.js:27)
    at Object.replaceText (DraftModifier.js:54)
    at Object.insertText (DraftModifier.js:59)
    at _default.addEmoji (emojiButton.js:67)
    at _default.onEmojiSelect (Picker.js:94)
    at Object.ReactErrorUtils.invokeGuardedCallback (ReactErrorUtils.js:70)
    at executeDispatch (EventPluginUtils.js:85)
    at Object.executeDispatchesInOrder (EventPluginUtils.js:108)
    at executeDispatchesAndRelease (EventPluginHub.js:43)
    at executeDispatchesAndReleaseTopLevel (EventPluginHub.js:54)

At I looked into the code,

      var emoji = e.target.alt; // --> the bug happens when this is undefined
      this.props.onEmojiSelected(emoji);

So for example, the html layout is this:

<span class="ld-emoji hucMvd" role="presentation"><img class="emojione" alt="😄" title=":smile:" src="https://cdn.jsdelivr.net/emojione/assets/png/1f604.png?v=2.2.7"></span>

When you click on the padding spaces between span and img tag, the registered event.target is span not img(so alt will be undefined).
Fix is quite simple, use currentTarget rather than target. I will submit pull request when I have more time

Recommend Projects