The randomjokeapi from leahcimto

randomjokeapi's People

Contributors

Stargazers

Watchers

randomjokeapi's Issues

Use random.choice

randomJokeAPI/main.py

Line 15 in 67f681d

return {"joke":jokes[random.randrange(0, len(jokes))]}

Here, random.choice does the same job:

return  { "joke": random.choice(jokes) }

There is no competition here.
random.choice(jokes) > jokes[random.randrange(0, len(jokes))]

Switch to using a TXT file instead of a JSON file

Currently, you're using a JSON file to store the API, but I think that you should use TXT instead.

It's really easy to switch even, just use

jokes = file.read().split("\n")

in main.py on line 8(also, make sure line 7 uses jokes.txt instead of jokes.json).

Here are some reasons for switching over:

Plain text files are easier to add to, all you need to do is add a new line and type
Smaller file size, but just by a few bytes(it scales more the larger the file gets).

I've also already made it into a txt doc:

What's the best thing about Switzerland? I don't know, but the flag is a big plus.
Someone tells his doctor, "Doc, help me. I'm addicted to Twitter!" The doctor replies, "Sorry, I don't follow you…"
What did the 0 say to the 8? Nice belt!
I used to think the brain was the most important organ. Then I thought, look what's telling me that.
Do you want to hear a construction joke? Sorry, I'm still working on it.
What gets wetter the more it dries? A towel.
How does NASA organize a party? They planet.
Why does Humpty Dumpty love autumn?  Because Humpty Dumpty had a great fall.
Why was the math book sad? Because it had so many problems.
If you see a robbery at an Apple Store does that make you… an iWitness?!
Why did Karen press CTRL + Alt + Delete? She wanted the Task Manager.

Recommend Projects