learn-co-curriculum / dsc-central-limit-theorem-lab Goto Github PK

Link to Canvas

https://learning.flatironschool.com/courses/6852/assignments/251031?module_item_id=592806
https://github.com/learn-co-curriculum/dsc-central-limit-theorem-lab/tree/master

Issue Subtype

• Master branch code
• Solution branch code
• Code tests
• Layout/rendering issue
• Instructions unclear
• Other (explain below)

Describe the Issue

Source

1) Missing "seed" value = 0 in code in all branches.
2) The result of running code in solution branch does not correspond to the right answer.

Concern

(Optional) Proposed Solution

test_sample2 = get_sample(data, 30, 0)

What OS Are You Using?

• OS X
• Windows
• WSL
• Linux
• Saturn Cloud from Canvas

Any Additional Context?

Link to Canvas

https://github.com/learn-co-curriculum/dsc-central-limit-theorem-lab

Issue Subtype

• [x ] Master branch code
• [x ] Solution branch code
• Code tests
• Layout/rendering issue
• [x ] Instructions unclear
• Other (explain below)

Describe the Issue

Source

The examples are numerous throughout this lab. Here's one.
Before we can make use of the normal distribution, we need to first confirm that our data is normally distributed. If it is not, then we'll need to use the Central Limit Theorem to create a sample distribution of sample means that will be normally distributed.

Concern

The lab refers to a sample distribution of sample means instead of a sampling distribution of sample means. The sampling distribution language is used in the Objectives and then reverts to sample throughout the lab. Two labs later in the Confidence Intervals Lab, a distinction is called out between sample and sampling distributions, but this lab seems to ignore this difference.

(Optional) Proposed Solution

Replace instances of sample distribution with sampling distribution when describing the distribution of sample means for consistency with other course material.

What OS Are You Using?

• OS X
• [x ] Windows
• WSL
• Linux
• IllumiDesk

Any Additional Context?

Link to Canvas

Issue Subtype

• Master branch code
• Solution branch code
• Code tests
• Layout/rendering issue
• Instructions unclear
• Other (explain below)

Describe the Issue

Source

Concern

(Optional) Proposed Solution

What OS Are You Using?

• OS X
• Windows
• WSL
• Linux
• Saturn Cloud from Canvas

Any Additional Context?