What I believe is an unintended consequence of using Faker::Name.name is that it occasionally generates an apostrophe in the name. In the way the form gets rendered, the apostrophe becomes an alt-code like so:

• Name: Bria O'Connell

Diff:
@@ -1,2 +1,67 @@

-Bria O'Connell
While I am not certain this isn't intentional, it is a non-repeatable test.

RSpec.describe "classroom_show_view" do
let(:classroom) { Classroom.create(course_name: 'Math', semester: "Spring #{Time.now.year}") }
let(:student){ Student.create(name: 'Bobby', hometown: Faker::Address.city, birthday: Faker::Date.between(25.years.ago, 18.years.ago)) }

before do
5.times do
Student.create(name: Faker::Name.name, hometown: Faker::Address.city, birthday: Faker::Date.between(25.years.ago, 18.years.ago))
end

This lab has issues with the .between() method. If you remove it in the seed file you can then seed. However, the spec tests are relying on the .between() method as well - so many of the tests will not pass either. I did not want to sit and go through them to get the lab to pass.

Gemfile lists faker twice.

Both the seeds.rb file and the relevant rspec files need to have all references to Faker changed so that the portion about Faker::Date has the words "from:" and "to:" included in the between arguments as shown below.

Faker::Date.between(from: 25.years.ago, to: 18.years.ago)

I get the following error message when running rake db:seed in this lab:

thomas.gray:~/flatiron/labs/simple-partials-lab-v-000 [git: master] $ rake db:seed
rake aborted!
ArgumentError: missing keywords: from, to
/Users/thomas.gray/.rvm/gems/ruby-2.6.1/gems/faker-2.2.1/lib/faker/default/date.rb:6:in `between'
/Users/thomas.gray/flatiron/labs/simple-partials-lab-v-000/db/seeds.rb:9:in `block in <top (required)>'
/Users/thomas.gray/flatiron/labs/simple-partials-lab-v-000/db/seeds.rb:8:in `times'
/Users/thomas.gray/flatiron/labs/simple-partials-lab-v-000/db/seeds.rb:8:in `<top (required)>'
/Users/thomas.gray/.rvm/gems/ruby-2.6.1/gems/activesupport-5.0.7.2/lib/active_support/dependencies.rb:287:in `load'
/Users/thomas.gray/.rvm/gems/ruby-2.6.1/gems/activesupport-5.0.7.2/lib/active_support/dependencies.rb:287:in `block in load'
/Users/thomas.gray/.rvm/gems/ruby-2.6.1/gems/activesupport-5.0.7.2/lib/active_support/dependencies.rb:259:in `load_dependency'
/Users/thomas.gray/.rvm/gems/ruby-2.6.1/gems/activesupport-5.0.7.2/lib/active_support/dependencies.rb:287:in `load'
/Users/thomas.gray/.rvm/gems/ruby-2.6.1/gems/railties-5.0.7.2/lib/rails/engine.rb:549:in `load_seed'
/Users/thomas.gray/.rvm/gems/ruby-2.6.1/gems/activerecord-5.0.7.2/lib/active_record/tasks/database_tasks.rb:270:in `load_seed'
/Users/thomas.gray/.rvm/gems/ruby-2.6.1/gems/activerecord-5.0.7.2/lib/active_record/railties/databases.rake:184:in `block (2 levels) in <top (required)>'
/Users/thomas.gray/.rvm/gems/ruby-2.6.1/gems/rake-12.3.3/exe/rake:27:in `<top (required)>'

Tasks: TOP => db:seed
(See full trace by running task with --trace)

The release of version 2.0 of the Faker gem has broken the expectations of db/seeds.rb. The Faker::Date.between method now accepts keyword arguments instead of positional arguments. Faker::Date.between(25.years.ago, 18.years.ago) should be changed to Faker::Date.between(from: 25.years.ago, to: 18.years.ago) (as opposed to updating the Gemfile to use an older version, since it looks like the specs have already been updated to account for this).

"https://github.com/faker-ruby/faker/blob/master/doc/default/date.md" - Nicholas Stephenson

`require "rails_helper"

RSpec.describe "classroom_show_view" do
it "renders classroom information on the show view" do
view.lookup_context.prefixes = %w[students]
student = Student.create(name: 'Bobby', hometown: Faker::Address.city, birthday: Faker::Date.between(from: 25.years.ago, to: 18.years.ago))
#original... the spec syntax is wrong. .between is changed https://github.com/faker-ruby/faker/blob/master/doc/default/date.md
#student = Student.create(name: 'Bobby', hometown: Faker::Address.city, birthday: Faker::Date.between(25.years.ago, 18.years.ago))
assign(:student, student)
render :template => "students/show.html.erb"
expect(rendered).to match /Bobby/
end

it "renders a students/student partial" do
view.lookup_context.prefixes = %w[students]
student = Student.create(name: 'Bobby', hometown: Faker::Address.city, birthday: Faker::Date.between(from: 25.years.ago, to: 18.years.ago))
#original... the spec syntax is wrong. .between is changed https://github.com/faker-ruby/faker/blob/master/doc/default/date.md
#student = Student.create(name: 'Bobby', hometown: Faker::Address.city, birthday: Faker::Date.between(25.years.ago, 18.years.ago))
assign(:student, student)
render :template => "students/show.html.erb"
expect(rendered).to render_template(:partial => "students/_student")
end

it "displays the student information from the partial" do
#original... the spec syntax is wrong. .between is changed https://github.com/faker-ruby/faker/blob/master/doc/default/date.md
#student = Student.create(name: 'Bobby', hometown: Faker::Address.city, birthday: Faker::Date.between(25.years.ago, 18.years.ago))
student = Student.create(name: 'Bobby', hometown: Faker::Address.city, birthday: Faker::Date.between(from: 25.years.ago, to: 18.years.ago))
assign(:student, student)
render :partial => "students/student.html.erb"
expect(rendered).to match /Bobby/
end
`
end

The Faker gem used in the tests now requires from and to to be used with .between.

For example: Faker::Date.between(25.years.ago, 18.years.ago) should be Faker::Date.between(from: 25.years.ago, to: 18.years.ago)

https://github.com/faker-ruby/faker/blob/master/doc/default/date.md

Missing keywords :from and :to in the 80.times do block

Currently:

80.times do
Student.create(name: Faker::Name.name, hometown: Faker::Address.city, birthday: Faker::Date.between(25.years.ago, 18.years.ago))
end

Should be:

80.times do
Student.create(name: Faker::Name.name, hometown: Faker::Address.city, birthday: Faker::Date.between(from: 25.years.ago, to: 18.years.ago))
end

When I did this lab, I discovered that there is a problem in the 'config/routes.rb' file. The line "resources :classrooms only: [:show]" was preventing one of the partials from loading properly in 'classrooms/show.html.erb'. This made one of the tests impassable until I removed "only: [:show]" from the routes file.

In spec/views/classroom_student_spec.rb line 8 and 16 renders:
render :template => "students/show.html.erb"
Should it rather be rendering the classrooms/show?:
render :template => "classrooms/show.html.erb" given that we are testing the classrooms view?

show view tests should be nested under classroom show view

I mistook show_view for student show view.

-Approved by beth urban