There should be a readme covering iteration through an array using forEach prior to the assignment of this lab.

I opened the lab and ran learn. "Passed Local Tests" lights turned green even though the tests failed locally.

Tests should move away from the browser so they work in the IDE

This lab needs clearer specs and change the currentShip property to be the actual ship.

A ship defaults to having its warp drive "disengaged". This test has a crew member engaging warp drive and then expects warp drive to be "disengaged". This should change to "engaged" and then the subsequent test, when warp drive is engaged again, should turn the warp drive back to "disengaged"

The forEach function changes the value of this. To avoid this issue (this issue!), the solution saves a variable that as this prior to the loop. Though this is solution does work, it's not ideal, plus the idea of forEach changing the scope hasn't been explained.

There should either be frontmatter in this lab or in a separate readme that describes what to do when you encounter a scoping issues when working with objects in JS. See this StackOverflow post for more details.

The solution in lib/spaceship.js features this code:

// line 20
function(){
  var that = this;
  this.crew.forEach(function(crewMember){
    crewMember.currentShip = that;
  });
}

Cloaked was before the association between spaceship and crew members. Consider changing order of tests.

if it is fine, just close this issue. Otherwise, raise issues/fix them

space-invaders-spec.js line 74 reads "Ship with a crew a crew member should return their ship when currentShip is called on them".

guessing something is up in the tests.

👋 , ignore me :)

Rewrite this lab so that it's practice with ES6 classes