learn-co-students / javascript-manifests-lab-v-000 Goto Github PK

/home/georgi/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/activesupport-4.2.5.1/lib/active_support/core_ext/numeric/conversions.rb:131:in block (2 levels) in <class:Numeric>' /home/georgi/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/rspec-core-3.8.0/lib/rspec/core/metadata.rb:187:in build_scoped_id_for'

Updating gem 'rails', '4.2.10' in the gem file and running "bundle update rails" fixed the issue.

rails/rails#25125

Is this correct? Per the Readme instructions the manifests should be loaded into their respective layouts. Since the tests do not test against this, the lab still passes regardless of the correct/incorrect manifest loaded in the javascript_include_tag.

Inconsistent syntax required to pass tests:

This passes: <%= javascript_include_tag "admin" %>
This doesn't: <%= javascript_include_tag 'admin' %>

This passes: <%= javascript_include_tag 'main' %>
This doesn't: <%= javascript_include_tag "main" %>

Technically this should pass: <%= javascript_include_tag 'main' 'admin' %>
And this should pass: <%= javascript_include_tag "main" "admin" %>

DRY.

I could never get these tests to pass due to these bundling errors

6 warnings and 2 errors generated.
make: *** [generator.o] Error 1

make failed, exit code 2

An error occurred while installing json (1.8.3), and Bundler cannot continue.

The 3rd test in the admin_manifest_spec requires the hello world file, but actually tests for the doesn_nothing file