Currently the code assumes correct token whitelisting, it would be good to show in the boilerplate how to handle the scenario in which the token is not whitelisted.

It seems tests are broken because of the lack of a function on @LedgerHQ/hw-app-eth. The function it says is not defined is setPluginsLoadConfig.

The failure happens here more precisely

I have tried to update the package to the last version, but it wasn't work. The actual version is 6.7.0 and the last one is 6.18.0.

The stax tests fail when we have msg->numScreens = 8 or more.
The problem is not the amount of screens shown in stax, but somehow if there are 8 itens in the screen or more, it fails with:

...
[*] patching svc instruction at 0x40015668
[*] patching svc instruction at 0x40015676
[*] exit called (255)

We did a small POC forking the repo and adding 8 screens at https://github.com/ChorusOne/stax-failing-poc

The plugin version needs to be checked on init.
See https://github.com/LedgerHQ/app-plugin-lido/blob/cbd0e05b428558491d9b060680ffc4dc107df7c1/src/handle_init_contract.c#L7-L10

Tests are working fine when using the plugin_nanos.elf and plugin_nanox.elf present on the repo. However, if they are built again (using the same process CI does) and replace those new elf files, tests fail immediately. The error the console shows is

[...]
09:19:47.124:seproxyhal: printf: New APDU received:
09:19:47.219:seproxyhal: printf: E004000096048000002C8000003C8000000000000000F9011080843B9ACA00825208947A250D5630B4CF539739DF2C5DACB4C659F2488D88016345785D8A0000B8E47FF36AB50000000000000000000000000000000000000000000000018B1DD9DC51B5A9F7000000000000000000000000000000000000000000000000000000000000008000000000000000000000000015557C8B7246C38EE7
09:19:47.221:seproxyhal: printf: TxType: c0
09:19:47.223:seproxyhal: printf: Current field: 1
09:19:47.225:seproxyhal: printf: Current field: 3
09:19:47.226:seproxyhal: printf: Current field: 4
09:19:47.227:seproxyhal: printf: Current field: 5
09:19:47.229:seproxyhal: printf: Current field: 6
09:19:47.230:seproxyhal: printf: Current field: 7
09:19:47.233:seproxyhal: printf: Selector 7FF36AB5
09:19:47.233:seproxyhal: printf: External plugin will be used
09:19:47.234:seproxyhal: printf: eth_plugin_init
09:19:47.235:seproxyhal: printf: Trying plugin Boilerplate
09:19:47.236:seproxyhal: printf: -- PLUGIN INIT CONTRACT --
[*] patching svc instruction at 0x400007d4
[*] patching svc instruction at 0x40007048
[*] patching svc instruction at 0x40007056
09:19:47.240:seproxyhal: printf: method: 257
09:19:47.241:seproxyhal: printf: pluginstatus 1
09:19:47.242:seproxyhal: printf: Data field forbidden
09:19:47.242:seproxyhal: printf: Custom processor aborted
09:19:47.245:seproxyhal: printf: exception[27264]: LR=0x40000AE1
09:19:47.246:api.api: apdu: unexpected response from device
09:19:47.247:apdu: < 6a80
> b'6a80'

[...]
EthAppPleaseEnableContractData: Please enable Blind signing or Contract data in the Ethereum app Settings
[...]

Procedure:

1. Run tests with existing elf on ./tests/elfs/* with command yarn test
2. Re build them using CI steps

- name: Build plugin for Nano S
        run: |
          make clean
          make BOLOS_SDK=$NANOS_SDK

- name: Build plugin for Nano X
        run: |
          make clean
          make BOLOS_SDK=$NANOX_SDK

3. Replace existing elf with the new ones (renaming the new ones to the correct value)
4. Re run tests using yarn test

It guess the last message is quite important. It might be the cause of the issue, but I am not sure what to do to fix it.

Hi!

I installed the Ledger dev tools plugin, then:

1. Downloaded the docker image inside a fresh app-plugin-boilerplate
2. Clicked "Build" on the extension which successfully finished

Please suggest the steps forward, we want to release our app in the Ledger Live. Thank you!

I want to render this value, but I don't see any instructions for this in the documentation.

try to get it in the following way, but an error is reported.

handle_provide_parameter.c

...
switch (context->next_param) {
        case MIN_AMOUNT_RECEIVED:
            copy_parameter(context->amount_pay,
                            msg->pluginSharedRO->txContent->value.value,
                            sizeof(context->amount_pay));
            copy_parameter(context->amount_received,
                           msg->parameter,
                           sizeof(context->amount_received));
            context->next_param = UNEXPECTED_PARAMETER;
            break;
        // ...
        default:
            PRINTF("Param not supported: %d\n", context->next_param);
            msg->result = ETH_PLUGIN_RESULT_ERROR;
            break;
}

handle_query_contract_ui.c

// ...
amountToString(context->amount_pay, sizeof(context->amount_pay), decimals, ticker, msg->msg, msg->msgLength);
// ...

xxx.test.js

// ...
unsignedTx.value = parseEther("0.0009");
// ...

handle multiple networks in the boilerplate

The nano x build process is broken if you use the latest version of container image.

If you use this version, it works. That version was used on this CI job.

The current job to test plugins is broken. It must be improved.

Process to test plugins is:

• Compile plugins for Nano S and Nano X
• Compile Ethereum app
• Run tests

Building plugins

Compilation of plugin code and Ethereum app are made using a shell script (see https://github.com/LedgerHQ/app-plugin-boilerplate/blob/main/tests/build_local_test_elfs.sh).

However, Ethereum app is never built (see https://github.com/LedgerHQ/app-plugin-boilerplate/runs/5154384831?check_suite_focus=true#step:4:158). Compilation script continues (lol), and only plugins are really compiled. If plugin compilation fails, execution continues.

Binaries for plugin and app for both Nano S and Nano X are in the repo.

Problem with tests

Ethereum app isn't built, so this is the binary app from the repo which is used. If plugin compilation fails, plugin binaries from the repo are used. That means tests will pass.

Ethereum app and plugins in the repo are build with "some" SDK, on a developer's machine.

So, tests are then run using fixed Ethereum binaries, and if plugin compilation fails, tests will always pass.

Solution?

This behavior should be changed. We could clone last version from master on app-ethereum, and compile plugins using this app. However, there is a problem: Ethereum SDK from master is not necessarily the same than Ethereum SDK from plugin. Ethereum SDK is autogenerated and pushed into another repo, and this is a mess.

Any idea on how to solve this problem?