Giter VIP home page Giter VIP logo

ledger-wallet-chrome's Introduction

Ledger Wallet - Chrome App

Installing the build environment

This is the source code of the Ledger Wallet Chrome application. You can build the application package yourself if you want to do the Ledger Wallet initialization on an airgap computer.

To prepare your build environment, follow these steps:

  • Install nodejs
  • Install application dependencies
    • npm install -g gulp
    • npm install

Once the environment is setup, you should see the help page of the build system by typing gulp --help

Building a packaged application crx

To build the application, go to the repo root directory then enter gulp clean build package --release. This will create a crx file into the dist directory.

To install the application on Chrome, go to chrome extensions page (chrome://extensions), then drag and drop the crx file into the page.

Building a zip containing the application

You can build the application and automatically packaging it in a zip file by running gulp clean build zip --release. This will create a zip file into the dist directory

Building the application for another coin

You can build the chrome application for other coins. Run gulp clean build package zip -n *coin_name* --release. Right now you can build for the following coins:

  • bitcoin
  • testnet
  • litecoin
  • litecoin_test
  • dogecoin
  • dogecoin_test
  • zencash

Note: that the API is only available for bitcoin and testnet right now.

ledger-wallet-chrome's People

Contributors

amougel avatar ehteqx avatar ericlarch avatar flodess avatar lastcanal avatar lfbarreto avatar nessnkr avatar nicoodeimos avatar patheticpat avatar pollastri-pierre avatar shivaenigma avatar tarrenj avatar ugilio avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ledger-wallet-chrome's Issues

Browsers?

When will the ledger wallet work with other browsers like brave,firefox and opera?

And when will you add Dogecoin & Litecoin to the ledger wallet? Will it work with all HD wallets that you offer?

FEATURE REQUEST: Multiple Receive Address & Printing

I'm writing a formal procedure for using the Ledger Wallet for cold storage, that basically has the hardware be in a remote safe for long periods of time. Currently Ledger only generates one receive address address until the Ledger software sees UTXO on it to give the next one. I'd like to see the ability to print a page of valid addresses (and maybe QR codes), so that I can have those locally to use to keep each payment to my cold wallet as a separate UTXO on a separate address.

When sending bitcoin don't use an unconfirmed transaction as input

Make it so that when sending bitcoin it uses transactions that have already confirmed as inputs if possible.

Its annoying when creating a transaction with low fee and then another transaction with higher fee
just to find out that i will have to wait for the first transaction to confirm before the second can confirm.

'package' and 'zip' gulp tasks do not complete

Below is the output I am getting (the package task never finished and there is no crx file generated)

~/projects/ledger-wallet-chrome$ gulp clean build package -n testnet --release
[13:15:51] Using gulpfile ~/projects/ledger-wallet-chrome/gulpfile.js
[13:15:51] Starting 'clean'...
[13:15:51] Starting 'build'...
[13:15:51] Starting 'package'...
[13:15:51] Finished 'clean' after 170 ms
[13:16:03] Finished 'build' after 12 s

Cannot send a BCH transaction

Hi,

Using the production app, I am unable to send a BCH (split) transaction from my Ledger Nano S.

  • Start a transaction
  • Setup amount, receiver address and fees
  • Click "Send"
  • Review and approve the transaction on the Ledger Nano S

XHR [400] POST https://api.ledgerwallet.com/blockchain/v2/abc/transactions/send {}

The request body is an empty JSON object.
The response body is {"error":"Missing parameter [tx]"}

This transaction is not urgent or whatever so I didn't get in touch with support, just thought it'd be worth a heads-up to you people.

Thanks,

How to run it?

No information of how it is developed, which technologies are used. Do I really need chrome to run it?

Settings are lost when switching chains

Settings like fiat currency, number of confirmations and standard transaction fee are lost when switching chains. List of transactions seem to mix up / went missing as well.

How to reproduce:

  • start app (select the standard Bitcoin blockchain on first start)
  • connect Ledger Nano S
  • make sure that settings are set e.g. to currency EUR, 3 confirmations, normal confirmation fee.
  • use settings->blockchain to switch to Bitcoin Cash blockchain (optionally restart Ledger Wallet Bitcoin)
  • settings are now back to USD, confirmations are set to 1 and fee is set to high
  • use settings->blockchain to switch back to standard Bitcoin
  • settings are still USD, 1 confirmation, high fee

Sometimes, language and region get also reset to something strange (I'm using German/Germany usually).
The list of transactions seems to get messed up as well. Switching to BCC removes all transactions that were done after the fork (which seems correct), but when switching back to BTC, they don't appear again.

Using settings->tools->reset makes everything working again (until you switch the chain again)

Unable to validate transaction

Unable to send BCC. Message: "Unabled to validate transaction when try to send Bitcoin Cash". It is impossible to send BCC in Ledger. I tried to use a lot of computer, remove and install chrome app, but not solved.

image

Does not build [Win7]

Hi all

Unfortunately I cannot build as described. I setup a clean node.js environment on Windows 7, setup the build environment successfully as described (thanks for the hints!). When running:

gulp clean build package --release

I receive the following error messages:

[22:28:52] Using gulpfile ~\Downloads\ledger-wallet-chrome\gulpfile.js
[22:28:52] Starting 'clean'...
[22:28:52] Starting 'build'...
[22:28:52] Starting 'package'...
[22:28:52] Finished 'clean' after 109 ms
[...]\Downloads\ledger-wallet-chrome\compilation\gulp-flavors.coffee:36
    _ref1 = file.path.match(/.+\/(.+)$/), __ = _ref1[0], filename = _ref1[1];
                                                    ^
TypeError: Cannot read property '0' of null

Could very well be my mistake. Any help would be appreciated!

Send to many

Is this already on the roadmap, or any specific reason why this hasn't been implemented yet. Send to many has several advantages in current high tx fee scenario. Also an ability to upload a csv of address, amount to send would be preferable (like electrum).

[feature request] Native app (eg Electron?)

Google will restrict their chrome apps to only run Chrome notebooks(notebooks running Chrome OS) Ending Windows/Mac support for chrome apps, link: (https://www.windowscentral.com/chrome-apps-support-windows-will-end-2018)
https://blog.chromium.org/2016/08/from-chrome-apps-to-web.html

By replacing the chrome app with a Native app(Electron) before the support ends, anyone will be able to use your app(Linux, Windows & Mac). When will you offer a Native app for the ledger chrome wallet?

Blockchain Explorer Menu Error

The Bitcoin Legacy, UASF, & Segwit2x wallets contain an error in their Blockchain Explorer Menus. Setting the "Default Explorer" to "Blockr.io" leads to Coinbase.com.

Ledger Wallet Bitcoin Chrome App v1.9.6

Create new accounts on the fly

I would like to have the ability to create new accounts in my wallet on the fly, even if none have ever been used. I would like to be able to give out unique addresses to people and not have to wait until one of the addresses is used before I can generate another address. Additionally, for privacy reasons, I would like these addresses to be in different accounts so that their UTXOs are not unintentionally merged as inputs in a new transaction.

I have used wallet before where I could generate addresses on the fly and this would be a really helpful feature to have in Ledger, especially if I could actually generate unique HD accounts on the fly.

Unable to do a ZCash transaction anymore

Hi,

Having latest Nano S firmware, latest updated chrome app.

When trying to do any transaction with the zcash app opened, it leads to an error:

Sending Failed: Unable to validate transaction

After reading the logs, it seams there is an error somewhere:

Tue, 29 Aug 2017 17:12:15 GMT,INFO,Router,Routing to [/wallet/accounts/index#send]
Tue, 29 Aug 2017 17:12:15 GMT,INFO,Transaction,--- CREATE TRANSACTION ---
Tue, 29 Aug 2017 17:12:15 GMT,INFO,Transaction,Amount:  xxxx
Tue, 29 Aug 2017 17:12:15 GMT,INFO,Transaction,Fees:  xxxx
Tue, 29 Aug 2017 17:12:15 GMT,INFO,Transaction,Total send:  xxxx
Tue, 29 Aug 2017 17:12:15 GMT,INFO,Transaction,Address:  t1xxxxxxxx
Tue, 29 Aug 2017 17:12:15 GMT,INFO,Transaction,UTXO:  << stringify error: TypeError: Converting circular structure to JSON >>
Tue, 29 Aug 2017 17:12:15 GMT,INFO,Transaction,Change path:  44'/133'/0'/1/2
Tue, 29 Aug 2017 17:12:15 GMT,INFO,Transaction,Change address:  t1xxxxxxxxx
Tue, 29 Aug 2017 17:12:15 GMT,INFO,Transaction,Data:  undefined

does not connect on high CPU usage

It stays at "To begin, connect and unlock your Ledger Wallet".

This was reported by other users.

https://www.reddit.com/r/ledgerwallet/comments/62ecq6/ledger_bitcoin_wallet_does_not_detect_my_ledger/

But they suspected different causes. They thought it's fault of Parity / Geth. And in some sense that is true. But that is too specific. More generally said, this is happening when CPU usage is near 100%. And parity / geth are causing very high CPU usage so are just another trigger of this bug.

This issue does not happen with ledger wallet ethereum.
This issue does not happen with ledger manager.

So something ledger wallet bitcoin must do different for this issue to happen.

Dist folder is empty

I'm running node 8.90 on OSX. I've made sure I've got all the packages required and I installed gulp globally and also executed npm install at the root of the repo. No matter what build command I use, the dist folder is empty at the end with no error popped out. I've tried to zip the app then. It didn't work either, but I've got some responses here. Nothing clear though:

TypeError: zip.bulk is not a function

Is this an issue caused by gulp (outdated version)?

Ledger Ethereum Wallet does not work after reset of Nano S

I initialised the Nano for first use and all worked fine including the chrome app. Then I re-initialised the Nano by using three times the wrong PIN code to get a new wallet but now the Chrome App does not respond to me attaching the Nano to my computer and unlocking it. I tried to reset the App and delete everything from my chrome default folder, but even after a couple of re-installs it is not reacting. Then I looked in the chrome developer console and I see the messages below appearing in a loop after I connected the Nano.

2016-12-01T22:01:26.051Z V/APDU: => E002000011048000002C8000003C8000000080000000 
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.068Z E/Global: java.lang.Exception: Invalid channel
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.070Z E/Global:   at $c_jl_Exception.$c_jl_Throwable.fillInStackTrace__jl_Throwable(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/library/src/main/scala/scala/scalajs/runtime/StackTrace.scala:33:4)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.071Z E/Global:   at $c_jl_Exception.$c_jl_Throwable.init___T__jl_Throwable(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/javalanglib/src/main/scala/java/lang/Throwables.scala:12:18)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.072Z E/Global:   at java.lang.Exception.<init>(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/javalanglib/src/main/scala/java/lang/Throwables.scala:269:6)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.073Z E/Global:   at co.ledger.wallet.web.ethereum.core.device.LedgerTransportHelper$.unwrapResponseAPDU(../../src/main/scala/co/ledger/wallet/web/ethereum/core/device/LedgerTransportHelper.scala:83:4)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.075Z E/Global:   at {anonymous}()(../../src/main/scala/co/ledger/wallet/web/ethereum/core/device/usb/UsbHidExchangePerformer.scala:80:36)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.076Z E/Global:   at scala.scalajs.runtime.AnonFunction1.apply(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/library/src/main/scala/scala/scalajs/runtime/AnonFunctions.scala:15:37)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.077Z E/Global:   at {anonymous}()(https://raw.githubusercontent.com/scala/scala/v2.11.8/src/library/scala/concurrent/Future.scala:253:25)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.078Z E/Global:   at scala.scalajs.runtime.AnonFunction1.apply(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/library/src/main/scala/scala/scalajs/runtime/AnonFunctions.scala:15:37)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.080Z E/Global:   at scala.concurrent.impl.CallbackRunnable.run(https://raw.githubusercontent.com/scala/scala/v2.11.8/src/library/scala/concurrent/impl/Promise.scala:32:4)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.082Z E/Global:   at {anonymous}()(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/library/src/main/scala/scala/scalajs/concurrent/QueueExecutionContext.scala:39:8)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.086Z E/Global: java.lang.Exception: Invalid channel
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.087Z E/Global:   at $c_jl_Exception.$c_jl_Throwable.fillInStackTrace__jl_Throwable(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/library/src/main/scala/scala/scalajs/runtime/StackTrace.scala:33:4)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.088Z E/Global:   at $c_jl_Exception.$c_jl_Throwable.init___T__jl_Throwable(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/javalanglib/src/main/scala/java/lang/Throwables.scala:12:18)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.089Z E/Global:   at java.lang.Exception.<init>(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/javalanglib/src/main/scala/java/lang/Throwables.scala:269:6)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.091Z E/Global:   at co.ledger.wallet.web.ethereum.core.device.LedgerTransportHelper$.unwrapResponseAPDU(../../src/main/scala/co/ledger/wallet/web/ethereum/core/device/LedgerTransportHelper.scala:83:4)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.093Z E/Global:   at {anonymous}()(../../src/main/scala/co/ledger/wallet/web/ethereum/core/device/usb/UsbHidExchangePerformer.scala:80:36)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.095Z E/Global:   at scala.scalajs.runtime.AnonFunction1.apply(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/library/src/main/scala/scala/scalajs/runtime/AnonFunctions.scala:15:37)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.096Z E/Global:   at {anonymous}()(https://raw.githubusercontent.com/scala/scala/v2.11.8/src/library/scala/concurrent/Future.scala:253:25)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.097Z E/Global:   at scala.scalajs.runtime.AnonFunction1.apply(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/library/src/main/scala/scala/scalajs/runtime/AnonFunctions.scala:15:37)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.098Z E/Global:   at scala.concurrent.impl.CallbackRunnable.run(https://raw.githubusercontent.com/scala/scala/v2.11.8/src/library/scala/concurrent/impl/Promise.scala:32:4)
ledger-wallet-ethereum-chrome-fastopt.js:7348 2016-12-01T22:01:26.100Z E/Global:   at {anonymous}()(https://raw.githubusercontent.com/scala-js/scala-js/v0.6.9/library/src/main/scala/scala/scalajs/concurrent/QueueExecutionContext.scala:39:8)

Application allows z-addresses as destination address [Zcash]

The Chrome app allows the user to send ZEC to z-addresses, which are changed into t-addresses deterministically (by the device during signing?) resulting in a loss of funds since the ZEC never reach the z-address.

The address validator should prevent entering a z-address when sending funds.

Sending is failing when using 1satoshi/byte

How to reproduce
Send bitcoin using custom fee 1 S/B
Result
Sending failed - An error occurred. Please try again later
Environment

  • Chrome extension version 1.9.4
  • Ledger OS 1.0.2
  • Bitcoin Chain (No Segwit)

This should be supported as even 0 satoshi/bytes tx are confirming

[error] $BTC in Ledger nano S couldn't to be sent other blockchain address, error occure and say "sending error later try!"

To Dear Dev. team,

Now closing at Ledger's Slack for security reason, It's sad,
So please I want to check this issue.

(If can, please announce LedgerHQ's security issues to the products' users.)

several problems I found :

problem 1 :
I sent a few BTC from bitFlyer : (a Crypto-Exchanger company in Japan.)

My Ledger nano S's address using my newest version Chrome extension's Ledger Chrome wallet for Bitcoin & Altcoins,
but sending error occured.

(Pop-up alart say "sending error : Leter try" in Japanese language. / 送信失敗 後ほど再試行してください。)

problem 2 :
I send my BTC withdrawal to my Ledger nano S from My bifFlyer's withdraw BTC address.
My Chrome extension Ledger Chrome Wallet received successly,

But Sender Name showed wrong Exchanger name in everytime from bitFlyer
: it displayed "from Coinbase" name.
Why Coinbase ?
I haven't any coinbase account. I guess issue #56 would has the key.

I thought wallet name table unmatch happening.
I tried to fix some problems, but I can't find Ledger wallet, API, node, in GitHub.
There are no codes directly connecting these error.

~~I thoght they could occure probable In LedgerHQ's on-premise in house codes, ~~
Not Open-Source some codes perhaps could need to fix up.
or private repositories in LedgerHQ.

If not, I apporozised all of Dev. team members.

The other side, I found Twitter account : @LedgerHQ tweeted :
https://twitter.com/LedgerHQ/status/928573656283967488

"OVH infrastructure is coming up. Our server infrastructure is now fully functionnal."

But I can't send to bitFlyer's my deposit account address during 3days & still now.
How do I should do?

I want to use My Ledger nano S & Chrome Ledger wallet, send and receice BTC.
That's all now I want.

Please teach me. Please.
My e-mail to LedgerHQ support team, Do you read it? for 4 month ago.
now you do not reply it.

So in here GitHub, please ask some how. :)

my spec data :

Chrome for macOS version 62.0.3202.89(Official Build) (64bit)
macOS version : High Sierra 10.13.1
node.js installed. : node-9.1.0.pkg for Mac (64bit)
npm updated via terminal.
Ledger nano S : device firmware version 1.3.1 / MCU 1.0
Ledger Chrome extension wallet version 1.9.3
using current chain : Bitcoin UASF
Tx fee level : High (speedy confirm)
Sending BTC used MAX deposit button.

ISP attached network 1) : Wi-Fi (WPA2/AES) > AirMac Time Capsule (5GHz Wi-Fi in house(W52))
IP address fetched / internet attached / DNS server address : 8.8.8.8 / 8.8.4.4 / AP name : stealth mode.
mobile wireless Wi-Fi router net attached network 2) : NEC Aterm MR05LN using via NTTdocoomo MVNO's ISP network (5GHz Wi-Fi out of house (W56)) / IP address fetched / internet attached (Ledger Chrome wallet for Bitcoin loaded my received/sent Txs histories. But Not to Send BTCs from my Ledger nano S.
another mobile wireless WiMAX Wi-Fi router 3) : ISP UQ-WiMAX speed Wi-Fi Next WX02 (WiMAX : KDDI hosted UQ-WiMAX corp. mobile high speed Wireless network in JP) : same as 2) above. / IP address fetched / internet attached (Ledger Chrome wallet for Bitcoin loaded my received/sent Txs histories. But Not to Send BTCs from my Ledger nano S.

Wrong decimal separator in generated QR codes

Hi,

I still have the problem discussed in this pull request: #6

The generated QR code is invalid when including a BTC amount, since the decimal separator is wrongly set to , when it should be ..

Any reason why the pull request hasn't been merged / the issue hasn't been fixed yet?

Thank you

Ubuntu 14.04 LTS: Ledger Wallet Nano won't detect

Hi,

I used my ledger wallet at my windows pc and its working great.. but on my ubuntu notebook it didn't works correctly. The Application starts and everything is fine but it throws an console error when i plug my usb stick in:

extensions::sendRequest:82
Unchecked runtime.lastError while running hid.connect: Failed to open HID device.
    at hidDevice.open (chrome-extension://kkdpmhnladdopljabkgpacgpliggeeaf/libs/lw-api-js/btchip-js-api/chromeApp/chromeDevice.js?1428346460262:235:16)
    at chromeDevice.open_async (chrome-extension://kkdpmhnladdopljabkgpacgpliggeeaf/libs/lw-api-js/btchip-js-api/chromeApp/chromeDevice.js?1428346460262:380:10)
    at Class.extend.connect_async (chrome-extension://kkdpmhnladdopljabkgpacgpliggeeaf/libs/lw-api-js/btchip-js-api/chromeApp/ChromeapiPlugupCard.js?1428346460271:44:22)
    at Class.extend.getCard_async (chrome-extension://kkdpmhnladdopljabkgpacgpliggeeaf/libs/lw-api-js/btchip-js-api/ChromeapiPlugupCardTerminal.js?1428346460274:40:29)
    at chrome-extension://kkdpmhnladdopljabkgpacgpliggeeaf/src/managers/wallets_manager.js?1428346460675:49:69
    at chrome-extension://kkdpmhnladdopljabkgpacgpliggeeaf/libs/underscore-min.js?1428346460124:5:7954

Hope you guys can fix that.

FEATURE REQUST: Signing newly created addresses

This is based on a conversation with @gmaxwell yesterday:

There have in the past been a number of bugs in code in the creation of addresses, many of which are intermittent (one in 256 in one of his examples, in other the Electrum wallet would create a bad address if a block was received at exactly the same time). Thus as a general practice, he signs an address with its own private key and then verifies that its signature is valid. He says that bitcoind now does this internally every time it creates a new address.

I'd like confirm that the ledger bitcoin app does best practice this like bitcoind app does, i.e. double checking that the address is valid. Secondly, I'd like to see that this entire package (signed address) be sent to the chrome app, and that the chrome app also checks it. Finally, a small user interface icon next to an address can be clicked on to open a popup with the signed address text, allowing this signed address to be verified by other apps besides the chrome app (for instance, verifiable by the person sending me funds).

Email notification and 2FA

Hey
I am not entirely sure if its technically possible but who knows I might as well try..

Is it possible to get an email notification with every login to my wallet? I know it might make my mail box full but it would make me sleep better at night..

Also, how about email 2FA when sending transections?

Thank you very much!

Enhancement: Remember my choice of blockchain for BTC and BCH separately

It is a HUGE pain right now to manage both Bitcoin and BitcoinCash with the Nano S + Chrome wallet. Currently, switching from BTC to BCH (or vice versa) requires:

  • Opening the correct app on the Nano S device
  • Selecting the desired block chain
  • Selecting Legacy vs. Segwit (for BTC) or Main vs. Split (for BCH)

This is a ton of steps for something as simple as checking a wallet balance, mostly because the "Remember my choice" option only applies to which blockchain should be selected, but it affects both BTC and BCH, which doesn't make sense.

Proposal for what should be enhanced:

  • Opening the BitcoinCash app on the Nano S should automatically select the BitcoinCash blockchain, as it is the only valid chain currently in existence for BCH (please correct me if I am wrong about this).
  • Selecting Legacy vs. Segwit and Main vs. Split should have a "Remember my choice" option, just as the selection screen for the Bitcoin blockchain does. (This could also be implemented as simply no longer prompting once the user selects Segwit or Split, as I believe once those are selected it doesn't make sense to go back to the other option. Again please correct me if I am wrong here.)

Thanks.

Issues with 2FA when signing transactions.

I have encountered several attempts to sign transactions using the iPhone ledger app recently. Here are issues I've encountered while attempting to sign different transactions:

  1. If the mobile app is not in the foreground, a notification is presented, but when tapping on the notification to reveal the application, there is no prompt to authorize the transaction. I have to cancel the transaction from my desktop machine and try again with the ledger mobile app in the foreground.
  2. If the mobile app is in the foreground, I get a prompt to authorize the transaction, but upon authorizing the transaction and receiving a success message on my desktop machine, the transaction does not seem to be present.
  3. When attempting to sign a transaction from my desktop machine, the signing process hangs before attempting the 2FA.

Error when submitting transaction

Hello,
I am trying to perform a BTC transaction with the Chrome app. When I press "Send", a loading bar appears for a second, after which the following error appears: http://imgur.com/diQeX3B

On the device I get the standard choice to allow or deny the transaction, however when I allow it the Chrome app just closes and goes back to the screen that says "To begin, connect and unlock your Ledger Wallet". I then have to restart the app and browser to go back to the overview.

In the log file I see the following message:

Mon, 19 Jun 2017 21:23:23 GMT,INFO,Router,Routing to [/wallet/accounts/index#send]
Mon, 19 Jun 2017 21:23:23 GMT,INFO,Transaction,--- CREATE TRANSACTION ---
Mon, 19 Jun 2017 21:23:23 GMT,INFO,Transaction,Amount:  6043600
Mon, 19 Jun 2017 21:23:23 GMT,INFO,Transaction,Fees:  45400
Mon, 19 Jun 2017 21:23:23 GMT,INFO,Transaction,Total send:  108337904
Mon, 19 Jun 2017 21:23:23 GMT,INFO,Transaction,Address:  3*****f
Mon, 19 Jun 2017 21:23:23 GMT,INFO,Transaction,UTXO:  << stringify error: TypeError: Converting circular structure to JSON >>
Mon, 19 Jun 2017 21:23:23 GMT,INFO,Transaction,Change path:  44'/0'/0'/1/3
Mon, 19 Jun 2017 21:23:23 GMT,INFO,Transaction,Data:  undefined

I am using the latest firmware and wallet version. Could you look into this error? Thank you.

Ledger Wallet Self-Opens

So, maybe it's not "self opening", but I've been having this issue where randomly Ledger wallet will pop up. I do not know what causes it to do this, but it's happened a few times now. And each time I just uninstall the extension. I can't help you replicate this error locally, but it is an issue I have encountered. It may be related to malware even.

Add an initialization script in order to install nodejs dependencies

After following the proposed installation instructions on my setup (Ubuntu 14.04 LTS with a NodeJS fresh install) I was unable to compile the *.crx file, before manually installing as dependencies all the required packages with npm.

A proposed solution could be to implement a simple shell script (at least for Linux, I don't know if the problem still applies to Windows or MacOS) to initialize the build system before starting the building process.

The attached file is an example.

EDIT: I am not able to attach a *.sh file. It can be fetched from my fork: https://github.com/ehteqx/ledger-wallet-chrome/blob/master/initialize.sh

Failed sending Qtum

Hi,
Glad to hear that Ledger supports Qtum.

I am using Ledger Wallet Bitcoin 1.9.11 to send Qtum.
I input the receiver address and amount, and didn't change any values else in the send page.
It told me "Sending success" the first time, but the tx is never confirmed, i cannot find the txid at qtum explorer either.

The next time it told me "SENDING FAILED An error occured. Please try again".
I tried many times, the same issue.

Litecoin

When will you create a separate Ledger Litecoin Wallet app?

Support or Sweep from popular alternative BIP32 paths

Breadwallet (and I think Copay) mobile wallets appear to use an alternative BIP32 path (reportedly m/0'/0/0). If I use share my recovery phrase between them they see the funds and change (great for testing).

However, when I set up my ledger to use my recovery phrase from Breadwallet/Copy, and after recovery the Ledger doesn't see the funds that are also held by that root.

You maybe should look during the first use of wallet at some popular paths and either warn users (who might think their funds are lost), and either allow the user to sweep into your BIP44 paths, or support the alternative paths of popular wallets for at least spending any addresses with amounts until they are all empty.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.