Comments (4)
hey @clarfon
one thing that i'd like to retain for dropcss is its straightforward nature: if it is not literally in the html string, then it's getting chopped. as you mentioned, shouldDrop easily solves this case. the overwhelming majority of html out there does not rely on implicit tag insertion, and the tiny byte savings are never worth it.
in addition to implicit body, there is also implicit tbody [1], which is actually the much more common case. nevertheless i'd like to keep the magic minimal as long as a userland solution is simple and obvious (or documented).
[1] https://codepen.io/anon/pen/ZgzEdv
from dropcss.
Note: as a workaround, you can modify the shouldDrop
option to include a whitelist of rules. This is a bit of extra work unless you're already using a whitelist, though.
from dropcss.
That is very fair; I don't think it'd be reasonable to ask for this change unless someone came out there with the code or a compelling use case.
Feel free to close as wontfix if you think this would never happen.
from dropcss.
i'm going to leave everything explicit. i've added a note about this to the intro. thanks!
from dropcss.
Related Issues (20)
- unquoted last attr breaks html parser HOT 5
- attributes with : HOT 5
- Gulp task HOT 1
- support custom property fallback values
- PostCSS plugin HOT 5
- Nextjs integration example HOT 4
- didRetain() instead of result.sels HOT 2
- Using DropCSS with a Ghost blog HOT 1
- didRetain missing in npm published version HOT 3
- Enable hooks to drop / retain individual css declarations HOT 1
- As a postcss plugin ? HOT 1
- Whitespace inside a closing html tag breaks the parser HOT 6
- `NASTIES` regex incorrectly matches custom elements HOT 2
- Trying to get in touch regarding a security issue HOT 1
- new selectors and nesting HOT 1
- css selector parser cannot advance past unsupported pseudo classes with parenthesis HOT 7
- Class names containing html/body/head do not get dropped HOT 2
- Version Drift HOT 1
- Cannot read property '1' of null HOT 1
- Infinite loop on ":where" selector HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dropcss.