Giter VIP home page Giter VIP logo

Comments (4)

leeoniya avatar leeoniya commented on May 15, 2024 1

yeah i've considered doing this. but the size gain would be small while the speed hit would be exponential and there would be perf landmines everywhere. a single *, :not(.foo), div:nth-of-type(3) and you're in for a bad time.

i'd like to see a convincing practical case on a realistic mid-size page where the wins outweigh the costs.

from dropcss.

clarfonthey avatar clarfonthey commented on May 15, 2024

I feel like it'd be fairly easy to memoize the results and make it more efficient, although it'll still be way slower than if it weren't added. That said, I haven't looked to hard at the code and don't know how exactly that would be done.

I mostly put the issue here to see if there were decent use cases; maybe someone out there has a compelling example. :p

from dropcss.

leeoniya avatar leeoniya commented on May 15, 2024

let's work through it on paper. the main idea is to ensure that a less qualified selector results in the same nodes as the full one. take #a .b > c.foo. step one is to get a full set of nodes, let's call it Set0. we then try to reduce the qualifiers right-to-left and test for equivalence to Set0:

.foo
c
c.foo
.b > c
.b > c.foo
.b > .foo
...
...
#a b > .foo
#a c.foo
#a c
#a .foo

essentially it's a powerset of sub-selectors:

https://stackoverflow.com/questions/42773836/how-to-find-all-subsets-of-a-set-in-javascript/42774138#42774138

let sets = generatePowerSet([
  "#a ",
  ".b >"
  "c",
  ".foo",
]);

with the condition that at least c or .foo is part of the set, which probably means that ["c", ".foo"] has to be a sub-powerset.

and this is just for a single selector. memoization (which dropcss uses extensively) won't really help you too much here. dropcss actually has all the internal functions needed: a selector parser, an html parser, and a matcher that can test a parsed selector against the parsed html. if you are interested in prototyping this and doing the memoization externally, i can expose each of these functions and it would simply be a matter of mutating the parsed selector array to test each case. this would also go a long way towards what's needed for #32.

from dropcss.

leeoniya avatar leeoniya commented on May 15, 2024

i'm actually not sure this is going to work out even if all the above is done. the reason is that selector specificity matters. even if you can match the same set of elements in isolation, the order of your rules may prevent the same application of styles, and figuring out how to avoid this is simply not feasible without basically writing a spec-compliant CSS engine.

an easy example of this is removing li from li.foo in [1]. in isolation it would still only match a single element, but would fail to apply the styling.

[1] https://codepen.io/anon/pen/zgverp

from dropcss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.