legobmw99 / betterthanmending Goto Github PK

The With Sprinkles mod comes with an enchantment called Multiple. It allows an item to be enchanted with multiple sets of enchantments. Shift+r-click is used to switch between sets. This combination results in items having to be fully repaired before being able to switch sets, defeating the purpose of your mod. Would it be possible to add a hotkey? I have also posted this suggestion/conflict on With Sprinkles GitHub.

Can I Request for a config which would allow you how much xp is converted into durability? like x0.5 of vanilla's durability is restored when right clicking

Holding shift and right clicking with a fishing rod in hand will throw the bobber instead of repairing the rod

I have Fabrication, which uses shift+right click on tools as well. If both actions can take place, Better than Mending wins, which is a bit frustrating if I don't want to repair my tool, and what I need to do is waste all my xp before using Fabrication's feature (which is swapping between fortune and silk touch).

It would be nice if there could be a configurable keybind to make both mods compatible.

Already asked the other mod's dev as well

I'm not able to get the most recent forge version to work on my server. It works fine in singleplayer (even with other mods), but if I load the server with just this mod (on both server and client) it does not work. The fabric version worked when I tested it, so it seems to be a forge specific problem. Any ideas? Note: I have posted the same issue on the Twitch page.

crash-2020-02-16_00.27.06-server.txt
Crash report here

Hi,

Could you please mark BetterThanMending Fabric compatible with 1.19.3 in Modrinth?
This helps the mod to be update from ferium or MultiMC, Prism launchers.

Thanks

After I installed this mod the crafting table, blast furnace and enchanting table wouldn't let me access them. I could get in a regular furnace, grindstone and cartography table. I am using 1.16.1 forge version.

Port for fabric 1.18.2

Version 1.18.2. I would like to know if there's a like a way to find out what mod is disabling it, like log checking for something in specific or idk? Or does it not work for 1.18.2?

It'll take me a good minute for me to shift n' right-click for the pickaxe to get repaired. I don't know whether or not it's supposed to be like this but, I would love to see a fix for this. Thanks!

I noticed that the mod works just fine when using xp that I acquire through game play or an Bottle o' Enchanting, basically any orbs I directly pick up. I made a function command project that stores my xp and any xp retrieved from the command, xp 1L @p, does not work. I added GlobalXP mod to help troubleshoot and it seems to have the same issue with acquired vs given xp. I am wondering if the previously reported issues are with mods that give/take xp in a way that causes this.

UseItemCallback.EVENT will cancel furthur callbacks when former callback doesn't return pass. Suggest use Event#register(net.minecraft.util.Identifier, T) instead of Event#register(T) to provide a way for other mods to adjust the callback order.

There were apparently some breaking changes in forge .94 and it seems Better than mending was affected.
Crashes on eating.

log appended.
crash-2022-07-15_20.33.53-client.txt

I tried different downloads (Better than mending from different locations) but there is no new button on my enchantment table (enchanting plus mod). Both Mods are 1.12.2.
Does anybody know what i can try to get the repair button?

Thanks!

Version: Forge 1.16.5

I went through both the code and the issues to figure out which side I need to install the mod on, but I couldn't figure it out.
So, I was wondering if I could ask about it.

I'm using modrobot to update all my mods and the comment in fabric.mod.json is not compatible with modrobot. Can you remove it?
Thanks!

I'm looking for a mod that makes items with mending on them unbreakable. For instance, a pick at 1 durability does not work until repaired, but does not get destroyed. Optimally I would like for it to be a part of this mod, but if you cannot do it or are not interested, I will try my luck on the forums. Thanks.

BTW...This mod is genius.

BetterThanMending-1.1.1.jar
forge-14.23.3.2691

I have this mod on both server and client, and the mod seemed to work fine, Shift+Left Click was mending my items (I have my mouse buttons reversed) for the first day on the server. However, it has stopped working. I can pick up XP orbs, and mend my items. I can repair them with materials and anvils. Shift+Click is no longer repairing my tools.

I've tried with vanilla and modded tools. I've tried with/without armor on. I've tried with/without items in off-hand. I've even unbound other mods' keybinds that were conflicting with Sneak and/or Use Item.

The mod just simply stopped working.

Wing with mending from 'Wings' mod equips it instead of repairing. 1.12.2.

The Mending Levels mod gives Mending multiple levels, where higher levels correspond to more repair for the same XP. In my testing, this mod does not interact with Mending Levels at all. More specifically, using Better Than Mending to mend a gold shovel added 4 durability per right click at both level I and level V enchantments.

I was using BTM v1.3.0 and ML v1.0.1 on Minecraft 1.18.2 with Quilt 0.17.2-beta.2

There's a bunch of clientside stuff being loaded including CPlayerTryUseItemPacket and Minecraft that happens when the player rightclick/shifts a mending item.
2019-09-07-3.log

On "MC 1.14 FABRIC - BetterThanMending 1.0.0", if a purely vanilla player tries to shift+right click to repair a tool that has mending on it, the server will crash.

Hi there. We are using this mod on a quite technical server, which means we have an abundance of experience. I think it would be a nice nerf, if there was a possibility/setting to have the mending consume based on levels rather than xp, thus making repairing at higher levels more expensive.
We are often at hundreds of levels where the xp consumption doesn't even make a dent in our level bar, which feels rather unfair..

Hello,

this line uses client-side specific code but is run on the server-side too. Which causes this exception:

java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: net/minecraft/client/Minecraft
 at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_72]
 at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_72]
 at net.minecraft.util.Util.func_181617_a(SourceFile:46) [h.class:?]
 at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:668) [MinecraftServer.class:?]
 at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:387) [ld.class:?]
 at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:613) [MinecraftServer.class:?]
 at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:471) [MinecraftServer.class:?]
 at java.lang.Thread.run(Thread.java:745) [?:1.8.0_72]
Caused by: java.lang.NoClassDefFoundError: net/minecraft/client/Minecraft
 at com.legobmw99.BetterThanMending.handlers.BTMEventHandler.onItemUse(BTMEventHandler.java:45) ~[BTMEventHandler.class:?]
 at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_406_BTMEventHandler_onItemUse_RightClickItem.invoke(.dynamic) ~[?:?]
 at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
 at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) ~[EventBus.class:?]
 at net.minecraftforge.common.ForgeHooks.onItemRightClick(ForgeHooks.java:1013) ~[ForgeHooks.class:?]
 at net.minecraft.server.management.PlayerInteractionManager.func_187250_a(PlayerInteractionManager.java:362) ~[lv.class:?]
 at net.minecraft.network.NetHandlerPlayServer.func_147346_a(NetHandlerPlayServer.java:710) ~[me.class:?]
 at net.minecraft.network.play.client.CPacketPlayerTryUseItem.func_148833_a(SourceFile:32) ~[jk.class:?]
 at net.minecraft.network.play.client.CPacketPlayerTryUseItem.func_148833_a(SourceFile:9) ~[jk.class:?]
 at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) ~[fl$1.class:?]
 at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_72]
 at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_72]
 at net.minecraft.util.Util.func_181617_a(SourceFile:45) ~[h.class:?]
 ... 5 more

The server-side compatible way to check if a player is sneaking is event.getEntityPlayer().isSneaking()