lemonade-hq / traf Goto Github PK

Hi!
Thanks for the tool 🙂
I recommend that you open the discussion section for Q&A.

I have an nx workspace with buildable apps that consume non-buildable packages.
Looking at the code these packages are filtered out which causes the command to not work properly.
The tsconfig path can be easily resolved once you have the project path.

what is the command to run nx affected:graph ?

Both in NX and Traf right now, if I change for example the package.json of a library (which can affect its build) - it doesn't end up in the "affected" list, hence I need to manually change something silly in the code (a comment, ordering) in order to trigger a build.

Can we somehow add that these kind of changes do count as "affected"? it doesn't need to add into the affected results the libraries that depend on my change, but only the library itself

When using regular nx print-affected you have an option to specify the --type option which allows you to filter only libs or only apps from the output.

It would be good to have a similar interface in traf so @traf/nx affected could be used as almost a drop-in replacement for nx print-affected.

Another option would be to specify in the JSON output the type of project so that users could filter it themselves but this approach is a breaking change as @traf/nx affected --json=true results in a JSON array with names of projects (array of strings).

Hi,

Thanks for building this tool. I wanted to test this on my monorepo to see how it works. Unfortunately, I can't run the base command npx @traf/nx@latest affected as there is some issue with finding the project root.

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:387:5)
    at validateString (node:internal/validators:121:11)
    at join (node:path:1172:7)
    at file:///Users/arkus/Projects/<project-name>/node_modules/@traf/nx/cli.js:237:27
    at Array.map (<anonymous>)
    at getNxTrueAffectedProjects (file:///Users/arkus/Projects/<project-name>/node_modules/@traf/nx/cli.js:233:19)
    at async affectedAction (file:///Users/arkus/Projects/<project-name>/node_modules/@traf/nx/cli.js:271:20)
    at async Object.handler (file:///Users/arkus/Projects/<project-name>/node_modules/@traf/nx/cli.js:361:5)

So it seems the issue is in this line

It seems like in my project the types are a bit different than traf expects them to be.

When I run the CLI command on my project, the project (which is expected to be of NxProject type) is just a string with the path to the project directory.

If I understood it correctly, the projects come from the workspace.json file, which is (at least for me) a map of { [projectName]: [pathToTheProject] }.

Is there something I'm missing in my setup to allow this tool to work? I updated the nx version to the 16.2.2 as it's here in package.json dependencies, but no luck.

Hi,

The affected projects support for package lock changes is currently experimental, but when I tried with the experimental flag, it does not return the expected output.

I am using Nx version 18.2.3. I have 2 packages (is-even and is-odd) and 1 app (products) in my Nx integrated monorepo. The is-even package is being used by the products app.
When I upgrade a dependency (for exp - lodash) in is-even package.json, and run the affected command, it does not return the app name which will be affected for sure.

Expected output -
is-even
products

Received output -
Empty or is-even after making a few changes in the traf package code.

Hi,

In Angular a component can be sperated into .ts and .html ( AKA template file ), I noticed that if I only make a change to the template file it doesn't pick up any affected libs.