leonardr / cce-python Goto Github PK

I'm running Python 2.7. When I run script 2-match-renewals.py I see this error:

Traceback (most recent call last):
  File "2-match-renewals.py", line 52, in <module>
    comparator = Comparator("output/1-parsed-renewals.ndjson")
  File "/home/dmeyer/ghcode/cce-python/compare.py", line 15, in __init__
    r = r.replace("-", "")
AttributeError: 'NoneType' object has no attribute 'replace'

This appears to be hit wherever there is a "regnum": null in output/1-parsed-renewals.ndjson.

It looks like it could be fixed either by ensuring that when there is no regnum in the parsed renewals you put an empty list instead of None; or you could robustify the Comparator init's for r in regnum loop to continue if r is None, avoiding the r = r.replace("-", "") for a null r.

Let's say we've got an A record with no renewal. The place of publication doesn't look foreign. Public domain, right?

Except, there's also a renewal for a seemingly unrelated AI or AF record which points to the A record. That indicates the work was originally a foreign publication, and its copyright was automatically restored by treaty.

The A record itself may also say something like "Prev pub. AF12345" -- another indication that it was originally a foreign publication.