leonidessaguisagjr / filehash Goto Github PK

The Md5sum files (*.md5) I am working with are failing verification when I use FileHash.verify_checksums(), because they are separated with two spaces:

% cat something-or-other-arch-v0.0.1.tar.gz.md5
595f44fec1e92a71d3e9e77456ba80d1  something-or-other-arch-v0.0.1.tar.gz

This is the error I get:

FileNotFoundError: [Errno 2] No such file or directory: ' something-or-other-arch-v0.0.1.tar.gz'

The output of the md5sum utility is described here:

https://en.wikipedia.org/wiki/Md5sum

Hi,

I would like to ask why would we observe this error? Is there any workaround?

Before compilation, we can calc the hash. Please see below.
/Windows\System32\test.txt
SHA1= 403926033d001b5279df37cbbe5287b7c7c267fa

After compiltation, the compiled exe program throw the following error.
Error: [Errno 2] No such file or directory: '/Windows\System32\test.txt'

On MacOS, "sha256sum" generates a file with two spaces between the hash and the filename. This causes filehash to fail verification while sha256sum works fine. This is due to the fact that text files are marked with a " " / space, and binary files with "*":
https://linux.die.net/man/1/sha256sum

To replicate, run the following commands:

cd testdata/
sha256sum *.zip >mac_test.txt
sha256sum --check mac_test.txt
chkfilehash -c mac_test.txt

Output from sha256sum:

lorem_ipsum.zip: OK

Output from fileshash:

Traceback (most recent call last):
  File "/usr/local/bin/chkfilehash", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/filehash/filehash_cli.py", line 100, in main
    process_checksum_file(args.checksums, hasher)
  File "/usr/local/lib/python3.9/site-packages/filehash/filehash_cli.py", line 82, in process_checksum_file
    results = hasher.verify_checksums(checksum_filename)
  File "/usr/local/lib/python3.9/site-packages/filehash/filehash.py", line 268, in verify_checksums
    actual_hash = self.hash_file(filename)
  File "/usr/local/lib/python3.9/site-packages/filehash/filehash.py", line 176, in hash_file
    with open(filename, mode="rb", buffering=0) as fp:
FileNotFoundError: [Errno 2] No such file or directory: ' lorem_ipsum.zip'
```

Changing directories before I verify is not a big deal when using a shell and verifying manually. But if I'm reaching for Python, chances are I'm either verifying a large number of multiple packages, or I'm writing a script to automate.

Either way, it seems like something a library should be handling for me.

Currently, this is required (I'm sure others could do it with less mess):

checksum_path = './relpath/package.md5'
orig = os.currdir
os.chdir(os.path.dirname(checksum_path))
filehash.verify_checksums(os.path.basename(checksum_path))
os.chdir(orig)

If checksums were always evaluated from the directory they're in, I could do this:

checksum_path = './relpath/package.md5'
filehash.verify_checksums(checksum_path)

Is it possible to add support for other algoriths provided by hashlib:
https://docs.python.org/3/library/hashlib.html

These would include SHA-224 and SHA-384. Better yet include all supported algorithm that hashlib provides.