letusneil / movery Goto Github PK

Implement unit tests.

• (Code) No comments (Default template)
• (Code) (Minor) In MoveryApp.onCreate(), Realm and Timber init code can be extracted to a separate method
• (Code) (Minor) Dimensions can be extracted to values
• (Code) (Critical) Network request not cancelled when lifecycle ended
• (Style) (Minor) NetworkModule.BASE_URL, can be in Constants
• (Style) (Minor) Comments are great in types and methods, inline comments can hint of code smell.
• (Style) (Major) Some methods are too long and clunky. (Method extraction recommended)
• (Style) (Major) DetailsFragment 'setUpDetailsAndMap' and setUpDetailsAndMap contains duplicate code (Method extraction recommended)
• Try to reduce layout hirearchy whenever possible. e.g.: fragment_deliveries, 'activity_details' does not need root ConstraintLayout
• FragmentTransaction and Intent calls can be chained to make the code cleaner
• RealmObject doesn't play nice with Parcelable, it can cause potential bug.
• Data Binding and/or ButterKnife can be used to reduce boiler plate

Implement pagination. Requires some changes from the JSONStub.