level12 / keg-login Goto Github PK

By just importing the package an application should be able to get to the base object (KegLogin) this means promoting them to the package __init__ file. __all__ should also be in there to denote what is exposed.

It doesn't seem best that we have to init_app() both KegLogin and flask_login.LoginManager.

Seems like with the stuff SA can do, we could probably create a password column type that would hash when setting and verify when doing an equality comparison.

Why do we have a base.html and a keg-login-base.html

I haven't tested this specifically, but I was a part of the conversation over on the Django tracker where much of this code was borrowed from.

This is the ticket: https://code.djangoproject.com/ticket/28248

Basically, instead of being 1 day, and maybe 2. It is no more than 1 day and maybe just 1 second.

You might want to make sure the resent token is not susceptible to this.

The flask.ext feature is deprecated, we should use flask_ext.

• https://github.com/level12/keg-login/blob/master/keg_login/forms.py#L1
• https://github.com/level12/keg-login/blob/master/keg_login/views.py#L4

This needs to be renamed to support the correct install name.

Any reason we need three nested div's in base? https://github.com/level12/keg-login/blob/master/keg_login/templates/keg-login/base.html