leveluptuts / fresh Goto Github PK

if nothing is chosen in a select field then the number 0 is returned instead of the name of the first option. (There is also no concept of a default value for selects, only the list of options)

If the form should clear when you submit, OR just do nothing (default)

In the case that a user gives no default values, the number fields return an empty string instead of a null value.

When the cancel button that comes with the field component is clicked the whole input field disappears

Field type="textarea" no longer works after being changed to Field type="textArea". This either needs changed back to textarea or made to work with both camel case or all lowercase.

if i was to have the following:

defaultValues = {
videoId: '123'
}
<Form defaultValues={defaultValues} onSubmit={onSubmit} >
  <Field>Video Id</Field>
</Form>

the data on submit would consist of both videoId and video-id.

It would be nice to always have fields default as camelCase instead of kebab to avoid this problem

defaultValue should be returned as false instead of null for toggles

Would love to have this basic style of date picker reimplemented in Fresh.

https://github.com/vk-lab/react-month-picker-input

prettier/prettier@172d34e

Form input fields not loading if the form is loaded on a component without a page reload/refresh.
I have replicated the issue on codepen here;
https://codesandbox.io/s/basic-form-forked-1h031?file=/src/App.js

Same when using react-router and not reloading the app pages within navigations.

Some fields are not actually required even if passing the required prop

need to return false instead of "" when toggle is switched off

Hello Can you please add a validation object like defaults value we need to add a field that let you do validation in it , like formik if you play with it you will see that he add a validation object with yup can you do that please .
thank you for this library i like it soo much and it simple to work with

It would be nice to use a custom function for the cancel button to do something such as close a modal, not just clear the form

A field that looks kinda like a table.

0 | 1 | 2 | 3 as a horizontal radio select. Commonly seen in surveys

It would be nice to be able to use custom placeholder text in input fields.

Fields need a TooltipBackground and TooltipColor prop

Ability to make any field type an array of fields.

Would love to have this audited for accessibility before it's ready for v1. I'm not an expert on form accessibility myself, but I'll enable eslint rules in the meantime.

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet.
We recommend using:

• CircleCI
• Travis CI
• Buildkite
• CodeShip
• Azure Pipelines
• TeamCity
• Buddy
• AppVeyor
  But Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

Would be nice to have easy to follow classes and IDs on all elements for style overrides, testing, etc

No need to have it as a dependancy.

if a Field is given a name prop it should be used in place of the text in the Field for a value on the data object to submit

Would be nice to pass custom defaultValues as props to fields in the form

Not sure where the heft is coming from. Removed Styled components, will plan on slimming this down as much as possible. I'm guessing it's from a dep.

It would be nice to pass a prop and use custom text for submit/cancel.

Would be nice to have an optional "?" icon with a tooltip that shows up when hovering labels.

For some inputs, instead of the className (for example, 'fresh-input'), an empty prop of class is coming through.

There are also other empty and unnecessary props such as placeholder (as shown in screenshot) coming through for a lot of the complex fields

The icon shows but now tooltip comes up

Pushing 'Cancel' with a fully filled out form only clears the last input in the form, not all of them.

This looks funky

would be nice if they stack on mobile too

If people want to customize the input styles it would be nice to have either documentation on the classes used for the form and inputs or a css file to download where styles can be edited

If a defaultValue for a text input is ' ' (an empty string), then on form submit, the value is returned as null instead of an empty string.