lexmanos / chunknogobyebye Goto Github PK

On our 1.14.4 server we noticed that crops weren't growing and sheep weren't regrowing wool in chunk loaded areas using this mod. Some things (like refined storage remote connections) were working correctly, so I think maybe the chunk is loaded but not ticking?

I also tested this in a single player world with all other mods removed. I set up a crop of wheat beside this chunk loader, then afk in a distant location. Each time I return, the crops have not grown at all.

Forge version 1.14.4 28.2.0
chunknogobyebye-1.14.4-1.0.3

Hi, I can't open my server since I've placed Chunk Loaders in the overworld and in the mining dimension from JAMD to make sure my mining turtles won’t stop working. Since then, my server doesn't want to fully start, it stops at :
[Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer/]: No chunks were marked for force loading (See attached log).
And when I try to connect it says :
[Netty Server IO #1/INFO] [net.minecraftforge.fml.server.ServerLifecycleHooks/SERVERHOOKS]: Disconnecting Player (server is still starting): Server is still starting! Please wait before reconnecting..

I've tried inputting /fml confirm as it worked for some people in other forums but the terminal is completely frozen, even the command "stop" doesn't do anything.

I know it's related to this mod because it starts correctly when I remove the mod from the server.

Attached log :
2022-04-24_ChunkLoader_Error.log

I'm using Direwolf20 1.16 versions 1.13.2 modpack and the server run on 5Gb of RAM and I haven't got any issue with it before.

Thanks!

Whilst chunks can be unmarked when item is destroyed in the end, chunks are not marked when the item is put down.

I routinely forget where I have placed chunk loaders, because I usually put them under a build, behind a wall, etc. I would love it if there were some kind of item that I could have which could tell me if the chunk I am standing in is force-loaded. It doesn't have to have a gui or be any kind of fancy. I'm imagining something like the clock, with the dial being one of the following:

Gray: chunk is not force-loaded
Pink (matching the color on the chunk loaders themselves): chunk is force-loaded by CNGBB
Green: chunk is force-loaded as part of the world spawn area

Just wanted to start by saying thank you! Your code made it easy for me to figure out a few concepts when porting Persistent Bits over to 1.14. In the process, I found a few tweaks/optimizations that I thought I'd suggest in case you were interested (these are no means critiques against your code; again: I would've been much more lost on my end without your code - mine would've probably been much more.. "nasty")

Suggestion

Out of curiosity, why did you choose to implement Force Loaded chunks via the /forceload command? I'm sure it's something obvious that I'm just missing. If not, I noticed this:

When I initially got Persistent Bits working, I too used this exact method thanks to your help. In an attempt to resolve this, I looked into the path that calling the /forceload command traverses down, and found net.minecraft.world.server.ServerWorld$forceLoad - which does the exact same thing but silently. See here - the last boolean arg represents whether to add said chunk; true = add, false = remove.

Overall, if you'd like me to make a PR to implement this (because I imagine you're definitely busy with much more important things), I'd be glad to - just let me know. Otherwise, it's honestly not too much chat spam considering it's only for the one chunk (as opposed to Persistent Bits which loads a radius of multiple chunks, thus getting super spammy).

I am running a server using the Direwolf pack v1.7. I recently laid down this mod's chunkloaders on several chunks around my base, and the first time after this that I restarted the server, it hangs on start; the startup process never completes and it does not crash. Attached is the run log for reference, which shows a player being disconnected when they attempt to connect due to the server startup process being incomplete:
2021-03-19-6.log

I left the sever alone for 10+ minutes and it never finished, and I tried restarting the server several times to no avail. As soon as I removed the ChunkNoGoByeBye mod, the world loaded perfectly.

I know other mod's versions of chunkloading have had similar issues in the past, in case it's helpful.

EDIT: To my knowledge, there's nothing corrupt going on in the chunks I'm loading, by the way; they seem to load fine with FTB chunks, FWIW.