lfre / lightkeeper Goto Github PK

I love this project. I've worked with different automated Lighthouse tools, but they always lacked the ability to run on multiple URLs. So it's great to see how advanced the configuration options of this project are!

Since running Lighthouse on many URLs generates many results, I'm opening this issue to discuss possibilities for more concise result tables. I'm thinking of combining all results into a single table:

Lighthouse audit for https://deploy-preview-100--spacefinder.netlify.com:

Ideas in here:

• Base URL on top
• Routes in first column, in this case the relative URL and an alias for the route
• Columns for each category, followed by their thresholds
• Each cell would contain current value (92), old value in parenthesis (if possible), what the trend compared to the last value is ⬆️/ ⬇️/ ... and whether it passes ✅ / ❌

Each route could link to the more detailed results.

Hi, thanks a lot for the awesome project!

I have ran into an issue. I wanted to try out lightkeeper in a project that is stored in a private repo on github and deployed using zeit's now. I've took a look at the examples in your readme and essentially copied the default settings with the zeit now baseUrl, type and ci properties. You can see an example of lightkeeper.json file below. The issue I faced is that on a pull request there were no visible checks from lightkeeper. However, the app did deploy a branch copy with now. Another thing I noticed is that if i go to github.com/<user>/<project>/pull/123/checks I could see that the check was queued up as you can see from the screenshot below.

After rereading the docs I tried to add the exact same config in a similar project, yet it is stored in a public repo (PR). At the end I am still not sure if having it to run on a private repo requires an undocumented extra step? If so I am happy to add it to the docs but I have not figured it out yet.

Update: turns out even on the public repo it seems like it ran lighthouse against zeit.co instead of the deployment of my branch.

{
  "baseUrl": "{target_url}",
  "ci": "now",
  "type": "deployment",
  "settings": {
    "categories": {
      "performance": 58,
      "accessibility": 57,
      "best-practices": 64
    },
    "budgets": [
      {
        "resourceSizes": [
          {
            "resourceType": "script",
            "budget": 300
          },
          {
            "resourceType": "image",
            "budget": 100
          },
          {
            "resourceType": "third-party",
            "budget": 200
          },
          {
            "resourceType": "total",
            "budget": 1000
          }
        ],
        "resourceCounts": [
          {
            "resourceType": "third-party",
            "budget": 50
          },
          {
            "resourceType": "total",
            "budget": 50
          }
        ]
      }
    ]
  },
  "routes": [
    "/"
  ]
}

Hello! First of all as the creator of lighthouse-gh-reporter id like to say that I'm so glad to see that my small tool contributed to inspire you. You put my idea to the next level as my next step in mind was exactly, more or less what you have done so.. congratulations 👍 👏

On the other hand I'd like to contribute into make this something that the people start to use and to enjoy using and in order to do it I think that we must create a dummy report of the bot in order to see a real scenario in which the bot, the config and everything get working.

I'd like to know your thoughts about whats the best way to do it.