lgug2z / komorebi-application-specific-configuration Goto Github PK

When Teams is minimized and a meeting is in progress, there is a floating widget that appears. Screenshot of the widget here.

Currently it is treated like a full window but it's only roughly 100px by 100px, creating a lot of wasted space, so it needs to be treated as floating. Here is the info from AHK's window spy:

Microsoft Teams Call in progress Teams Echo
ahk_class Chrome_WidgetWin_1
ahk_exe Teams.exe
ahk_pid 16812

I tried matching by class Chrome_WidgetWin_1 but unfortunately the main MS Teams window uses the same class so the main window is also treated as floating. The title Microsoft Teams Call in progress Teams Echo is dependent on the meeting/call. Here I am in a call with Teams Echo but that part of the title string is variable. I tried to match on title Microsoft Teams Call in progress but it seems komorebi expects a full title.

Hello everybody, you'll be happy to know that in the next version of komorebi (v0.1.19), a complete refactor of matching rules will be shipped. 🎉

Each identifier object will now take an optional matching_strategy, which if not set, will default to Legacy in order to avoid breaking changes for existing users.

The matching_strategy options available will be:

• Legacy - What komorebi has done until now
• StartsWith - stdlib function
• EndsWith - stdlib function
• Contains - stdlib function
• Equals - stdlib function
• Regex - Any regex that can be compiled by the default settings/features of the regex crate

These will be available to use both here in applications.yaml, and in your own personal komorebi.json files.

If you would like to contribute to the komorebi ecosystem, this issue is a great place to start! You can work on PRs adding simple matching strategies like Equals for exes, or more complex rules using regexes which have not been possible to build until now.

We will hold off on merging any of these PRs until v0.1.19 has been out for a week or so to give people time to upgrade, so don't worry if you don't see your PRs merged immediately!

I saw mpv is already added to the application specific configuration (actually it seems the PR adding mpv and mpv.net is partly reverted, because I see no mpv in my applications.yaml), so not sure if others deem this as the right way to handle it. For me I'd very much prefer it to be tiled normally.

If it is done on purpose, I petition to revert that.

There are still many rules using Legacy as a matching strategy. In most cases, the rule is fuzzier than it needs to be, risking matching unintended windows. All existing Legacy matching strategies should be replaced with one of the following:

• Equals
• OpensWith
• EndsWith

To facilitate the conversion, I will keep an updated list of remaining Legacy matchers in the comments below.

I found that I have to add Run, komorebic.exe manage-rule exe OUTLOOK.EXE, , Hide to my komorebi.ahk or else Outlook doesn't get managed.

Before I go through the trouble of doing a PR, is there anyone else that has this issue or just me?