Giter VIP home page Giter VIP logo

cassie's People

Contributors

alissonsteffens avatar dependabot[bot] avatar israolive avatar pedrounas avatar rafaelqg avatar vinigmartins avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

cassie's Issues

Add Code Lint

Since one of the project goals is to be easy to contribute, besides having a contribution guide (#57 ) we also need our code to be consistent.

I think we should use some linting to make our code easier to understand.

We could use ESlint

edit: we already use elsint, but not for checking code. We should create some rules

Problem with CONTRIBUTING.md

CONTRIBUTING.md is not a good description of how to contribute to the project. And it needs to be translated to English.

License

CASSIE needs a license file.

Missing time on image data

Cassie should also show the hour the image was taken, so the user can find sea level information about it.

image

Verify EPR calculations

An advanced user (with extended DSAS experience) has reported that the rate of change for "EPR" does not seem accurate for the examples given (paper, tutorial, manual).

Therefore, we have to check if the actual EPR calculations are right by comparing with some verified DSAS analysis product.

Error with 1999-09-18 Landsat image

Landsat seems to struggle in finding the right place for this image

image

Image ID is: LANDSAT/LT05/C01/T1_SR/LT05_220079_19990918

The region is the Cabeçuda Beach in Itajaí

Language selection does not remain

Describe the bug
When a user selects the English language on the website, it does not remain in English after a refresh of the page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the home page
  2. Select the en-US language from the top right-hand corner menu
  3. Refresh the page

Expected behavior
The language should remain in English after the refresh.

plural on image acquisition

When getting images, cassie should be able to use singular form, if the range is in the singular (like one year)

We can easily solve this by using a simple ternary operation choosing between a singular form (year) or plural (years)

image

Dialogs are registered on exporting

Problem

This is a bad programming pattern.
The dialogs are automatic registered on importing, which leads the MainPage to have lots of "unused imports".

Expected

The Dialog component should be exported as it is and registered by the page that wants to use it.

Discussed in https://github.com/lia-univali/cassie/discussions/67

Originally posted by AlissonSteffens April 2, 2021
Atualmente as caixas de dialogo tem um comportamento estranho

Elas são importadas na MainPage como se fossem componente ou pacotes

import CoastlineEvolutionDialog from "../../components/dialog/CoastlineEvolutionDialog";
import CoastlineConfigDialog from "../../components/dialog/CoastlineConfigDialog";
import NewLayerDialog from "../../components/dialog/NewLayerDialog";
import ImageSelectionDialog from "../../components/dialog/ImageSelectionDialog";

e só.

Por algum motivo elas são registradas pelo método registerDialog no redux

Acho que faz sentido estas janelas serem cadastradas lá mas não deste jeito.
Assim são apenas importações não utilizadas

talvez adicionar um método cadastrar na MainPage

Problem in layers with channel visualization

Problem

It is necessary to adjust the viewing parameters so that images can use the whole spectrum of brightness.
The problem is that image histogram distribution is not homogeneous enough.

image

It makes the image hard to visualize.

image

Solution

The solution is to change the min and max luminosity (when visualizing) by removing an X percentile of pixels count from both ends of the histogram.

image

Implement the ShorelineS algorithm in cassie

The ShorelineS algorithm is able to describe large coastal transformations based on relatively simple principles of alongshore transport gradient driven changes as a result of coastline curvature, including under highly obliquely incident waves, and consideration of splitting and merging of coastlines, and longshore transport disturbance by hard structures. An arbitrary number of coast sections is supported, which can be open or closed and can interact with each other through relatively straightforward merging and splitting mechanisms. Rocky parts or structures may block wave energy and/or longshore sediment transport. These features allow for a rich behavior including shoreline undulations and formation of spits, migrating islands, merging of coastal shapes, salients and tombolos.

image

Cassie doesn't remove a baseline when the user cancels it

Describe the bug
Although it isn't used, Cassie doesn't remove a baseline when the user cancels it

To Reproduce
In the processing page, start making a coastline analysis and then can it while drawing the baseline

Expected behavior
The canceled baseline should be deleted

Screenshots
image

Technical review
the problem only happens when you cancel the baseline while drawing
image
If you doubleclick and go to params screen, it will be deleted when you create the next one

Solution
The handleAnalyzeCoastline function

export const handleAnalyzeCoastline = function* () {

Is the saga that resolves the Coastline Analises
All overlays made by this function should be placed under the "coastlineData"
const identifier = "coastlineData";

Somehow, while in request and wait
export const requestAndWait = function* (drawingType, message, name, group) {

the function that cancels the drawing is just letting the overlay in the void
It would probably be solved if when canceled, the line was commited to the map (the same way it is when doubleclicked)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.