The following code sample is converted incorrectly:

void main()
{
for(unsigned short i = 0; i <= 1; i++)
{
i = 0;
int j;
}
}

The result is:

void main()
{
{ unsigned short i = 0; for( short i = 0; i <= 1; i++)
{
i = 0;
{ int j;
} } }
}

void test()
{
    for(int j=0; j < 10; j++) {
        for(int i=0; i < 20; i++) {
        }
    }
}

is converted to

void test()
{
    { int j=0; for( ; i < 20; i++) {
        }
    } }
}

Converting following code causes the converter to mangle the else if, producing "elseif" (one word) in the output, obviously breaking compilation:

typedef struct AVRational{
    int num; ///< numerator
    int den; ///< denominator
} AVRational;

int av_rescale_q(int a, AVRational bq, AVRational cq);

int main()
{
    AVRational framerate = {1,25};
    if (1) {
        int next_dts = av_rescale_q(1,  (AVRational){1, 1000000}, framerate);
    } else if (2) {
        // nada!
    }
    return 0;
}

The issue does not seem to appear if the inline struct is the third function parameter, in this case anyway.

When trying to compile ffmpeg with --enable-shared, the conversion fails.

This can be traced to this define
define av_export __declspec(dllimport)

And for example in libavformat/asfenc.c

It fails due to this line getting included from riff.h
extern av_export const AVCodecTag ff_codec_bmp_tags[];

Which creates in the converted c89 file for asfenc.c
extern __declspec(dllimport) const AVCodecTag ff_codec_bmp_tags[];

causing this line to have a compile error (in asfenc.c)
static const AVCodecTag * const tmp__1[] = {
codec_asf_bmp_tags, ff_codec_bmp_tags, ff_codec_wav_tags, 0
};

--> error C2099: Initializer is not a constant

Maybe this isn't fixable though? Not sure

Figure braces are inserted without regard of the preprocessor directives.
Example:

void main()
{
int a;
a = 0;
int b;

line 1 "D:\qwe.c"

}

is converted to:

void main()
{
int a;
a = 0;
{ int b;

line 1 "D:\qwe.c" }

}

Th closing "}" brace breaks the #line directive.

Would be nice if it output to the screen failures from its sub process (ex: cl).
at least it didn't for me just now, FWIW (msys).

$ c99wrap cl ...   -c -o libavdevice/alldevices.o libavdevice/alldevices.c

rdp@roger-win10 MSYS /c/dev/ffmpeg/ffmpeg_git_msvc
$ echo $?
1

rdp@roger-win10 MSYS /c/dev/ffmpeg/ffmpeg_git_msvc
$ cl...   -c -o libavdevice/alldevices.o libavdevice/alldevices.c
cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
alldevices.c
c:\dev\ffmpeg\ffmpeg_git_msvc\libavutil\common.h(34) : fatal error C1083: Cannot open include file: 'inttypes.h': No such file or directory

(the latter said what the error was)

This input gets converted incorrectly
int main () { for( int i = 0; i < 9; i++ ); return 0; }
into this:
int main () { { int i = 0; for( ; i < 9; i++ ); }return0; }

The token input/output positions need to be updated correctly.. somewhere.., so we produce enough whitespace between "return0;". I added a test case for it in a branch in my repo as well: mstorsjo@for-loop-test

This exact piece of code is used in x264's configure script for testing for the C99 features.

The converter crashes on input source code like this:

struct a {
struct b {
int c;
int d;
} e;
float f;
} g = {.e.c = 3 };

Hello,
this project is incredibly interesting for homebrew development for the Nokia N-Gage, as we are currently tied to a very early version of GCC. However, the wrapper does not seem to work as long as an output file is specified via CMake:

... -DRENDERER_SOFTWARE -w -O3 -o CMakeFiles\game.dir\src\wipeout\camera.c.obj -c C:\Development\Projects\ngage-toolchain\projects\wipeout\src\wipeout\camera.c

This throws the following error message:
CMakeFiles\game.dir\src\wipeout\camera.c.obj_preprocessed.c: No such file or directory

I can reproduce the problem on the command line. If I write the entire command there without the source file in quotes, the wrapper works perfectly. Unfortunately, I have not yet been able to get CMake to adjust the generated prompt accordingly.

Is this project still supported? Do you have a tip how I can fix the problem to use the wrapper together with a quite old version of GCC?

Best regards,
Michael

Hi
I've build c99conv and test it on unit.c test file.
When I commented out all #defines in unit.c it works fine.
But when converter faced with #defines, it crashes.
Also, I've found precompiled binaries in download section.
It crashes too.

Can you give me any advice?

str1 = whatever;
if (strlen(str1) == 0) return whatever;
char str2[strlen(str1)+ 1];
strcpy(str2, str1);
whatever

becomes something like

str1 = whatever;
if (strlen(str1) == 0) return whatever;
{ char str2[strlen(str1)+ 1];
strcpy(str2, str1);
whatever
}

It could be done near-properly by using alloca, i.e. _alloca (for MSVC):

str1 = whatever;
if (strlen(str1) == 0) return whatever;
{ char* str2 = _alloca(strlen(str1) + 1);
strcpy(str2, str1);
whatever
}

In case it was a concious decision not to Support VLA, then this should be mentioned in the readme.
In general it would be helpful if known limits of c99-to-c89 were documented, at least roughly.

That said, it is still a more than helpful tool. Thanks for creating it!

$subject, a test case (both a simple one and the full-blown one that triggered it in the user case) exists in mstorsjo@enum-cast.

I try to compile ffmpeg with dinamic runtime libraries, but at end of building process I have errors:

LD      ffmpeg_g.exe
LINK : warning LNK4098: defaultlib 'LIBCMT' conflicts with use of other libs; us
e /NODEFAULTLIB:library
libavutil.a(opt.o) : error LNK2001: unresolved external symbol __imp__avpriv_snp
rintf
libavutil.a(pixdesc.o) : error LNK2001: unresolved external symbol __imp__avpriv
_snprintf
libavutil.a(samplefmt.o) : error LNK2001: unresolved external symbol __imp__avpr
iv_snprintf

...

ffmpeg.o : error LNK2019: unresolved external symbol __imp__avpriv_vsnprintf ref
erenced in function _update_benchmark
libavformat.a(aviobuf.o) : error LNK2001: unresolved external symbol __imp__avpr
iv_vsnprintf
libavformat.a(utils.o) : error LNK2001: unresolved external symbol __imp__avpriv
_vsnprintf
libavformat.a(rtpproto.o) : error LNK2001: unresolved external symbol __imp__avp
riv_vsnprintf
libavformat.a(rtmpproto.o) : error LNK2019: unresolved external symbol __imp__av
priv_strtod referenced in function _rtmp_write_amf_data
libavformat.a(sbgdec.o) : error LNK2001: unresolved external symbol __imp__avpri
v_strtod
libavutil.a(parseutils.o) : error LNK2001: unresolved external symbol __imp__avp
riv_strtod
libavutil.a(eval.o) : error LNK2001: unresolved external symbol __imp__avpriv_st
rtod
ffmpeg_g.exe : fatal error LNK1120: 3 unresolved externals
make: *** [ffmpeg_g.exe] Error 1

I have found out, that the reason of this errors is declarartion of functions of standart library in MSVC. If compilation evoked with optin -MD, all standart functions are declared as imported from DLL.

__declspec(dllimport) int __cdecl _snprintf(   char *_Dest,   size_t _Count,     const char * _Format, ...);

But build system of ffmpeg compiles sources with next command:

c99wrap cl -I. -I./ -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE \
-Dstrtod=avpriv_strtod -Dsnprintf=avpriv_snprintf -D_snprintf=avpriv_snprintf \
-Dvsnprintf=avpriv_vsnprintf -DHAVE_AV_CONFIG_H -nologo -D_USE_MATH_DEFINES \
-Dinline=__inline -FIstdlib.h -Dstrtoll=_strtoi64   -Oy -Z7 -W4 -wd4244 \
-wd4127 -wd4018 -wd4389 -wd4146 -wd4057 -wd4204 -wd4706 -wd4305 -wd4152 \
-wd4324 -we4013 -wd4100 -wd4214 -wd4554 -wd4996 -wd4273 -O2 -MD     -c \
-Fo libavutil/eval.o libavutil/eval.c

I.e all occurences of _snprintf replaced with avpriv_snprintf.

And after preprocessing we have avpriv_snprintf declared as imported from DLL!

This issue is found during ffmpeg 2.0.1 compilation under windows.
Previously I have compiled ffmpeg with msvc toolset and c99-to-c89 1.0.1 library.
Now I am trying to compile ffmpeg with icl toolset.
ffmpeg calls c99wrap with -noconv option which doesn't work in c99wrap 1.0.1. So I updated c99-to-c89 to 1.0.2. c99wrap works correct now. But there is other issue with makedef.

During ffmpeg compilation makedef is called like this:
makedef libavcodec/libavcodec.ver file1.o ... fileN.o > somefile.def

It works on default libavcodec.ver file. But I need one more function exported from the avcodec.dll. So my libavcodec.ver file contains one more line in global section:
ff_find_hwaccel;

The issue that output def-file doesn't contain this function "ff_find_hwaccel".

I have replaced makedef by 1.0.1 (perl version) and now it works: output def-file contains my function (ff_find_hwaccel).

The converter goes to an infinite loop on an input source like

static short grid[3] [4] = { [2][0] = 8, [2][1] = 6,
[2][2] = 4, [2][3] = 1 };