libretro / beetle-bsnes-libretro Goto Github PK

It currently compiles fine, but crashes when run. To fix this, do the following:

1. Edit Makefile and add CFLAGS += -DIOS to the iOS section.

2. Replace libretro-mednafen_snes/mednafen/snes/src/lib/libco/ with https://github.com/libretro/libretro-common/tree/master/libco

3. Put https://github.com/libretro/libretro-common/blob/master/include/retro_common_api.h and https://github.com/libretro/libretro-common/blob/master/include/libco.h to libretro-mednafen_snes/mednafen/snes/src/lib/libco/

Mednafen has a newer, faster module called snes_faust, which is actually under active development. It would be nice if there were a libretro core for it, instead of this slow, unmaintained bsnes-based one.

All entries are blank. The controller works at first but if you try to modify controls or press start to reset to default, it will break that button until content is restarted

.
This is on Windows

mednafen/mednafen.cpp:

 temp = new char[4096];
 vsnprintf(temp, 4096, format, ap);
 MDFND_PrintError(temp);
 free(temp);

This makes clang asan unhappy.
At least delete[] temp; should be used, or probably better rewrite to:

 char temp[4096];
 vsnprintf(temp, sizeof(temp), format, ap);
 MDFND_PrintError(temp);

Activating the latency reduction leads to a weird jumping of frames.
Sometimes frames are dropped sometimes completely different frames are added.
Best examples are Donkey Kong Country or Super Mario World.

I noticed that the emulator doesn't start (as part of Kodi's RetroPlayer work) because the call to MDFN_MakeFName() with MDFNMKF_PALETTE fails at https://github.com/libretro/beetle-bsnes-libretro/blob/master/mednafen/snes/interface.cpp#L63 because the implementation of MDFN_MakeFName() at https://github.com/libretro/beetle-bsnes-libretro/blob/master/libretro.cpp#L520 does not handle MDFNMKF_PALETTE as a type.

In the log I get

Loading xxxx.smc...
Using module: snes(Super Nintendo Entertainment System/Super Famicom)
MDFN_MakeFName: xxxx.srm
MDFN_MakeFName: xxxx.rtc
MDFN_MakeFName:
  Loading custom palette from ""...
   Error opening file: Invalid argument

The same issue applies to beetle-gba-libretro.
The implementation of MDFN_MakeFName() in https://github.com/libretro/mednafen-git/blob/master/src/general.cpp#L285 seems to be able to handle this case.