libvarun / forge-extensions Goto Github PK

let's make 1 bucket persistent with a few sample files (1 of each kind/industry), we can collect them later. Block upload on this bucket (client & server)

and 1 bucket transient where users can upload files, and consider adding a delete right-click menu.

nice work @petrbroz !

can we add:

1. readme on the extension folder (general how the code works, limitations, author, etc.)
2. link to it from the app (see #2 @libvarun )

and maybe add (not major)

1. resizable?
2. toolbar button with push style (on/off)

some expected behavior (from other samples):

1. click on the nested, highlight/select on the main? (and vice-versa)
2. option on the config.json to show only 2D (or only 3D)?

shouldn't this be inside the document ready event? may fail on slow connection...

https://github.com/libvarun/StandardExtensions/blob/master/public/StandardExtensions/extensionloader.js#L3

It seems that the filestoload assets in config.json can only be local (relative to the contents subfolder). It might be a good idea to support external dependencies as well, so that, for example, instead of including the same xlsx.min.min.js into every single extension that needs to generate an Excel file, we could just reference it from a CDN, for example: https://cdnjs.cloudflare.com/ajax/libs/xlsx/0.15.2/xlsx.core.min.js.

implement webhook for MD and a websocket connection to show the model when ready

(nice to have, maybe later)

It would be good to document the process of integrating an extension into a 3rd party application, for example, things like:

• copying the extension code and related assets to the right place (images, CSS, etc.)
• loading the extension (via viewer constructor, or using viewer.loadExtension)
• configuring the extension (copy/pasting the "options" object from config.json)

We already had one user run into issues because they copy/pasted the extension files to their project but forgot to configure it based on the config.json file.

When creating a new extensions, there is internal config
(g.e. public/extensions/BasicSkeleton/config.json)
and there is aggregated config
public/extensions/config.json, which has Extension array with content of those internal configs.

The internal config seems to be redundant, yet its content is important.
The current process of adding a new extension is to add a folder, write the config, then copy the content of internal config content into the Extension part of the aggregated config

Perhaps a better approach would be that upon server starting, to autofill the Extension part of the aggregated config , by traversing the content of public/extensions subfolders and insert into Extension array the content of each config.

Thus, the process of adding a new extension would be just to add a folder with presented structure and have the config in that folder.

have a button to enable/disable it

this is really nice, can you also prepare it to have a link to a readme or blog post?

for usability, can we add a config option to only load in 2D, or 3D, or both? for instance, the current Icon Markup works only in 3d...

requires: 2d|3d

not sure if that's a feature or property on the built-in extensions, explode is an example, can you check?

remove this white space... :)

maybe both sidebars to look the same?

for consistency with other samples, let's use PORT 3000 at readme>setup

for consistency, let's use * (instead of x)

https://github.com/libvarun/StandardExtensions/blob/master/public/StandardExtensions/BasicSkeleton/config.json#L6

• add a section with list of extensions (for now, just "transform")
• add a thumbnail image (must be thumbnail.png or .gif at the root folder)
• setup section should be how to run it locally (this is there, but at the bottom, just a matter of organizing it)
• add a section for "how to add new extensions"

the "Understanding extensionloader..." section is good, nice work

Let's make sure people use the /autodesk-forge repo, so please:

1. create a new commit removing all files
2. add a note on the main readme pointing to /autodesk-forge/forge-extensions

(found a few links to this repo, so please don't delete it...)